17 replies

For bluefin tags. Looks like we lost

bsherman•4/8/24, 9:50 PM

oh?

M2OP•4/8/24, 9:51 PM

Yeah, we had a matrix variable previously it loos like that is not present anymore

bsherman•4/8/24, 9:51 PM

which one?

M2OP•4/8/24, 9:51 PM

matrix.is_latest_version

M2OP•4/8/24, 9:51 PM

matrix.is_stable_version

bsherman•4/8/24, 9:51 PM

that got moved

M2OP•4/8/24, 9:52 PM

Yes

M2OP•4/8/24, 9:52 PM

but it's referring to matrix.name instead of the variable name.

bsherman•4/8/24, 9:52 PM

instead of a matrix variable being used only to setup bash vars in the single "tags" step, its now a conditional in the "tags" step

M2OP•4/8/24, 9:53 PM

https://github.com/ublue-os/bluefin/actions/runs/8604817085/job/23579734249#step:8:37

As you can see it's being compared against an empty string. ${{ matrix.is_latest_version }} is empty

bsherman•4/8/24, 9:54 PM

ok, yeah, that's a bug

c'mon on thought you reviewed my PR

M2OP•4/8/24, 9:54 PM

Yepp. I'm fixing right now

bsherman•4/8/24, 9:54 PM

thanks!

M2OP•4/8/24, 9:54 PM

Since we are in bash run right here. I can just use the bash variable name

bsherman•4/8/24, 9:54 PM

it should be clear, since the bash vars map to the old matrix vars

bsherman•4/8/24, 9:55 PM

thank you for catching this

M2OP•4/8/24, 9:57 PM

bluefin favicom!

M2OP•4/8/24, 10:02 PM