rival-black

Type is not assignable to type mutate function

Hello all, I get this error

Type updateDummy is not assignable to type mutation function

Type updateDummy is not assignable to type mutation function

and I am unsure how to fix it. I followed the same pattern as my createDummy function, both of which write react query functions to make mutation calls to the database.

import { type UpdateDummyDto, type CreateDummyDto } from "@bookwave/api-client";
import { useMutation, useQueryClient } from "@tanstack/react-query";
import { DummyApiKeys } from "@/features/dummy/queries";
import { apiClient } from "@/lib/api/api-client";
import { captureAndRethrowException } from "@/lib/error/capture-and-rethrow-exception";

export const useCreateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: createDummy,
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: updateDummy,
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

async function createDummy(dummy: CreateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.createOne(dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

async function updateDummy(dummyId: string, dummy: UpdateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.updateOne(dummyId, dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

import { type UpdateDummyDto, type CreateDummyDto } from "@bookwave/api-client";
import { useMutation, useQueryClient } from "@tanstack/react-query";
import { DummyApiKeys } from "@/features/dummy/queries";
import { apiClient } from "@/lib/api/api-client";
import { captureAndRethrowException } from "@/lib/error/capture-and-rethrow-exception";

export const useCreateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: createDummy,
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: updateDummy,
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

async function createDummy(dummy: CreateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.createOne(dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

async function updateDummy(dummyId: string, dummy: UpdateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.updateOne(dummyId, dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

14 Replies

sensitive-blue•2y ago

mutationFn only provides one parameter. You'll need to combine dummyId and dummy under one object

sensitive-blue•2y ago

https://tkdodo.eu/blog/mastering-mutations-in-react-query#mutations-only-take-one-argument-for-variables

Mastering Mutations in React Query

Learn all about the concept of performing side effects on the server with React Query.

sensitive-blue•2y ago

If your updateDummy method must be that way, you could do:

mutationFn: ({ dummyId, ...dummy }) => updateDummy(dummyId, dummy)

mutationFn: ({ dummyId, ...dummy }) => updateDummy(dummyId, dummy)

And invoke via something like:

// This dummy has dummyId on it
mutation.mutate(dummy)

// This dummy has dummyId on it
mutation.mutate(dummy)

rival-blackOP•2y ago

Thank you @troywoy for your reply Should I be spreading the contents of the dummy object?

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: ({ dummyId, dummy }) => updateDummy(dummyId, dummy),
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: ({ dummyId, dummy }) => updateDummy(dummyId, dummy),
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

sensitive-blue•2y ago

Depends on how you call mutate

rival-blackOP•2y ago

I'd like to keep the params for the createDummy api call unchanged:

async function updateDummy(dummyId: string, dummy: UpdateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.updateOne(dummyId, dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

async function updateDummy(dummyId: string, dummy: UpdateDummyDto) {
  try {
    // Artificial wait so you can see what happens on the UI while the request
    // is in flight.
    await new Promise((resolve) => {
      setTimeout(resolve, 2000);
    });

    const response = await apiClient.dummy.updateOne(dummyId, dummy);
    return response;
  } catch (err: unknown) {
    captureAndRethrowException(err);
  }
}

When I implement this code change:

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: ({ dummyId, dummy }) => updateDummy(dummyId, dummy),
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

export const useUpdateDummyMutation = () => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: ({ dummyId, dummy }) => updateDummy(dummyId, dummy),
    onSuccess: async () => {
      await queryClient.invalidateQueries({
        queryKey: DummyApiKeys.fetchAll(),
      });
    },
  });
};

sensitive-blue•2y ago

And how do you call mutate from useUpdateDummyMutation?

rival-blackOP•2y ago

I get new TS error properties don't exist on type 'void'

sensitive-blue•2y ago

You need to type the ({ dummyId, dummy }) => portion

sensitive-blue•2y ago

https://www.typescriptlang.org/play/?#code/JYWwDg9gTgLgBAbzgVwM4FMCyyYEMbAQB2cAvnAGZQQhwDkAAnkangMYDWA9FOrmzAC0AR2TooATzoBuAFDzcqCUTaVkKgsRRgAJvnQARZCBASAFDuOmAkjoBccIsYBG4gDRxLJiQ4jOAVugCAJSIsgCQvDDIUCQACtQgwBgAdLyoEAA2AG7oZjBQYsFypPLoAB6QsHBsxKwoGACquvpG3th4miQAvHBmod0AfGGR6NGxDVg4+IREZggR4SDTXQBiRA7znlYSth4pB16mZA5IR7v2ji7u296+AUHwpAPDyC0whjsWO3u3psERZ4lORAA

TS Playground - An online editor for exploring TypeScript and JavaS...

The Playground lets you write TypeScript or JavaScript online in a safe and sharable way.

sensitive-blue•2y ago

That's a sloppy example

rival-blackOP•2y ago

I call useMutate as part of a long form submission, here's the relevant part:

  const updateDummyMutation = useUpdateDummyMutation();
  const doSubmit = handleSubmit(async (fields) => {
    const dummy = {
      foo: fields.foo,
      bar: fields.bar,
      content: fields.content,
    };
    try {
      await updateDummyMutation.mutateAsync({ dummyId, dummy });
      reset();
    } catch (err: unknown) {
      console.log(err);
    }
  });

  const updateDummyMutation = useUpdateDummyMutation();
  const doSubmit = handleSubmit(async (fields) => {
    const dummy = {
      foo: fields.foo,
      bar: fields.bar,
      content: fields.content,
    };
    try {
      await updateDummyMutation.mutateAsync({ dummyId, dummy });
      reset();
    } catch (err: unknown) {
      console.log(err);
    }
  });

sensitive-blue•2y ago

You have two options there. Either spread ...dummy on the mutateAsync line:

await updateDummyMutation.mutateAsync({ dummyId, ...dummy });

await updateDummyMutation.mutateAsync({ dummyId, ...dummy });

Or put dummyId onto the const dummy object and simply use that:

const dummy = {
  dummyId,
  foo: fields.foo,
  bar: fields.bar,
  content: fields.content,
};

await updateDummyMutation.mutateAsync(dummy);

const dummy = {
  dummyId,
  foo: fields.foo,
  bar: fields.bar,
  content: fields.content,
};

await updateDummyMutation.mutateAsync(dummy);

rival-blackOP•2y ago

@troywoy thank you very much. You have helped immensely.

Gaming

Programming

Type is not assignable to type mutate function

Did you find this page helpful?