Typebot•17mo ago

Nocodb updating ALL records in column if selection logic is not matched

I love nocoDB, it is so fast.

But I just noticed a bug and it seems significant-

If there are no matches for the "Select Records" logic in the block, instead of not writing any data to the database, it writes the update to EVERY cell in the column. This seems like a HUGE bug. I can put the update inside of typebot logic but that will just make it all more complex since it is NOT working in the NocoDB block.

greenrhynoOP•8/13/24, 2:36 PM

@Baptiste This one is kind of critical for me. Why would it ever be better to write a whole column if the filter fails to find a match? And nocoDB cloud doesn't have versioning or rollback at all so this is just danger-zone for me.

Any way you can take a quick look and just make sure values are only written if the filter/search evaluates to a specific row or sets of rows and only writes the value in those rows?

Right now when the search fails it writes the WHOLE collumn.

greenrhynoOP•8/13/24, 2:36 PM

Also I can't spell.

greenrhynoOP•8/13/24, 2:37 PM

Thanks ChatGPT

Screen_Shot_2024-08-13_at_8.37.18_AM.png

Baptiste•8/13/24, 2:53 PM

I am not sure to understand

Baptiste•8/13/24, 2:53 PM

What is the issue exactly?

Baptiste•8/13/24, 2:53 PM

Steps to reproduce
What's happening
What were you expecting

greenrhynoOP•8/13/24, 4:15 PM

Ok, I made you a video. Feel free to skip around. But:

Create a nocoDB with a column for the filter and a column for the correlated values. Send an update to nocoDB with typebot, where the filter evaluates the column ID and checks if it is equal to a BLANK value (such as either an empty variable or an empty input for the checed value).
The filter should only select a column where the value is also BLANK if it evaluates to a true column at all. What is happening is it is returing ALL of the rows as meeting the filter. So it is replacing ALL correlated values (to the column you are trying to set) in the WHOLE table.
If the filter evaluates to an empty variable or a variable with no value, NOTHING in the table should change at all.

In the video- I also thought there was in issue with entering the ID variable as a number but in the video it did it correctly so don't worry about that part.. About 5:15 to 6:55 you can ignore it actually works correctly.

But the filter evaluating to blank does definitely rewrite the entire column.

https://d.pr/v/NmDWLR

Droplr

typebot_to_nocoDB_emptyFilterIssue.mp4

Shared with Droplr

greenrhynoOP•8/13/24, 4:25 PM

Just skip to the last minute or so to see the issue quickly.

It's just if the filter is checking a column value against either a blank variable or a blank field, it just evaluates as true for every single row for the update.

greenrhynoOP•8/14/24, 3:50 AM

Found another SMALL issue with the nocoDB implementation.

IF you are searching a table and your filter is set to a variable with no value, it will return the whatever the filter asks for the whole table- so for first: first value, last: last value, all: json array of ALL values in column.

I guess this is fine but I would think if there is no actual matches, it shouldn't return anything (although I can see the utility of not having to set a variable to pull a random value or all values as an array/list). But I would think first or last should require a match.

This is a much smaller issue than the overwriting that happens with the update module as explained above.

Baptiste•8/14/24, 8:57 AM

Alright makes much sense thank you for the clear video

Baptiste•8/14/24, 8:58 AM

Will fix this ASAP: https://github.com/baptisteArno/typebot.io/issues/1702

GitHub

NocoDB update empty filter updates all rows · Issue #1702 · baptist...

greenrhynoOP•8/14/24, 4:38 PM

Will you also drop a comment here when this is fixed? I can test it and remove the compensating logic from my bots once this is fixed. Thanks!

Baptiste•8/16/24, 3:49 PM

Should be fixed now!

greenrhynoOP•8/16/24, 3:53 PM

Oh ok, I just came here to check on this LOL.

I was working on this late last night and got 6 columns of test data overwritten and no way to go back.

It was just test data but... LOL

Ok, I will check this today to see if the issue is not there for me any more. THANKS!!!

Nocodb updating ALL records in column if selection logic is not matched

Similar Threads

Similar Threads

Similar Threads