Improving / forking on existing packages
Hello !
Context : I was interested in using the existing package Tabbed-Chatlog. Seeing as it was not compatible with FoundryV12, and did not totally suit my needs, I took on myself to make this compatibility happen, and maybe posting here in #endangered-packages to see if it was still maintained or not (I thought it was not because it hasn't been updated since v9). After reviewing the code, I decided it did not suit my coding style, and started rewriting it from scratch, matching what I thought were the core features of the packages, and adding my own on it. I now end up with a working module, with additional features on Tabbed-Chatlog, and some features I did not port, because I didn't see them as being part of the core functionality.
I saw in the #endangered-packages chan that the original dev of Tabbed-Chatlog has not stopped maintaining the package. I now end up with this issue : what do I do with mine? It is heavily inspired by Tabbed-Chatlog (having the same functionality of splitting the chatlog in tabs, with the same tabs types for the most part), but dropped some of its features (namely the Discord integration), and added other (notably a feature allowing the creation of dedicated whisper tabs).
I consider it too far from the original to just make a PR to integrate my changes, even more so because I removed features from the existing package, yet I think my version could be of use to people, both simply because it is compatible with Foundry V12 and with the whisper feature.
Should I create a new package ? Should I just keep it for myself ? What is the etiquette here ?
Context : I was interested in using the existing package Tabbed-Chatlog. Seeing as it was not compatible with FoundryV12, and did not totally suit my needs, I took on myself to make this compatibility happen, and maybe posting here in #endangered-packages to see if it was still maintained or not (I thought it was not because it hasn't been updated since v9). After reviewing the code, I decided it did not suit my coding style, and started rewriting it from scratch, matching what I thought were the core features of the packages, and adding my own on it. I now end up with a working module, with additional features on Tabbed-Chatlog, and some features I did not port, because I didn't see them as being part of the core functionality.
I saw in the #endangered-packages chan that the original dev of Tabbed-Chatlog has not stopped maintaining the package. I now end up with this issue : what do I do with mine? It is heavily inspired by Tabbed-Chatlog (having the same functionality of splitting the chatlog in tabs, with the same tabs types for the most part), but dropped some of its features (namely the Discord integration), and added other (notably a feature allowing the creation of dedicated whisper tabs).
I consider it too far from the original to just make a PR to integrate my changes, even more so because I removed features from the existing package, yet I think my version could be of use to people, both simply because it is compatible with Foundry V12 and with the whisper feature.
Should I create a new package ? Should I just keep it for myself ? What is the etiquette here ?
Solution
even if the module was still receiving regular updates, you could always create a new package for your own. but it hasn't received an update in 1 year, 7 months.
as someone who made a chat editing module after DF chat enhancement (and then karakara chat enhancement) both came and went, it's fine to release a module that is similar to an existing module, even moreso if its filling a gap. just submit it for package approval, at least imo
as someone who made a chat editing module after DF chat enhancement (and then karakara chat enhancement) both came and went, it's fine to release a module that is similar to an existing module, even moreso if its filling a gap. just submit it for package approval, at least imo
Was this page helpful?
