19 Replies
@shibo this looks amazing!!!! A couple notes:
make sure to use a shadcn dialog, itll look better and be more responsive
The sidebar is amazing, i love it
Footprinter should have a way to import available parameters- did @Anas work on this?
Make sure to use searchable dropdowns for the chip type input so people can see whats available
The footprinter string field should look “read only” with slight graying and have a “copy to clipboard” icon next to it
Looks great!!!! I absolutely love it!!!!!!!!
Also: the box containing the pcb viewer should not have a border or padding, give it a border radius and set the overflow to hidden and youll get a nice rounded black box without those extra lines.
Cant wait for this feature looks incredible!!!!
Thanks for the feedback I really appreciate it
no thank you!!! very excited for the feature!!!
update
There is still a lot to do
https://github.com/tscircuit/footprinter/issues/75 I require this refactor for quality of life and to make footprint creation more straight forward
GitHub
Any footprint should have a default number of pins; I shouldn't hav...
footprints with a set number of pins like sot235 should not have a num_pins param as it is not configurable, while footprints like soic should have num_pins as optional with a default number of pin...
@Seve I just realised this feature is very convinient for testing footprints, easily change params and immediately see their effect
update 2
Yes thats fine on the refactor!
Nice looks great, lets change the dialog to insert chip since it now inserts a chip not just a footprint string
I would say that if we’re doing chip insertion customizing the schematic would be a good next feature. Eg labeling the pins
tbf let's implement the pcb and test it first so it doesn't get too complicated
Agree!
I’ll refactor all footprints which of them can we pass num_pins. Also we need to add default value of num_pins
thanks
oof discord didn't send this message this morning:
Instead of refactoring out
num_pins which is useful as an output parameter- we can add it as a z.literal(5) for those chips
I guess shibo would still want to know if it's optional or not- actually the best way to do this is maybe via zod shape inspection, this would also allow us to use dropdowns for enums and other fancy things
you can inspect a zod shape like this:
people have used this technique to create zod forms- should work well for us!Good to know
@Seve I merged the feature, but the footprinter repo still needs some work.
- footprints should have default number of pins
- there should be readonly params so that in snippets you know what you can and can't modify
yes please create an issue i can bounty it
https://github.com/tscircuit/footprinter/issues/75 I'll create another one for readonly params
GitHub
Any footprint should have a default number of pins; I shouldn't hav...
footprints with a set number of pins like sot235 should not have a num_pins param as it is not configurable, while footprints like soic should have num_pins as optional with a default number of pin...
GitHub
some params should be readonly like the fixed number of pins in sot...
I want to know from the type received by .json() what params I can and can't change