PyBoy•13mo ago

Save states not functioning properly when sound flag is used

Hello, I've been testing out Pyboy with Pokemon Crystal, and was using the

--sound

--sound

flag to enable the sound. I used Z to store the save state which it did. But when I came back around and tried reloading it with the

--sound

--sound

flag. the sound was gone and an error was present

Sas2kOP•12/18/24, 9:00 AM

Sas2kOP•12/18/24, 9:01 AM

the library seems to be trying reference an invalid pointer/file

Bækalfen•12/18/24, 9:09 AM

I've tried a few things now, and I cannot seem to replicate it on Mac and Linux. I can see you might be on Windows? But that should of course also work

Bækalfen•12/18/24, 9:10 AM

And it works fine if you don't load a saved state?

Bækalfen•12/18/24, 9:14 AM

Could you run PyBoy with and paste the whole output from the terminal?

BBækalfen And it works fine if you don't load a saved state?

Sas2kOP•12/18/24, 9:26 AM

yeah, it works when I run an entirely new instance

Sas2kOP•12/18/24, 9:27 AM

Here's the debug statement

Bækalfen•12/18/24, 12:07 PM

Nothing out of the ordinary

Bækalfen•12/18/24, 12:08 PM

Could you try cloning the repo and inside the repo do as you did before. It should give some more details

BBækalfen Could you try cloning the repo and inside the repo do `python3 -m pyboy ...` as ...

Sas2kOP•12/18/24, 12:42 PM

ah I'll try that, in a moment

Sas2kOP•12/18/24, 12:43 PM

also, the sound compatibility is still in beta right?

Bækalfen•12/18/24, 12:49 PM

It's still in beta, but it shouldn't crash. Just not be perfectly accurate, and sometimes stutter a little

BBækalfen It's still in beta, but it shouldn't crash. Just not be perfectly accurate, and ...

Sas2kOP•12/18/24, 12:59 PM

yeah

krs013•12/18/24, 10:06 PM

I might have an idea what's happening here

krs013•12/18/24, 10:08 PM

On load state, the cpu restores its cycle counter to what it was before, causing the sound device to try to process more samples than it's supposed to.

krs013•12/18/24, 10:10 PM

is initialized to 0 instead of the value of (which probably isn't loaded when the Sound object is made anyway)

krs013•12/18/24, 10:11 PM

to make matters worse, there's this:

I'm not sure why that's instead of for the number of samples to generate--I think we've gone back and forth on it before, but whatever the reason is, if is greater than 2048, it will overrun the sample buffer.

krs013•12/18/24, 10:14 PM

Then the access violation is caused in :

when tries to access a values indexed off of that is outside of the buffer and possibly allocated memory.

krs013•12/18/24, 10:17 PM

I don't know when I'll have time to revisit