C#•12mo ago

Source Generator IDE interaction

I ran into an odd situation where if I generate code for a class with a primary constructor my IDE complains that the partial properties are ambiguous, but if I don’t use a primary constructor it’s fine. And in both cases it builds correctly. I was unable to reproduce in a smaller sample project. Any ideas?
Project with the problem is configured for WPF, .net9.0 and using preview language for partial properties

Angius•12/27/24, 8:37 PM

What source generator?

Angius•12/27/24, 8:37 PM

And take a look at the generated code

Mormon SonOP•12/27/24, 8:40 PM

I realize it wasn’t clear, this is a source generator that I have written myself. The generated code looks fine, it is just implementing INotifyPropertyChanged using partial properties rather than a field like most public SGs do right now.

Angius•12/27/24, 8:41 PM

CommunityToolkit has that, btw

Mormon SonOP•12/27/24, 8:42 PM

Right but right now SGs can’t build on each other so I had to implement it myself

Angius•12/27/24, 8:42 PM

Gotcha

Angius•12/27/24, 8:42 PM

Well, take a look at what code the primary constructor generates: sharplab.io

Angius•12/27/24, 8:42 PM

Perhaps there's some conflict there

Angius•12/27/24, 8:42 PM

Like your generator generating fields with the same names as constructor params or some such

Anton•12/27/24, 8:44 PM

The dependencies might not be configured completely too

Anton•12/27/24, 8:45 PM

like the incremental inputs

Anton•12/27/24, 8:46 PM

so the output isn't regenerated properly when you change the source

Anton•12/27/24, 8:46 PM

but on build I think it would always do a run

Anton•12/27/24, 8:46 PM

hence it working on build

Mormon SonOP•12/27/24, 8:52 PM

This is essentially what my SG generates: https://sharplab.io/#v2:D4AQDABCCMAsDcBYAUOK0B0BhA9gWwAccA7AU2IBcBZHAE1IBslkUQBmCAgQwCcKBLLgygAmCFggAuCAEkAcjgEAzAJ4AFHjgKk+KrAAsuxAOalaKAN4oINqB1IA3chQgatOinsMmzAUSeUABJGtAw6APyumtq6BkamtMy2dlCwEABKXPwAzqRuMZ5xPrQAFDCQxFx4pACUEAC8AHxR7rHeCeEYMsQOOADWpCUU+jkANBBkAO4tBV7xfgEUAII8xtklldU1NcwAvqwc3HyCwiBiWJbWtuycvAJCEABGODjCAMr6OJNXNlbIyclTBQkgCbLkKD8AX9QaD+EoSr4AI4AVyE/EK+COOgAPM9Xo0MAARUhKLjIhgUDBI1EMdZKfiMWjjBxCZG1OogADsIJhtnpjIaEBZDDZPN5GSyuXyHjmxQ2VVIOHhHy+2zFyX2/1sms1B1uxweZ3EZWgkAGKjq0OuHHKEAA0qQVBALBAgfAILtBeaxTcjvdhHj3p9pi63RBwe7PfUIBQeKKULsgA=

SharpLab

C#/VB/F# compiler playground.

Mormon SonOP•12/27/24, 9:18 PM

This has to be some sort of weird caching issue because I just removed my SG entirely for this class and just added the extra partial definitions in non generated code and still see the same issue.

SleepWellPupper•12/30/24, 10:44 PM

Could you share the SG repo?

Mormon SonOP•12/31/24, 10:59 PM

Ended up finding it’s an IDE error and reproducable with no source generators.

https://developercommunity.microsoft.com/t/Partial-Property-on-class-with-Primary-C/10820515

Microsoft Developer Community