akmod build failures 2025-01, 15-16

B

bsherman•1/17/25, 4:48 PM

@M2 i don't expect you to jump on this right now, but want you aware of the thread

B

bsherman•1/17/25, 4:51 PM

history of recent akmods failures...
build from 2 nights ago (Jan15)

ublue akmods 40 was 100% success
ublue akmods 41 was 100% fail

that's pretty unusual by itself

B

bsherman•1/17/25, 4:52 PM

build from last night (Jan 16)

both akmods 40 and 41 were 100% fail

M

M2•1/17/25, 4:55 PM

https://github.com/ublue-os/akmods/actions/runs/12820180529/job/35749303300#step:12:3215

GitHub

ublue akmods 40 · ublue-os/akmods@699f1fe

A caching layer for pre-built Fedora akmod RPMs. Contribute to ublue-os/akmods development by creating an account on GitHub.

B

bsherman•1/17/25, 4:55 PM

yeah, i was just getting to describing that

B

bsherman•1/17/25, 4:55 PM

it looks like an rpm/rpmbuild package may have updated

B

bsherman•1/17/25, 4:55 PM

so that check is failing

M

M2•1/17/25, 4:55 PM

https://github.com/ublue-os/akmods/actions/runs/12820186855/job/35749318169#step:12:2612

GitHub

ublue akmods 41 · ublue-os/akmods@699f1fe

A caching layer for pre-built Fedora akmod RPMs. Contribute to ublue-os/akmods development by creating an account on GitHub.

B

bsherman•1/17/25, 4:56 PM

because zfs, nvidia, common, AND extra

they need a common factor

M

M2•1/17/25, 4:56 PM

rpmrebuild would make sense as a common factor

B

bsherman•1/17/25, 4:56 PM

exactly

M

M2•1/17/25, 4:57 PM

https://github.com/ublue-os/akmods/actions/runs/12820186855/job/35749318341#step:12:2857

GitHub

ublue akmods 41 · ublue-os/akmods@699f1fe

A caching layer for pre-built Fedora akmod RPMs. Contribute to ublue-os/akmods development by creating an account on GitHub.

M

M2•1/17/25, 4:57 PM

Same on extra

M

M2•1/17/25, 4:59 PM

https://packages.fedoraproject.org/pkgs/rpmrebuild/rpmrebuild/

rpmrebuild - Fedora Packages

View rpmrebuild in the Fedora package repositories. rpmrebuild: A tool to build rpm file from rpm database

M

M2•1/17/25, 4:59 PM

Looks like recent activity and weirdly F40 is ahead of f41

M

M2•1/17/25, 5:00 PM

https://src.fedoraproject.org/rpms/rpmrebuild/c/e195d10dbcb5c220443ffc0e8bc3acbaca1bff5d?branch=rawhide

B

bsherman•1/17/25, 5:00 PM

well, on the 15th, F40 built

B

bsherman•1/17/25, 5:00 PM

so, i suspect F40 got the updated package a day later

M

M2•1/17/25, 5:01 PM

Update to 2.20 was pushed 10 days ago and packages are leaving testing now....

B

bsherman•1/18/25, 4:16 AM

i'm back to looking at this

B

bsherman•1/18/25, 5:17 AM

ok, so rpmrebuild's source is here: https://sourceforge.net/p/rpmrebuild/git/ci/master/tree/

B

bsherman•1/18/25, 5:17 AM

given the changelog, it seems that fedora was last on a 2.17 build, but is now on 2.20
https://src.fedoraproject.org/rpms/rpmrebuild/blob/rawhide/f/rpmrebuild.spec

B

bsherman•1/18/25, 5:17 AM

so... i did a cloned the repo and did a git diff between the tags

B

bsherman•1/18/25, 5:18 AM

$ git diff rpmrebuild-2.17 rpmrebuild-2.20

$ git diff rpmrebuild-2.17 rpmrebuild-2.20

$ git diff rpmrebuild-2.17 rpmrebuild-2.20

$ git diff rpmrebuild-2.17 rpmrebuild-2.20

B

bsherman•1/18/25, 5:18 AM

i found this very interesting section

B

bsherman•1/18/25, 5:18 AM

diff --git a/src/rpmrebuild.sh b/src/rpmrebuild.sh
index db82ffd..40fc816 100755
--- a/src/rpmrebuild.sh
+++ b/src/rpmrebuild.sh
@@ -93,7 +93,12 @@ function IsPackageInstalled
        Debug '(IsPackageInstalled)'
        # test if package exists
        local output
-       output=$( rpm --query "${RPMREBUILD_PAQUET}" 2>&1 ) # Don't return here - use output
+       local paquet
+       # because the command 'rpm -q foo.1-1.noarch.rpm' return 0
+       # but 'rpm -q foo.1-1.noarch' return 1
+       # in general rpm file ends with .rpm
+       paquet=$( echo ${RPMREBUILD_PAQUET} | sed 's/\.rpm//' )
+       output=$( rpm --query "${paquet}" 2>&1 ) # Don't return here - use output
        if [ "$?" -eq 1 ]
        then

diff --git a/src/rpmrebuild.sh b/src/rpmrebuild.sh
index db82ffd..40fc816 100755
--- a/src/rpmrebuild.sh
+++ b/src/rpmrebuild.sh
@@ -93,7 +93,12 @@ function IsPackageInstalled
        Debug '(IsPackageInstalled)'
        # test if package exists
        local output
-       output=$( rpm --query "${RPMREBUILD_PAQUET}" 2>&1 ) # Don't return here - use output
+       local paquet
+       # because the command 'rpm -q foo.1-1.noarch.rpm' return 0
+       # but 'rpm -q foo.1-1.noarch' return 1
+       # in general rpm file ends with .rpm
+       paquet=$( echo ${RPMREBUILD_PAQUET} | sed 's/\.rpm//' )
+       output=$( rpm --query "${paquet}" 2>&1 ) # Don't return here - use output
        if [ "$?" -eq 1 ]
        then

diff --git a/src/rpmrebuild.sh b/src/rpmrebuild.sh
index db82ffd..40fc816 100755
--- a/src/rpmrebuild.sh
+++ b/src/rpmrebuild.sh
@@ -93,7 +93,12 @@ function IsPackageInstalled
        Debug '(IsPackageInstalled)'
        # test if package exists
        local output
-       output=$( rpm --query "${RPMREBUILD_PAQUET}" 2>&1 ) # Don't return here - use output
+       local paquet
+       # because the command 'rpm -q foo.1-1.noarch.rpm' return 0
+       # but 'rpm -q foo.1-1.noarch' return 1
+       # in general rpm file ends with .rpm
+       paquet=$( echo ${RPMREBUILD_PAQUET} | sed 's/\.rpm//' )
+       output=$( rpm --query "${paquet}" 2>&1 ) # Don't return here - use output
        if [ "$?" -eq 1 ]
        then

diff --git a/src/rpmrebuild.sh b/src/rpmrebuild.sh
index db82ffd..40fc816 100755
--- a/src/rpmrebuild.sh
+++ b/src/rpmrebuild.sh
@@ -93,7 +93,12 @@ function IsPackageInstalled
        Debug '(IsPackageInstalled)'
        # test if package exists
        local output
-       output=$( rpm --query "${RPMREBUILD_PAQUET}" 2>&1 ) # Don't return here - use output
+       local paquet
+       # because the command 'rpm -q foo.1-1.noarch.rpm' return 0
+       # but 'rpm -q foo.1-1.noarch' return 1
+       # in general rpm file ends with .rpm
+       paquet=$( echo ${RPMREBUILD_PAQUET} | sed 's/\.rpm//' )
+       output=$( rpm --query "${paquet}" 2>&1 ) # Don't return here - use output
        if [ "$?" -eq 1 ]
        then

B

bsherman•1/18/25, 5:19 AM

some tinkering shows me this would probably change the resulting

$output

$output

$output

$output variable from
2.17:

output=kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64

output=kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64

output=kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64

output=kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64
and 2.20:

output=package /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64 is not installed

output=package /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64 is not installed

output=package /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64 is not installed

output=package /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64 is not installed

B

bsherman•1/18/25, 5:20 AM

and... our error message from the CI build is...

/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (IsPackageInstalled) /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64.rpm package is not installed

/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (IsPackageInstalled) /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64.rpm package is not installed

/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (IsPackageInstalled) /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64.rpm package is not installed

/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (IsPackageInstalled) /var/cache/akmods/framework-laptop/kmod-framework-laptop-6.12.9-200.fc41.x86_64-0.0.git.172.3f9ba585-1.fc41.x86_64.rpm package is not installed

B

bsherman•1/18/25, 5:20 AM

so

B

bsherman•1/18/25, 5:20 AM

i think we change our

dual-sign.sh

dual-sign.sh

dual-sign.sh

dual-sign.sh script which calls

rpmrebuild

rpmrebuild

rpmrebuild

rpmrebuild to use local path, not fully qualified path... testing that now

M

M2•1/18/25, 5:56 AM

changing the find to include

-printf "%f\n"

-printf "%f\n"

-printf "%f\n"

-printf "%f\n" will give us only the file name.

M

M2•1/18/25, 5:56 AM

also not sure when we strip the kernel info

M

M2•1/18/25, 5:58 AM

well, that got passed the install point... but new errors now

B

bsherman•1/18/25, 6:01 AM

ok, i think i have the fix

M

M2•1/18/25, 6:05 AM

I'll be up for a little longer if you put the pr in.

B

bsherman•1/18/25, 6:07 AM

k

B

bsherman•1/18/25, 6:07 AM

running local tests

B

bsherman•1/18/25, 6:08 AM

i couldn't keep going on this during morning... had "day job" stuff to do

B

bsherman•1/18/25, 6:08 AM

but glad i got back to it, my hope was to run builds in bespoke container (not in podman build) so i could inspect the rpmrebuild script and tinker

B

bsherman•1/18/25, 6:09 AM

paid off

B

bsherman•1/18/25, 6:09 AM

local common succeeded, testing zfs

B

bsherman•1/18/25, 6:09 AM

since it has a different dual-sign-zfs.sh script

B

bsherman•1/18/25, 6:14 AM

zfs not working yet, but i'll push the other fix just to test builds

B

bsherman•1/18/25, 6:17 AM

https://github.com/ublue-os/akmods/pull/292

M

M2•1/18/25, 6:24 AM

Common got through.

I

inffy•1/18/25, 6:30 AM

looks good

MM2 Common got through.

B

bsherman•1/18/25, 6:30 AM

i expect everything but ZFS to succeed

MM2 Common got through.

B

bsherman•1/18/25, 6:51 AM

local ZFS build success!

https://github.com/ublue-os/akmods/pull/292 updated with fix

M

M2•1/18/25, 6:52 AM

Like a bOS

B

bsherman•1/18/25, 6:54 AM

we want to rebuild the world with this or wait for tomorrow night?

akmod build failures 2025-01, 15-16

Similar Threads

Similar Threads

Similar Threads