T
TanStack•7mo ago
sensitive-blue

flaky e2e tests?

question: is it only my - or the e2e tests are flaky? Here I've got 2 test runs: - https://cloud.nx.app/runs/C77Xm9I0P5 (2 suites fail) - https://cloud.nx.app/runs/ZXbYPUgPAK (1 suite fail) but there was literally no code change...
7 Replies
flat-fuchsia
flat-fuchsia•7mo ago
yes some e2e tests are unfortunately not that stable any help there is much appreciated
sensitive-blue
sensitive-blueOP•7mo ago
got it! right now I'm fighting to get through this: 
Running 14 tests using 1 worker
(node:1808) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Mapped "tanstack-start-e2e-server-functions" to port 13056
  1) [chromium] › tests/server-functions.spec.ts:6:1 › invoking a server function with custom response status code 

    Test timeout of 30000ms exceeded.
Running 14 tests using 1 worker
(node:1808) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Mapped "tanstack-start-e2e-server-functions" to port 13056
  1) [chromium] › tests/server-functions.spec.ts:6:1 › invoking a server function with custom response status code 

    Test timeout of 30000ms exceeded.
by any chance, do you know what's going on with this one? @Manuel Schiller (nx run tanstack-start-e2e-server-functions:test:e2e)
flat-fuchsia
flat-fuchsia•7mo ago
have a look at the test impl. it uses playwright's response event to parse that I guess we need to set up the request listener before the actual click let me quickly do this
flat-fuchsia
flat-fuchsia•7mo ago
sensitive-blue
sensitive-blueOP•7mo ago
wow, that was fast ❤️
sensitive-blue
sensitive-blueOP•7mo ago
thanks @Manuel Schiller, I'll try to redo my https://github.com/TanStack/router/pull/3526 after your PR gets merged
GitHub
preload type fix (naive type change) by ducin · Pull Request #3526 ...
This PR is meant to bring the preload options to reflect the possible values listed in both defaultPreload (below) and the docs (https://tanstack.com/router/v1/docs/framework/react/guide/preloading...
flat-fuchsia
flat-fuchsia•7mo ago
merged

Did you find this page helpful?