2 replies

Stripe: `onSubscriptionUpdate` passes old subscription data

When the

onSubscriptionUpdate

onSubscriptionUpdate

callback is fired, it passes the

subscription

subscription

data grabbed from the DB. However, this is the data before the updated properties are applied.

For example, if a user switches from one plan to another, the passed

subscription

subscription

object contains the old plan, not the new one.

Relevant code:
1. Subscription is fetched from DB: https://github.com/better-auth/better-auth/blob/main/packages/stripe/src/hooks.ts#L100-L125
2. Subscription is updated in DB: https://github.com/better-auth/better-auth/blob/main/packages/stripe/src/hooks.ts#L128-L151
3. Old subscription (from step 1) is passed to callback: https://github.com/better-auth/better-auth/blob/main/packages/stripe/src/hooks.ts#L165-L168

This behavior can be seen by simply logging the subscription object from the callback:

// within betterAuth.plugins.stripe.subscription
{
  onSubscriptionUpdate: async ({ event, subscription }) => {
    // Observe how 'subscription' logs the old/previous subscription data, not the updated data:
    console.log(subscription);
  }
}

// within betterAuth.plugins.stripe.subscription
{
  onSubscriptionUpdate: async ({ event, subscription }) => {
    // Observe how 'subscription' logs the old/previous subscription data, not the updated data:
    console.log(subscription);
  }
}

My opinion is that it would be helpful if the callback included both the old subscription and the newly updated one, but I believe it should at last pass the new one.

Better Auth•11mo ago•

2 replies

sleitnick

Stripe: `onSubscriptionUpdate` passes old subscription data

When the

onSubscriptionUpdate

onSubscriptionUpdate

callback is fired, it passes the

subscription

subscription

data grabbed from the DB. However, this is the data before the updated properties are applied.

For example, if a user switches from one plan to another, the passed

subscription

subscription

// within betterAuth.plugins.stripe.subscription
{
  onSubscriptionUpdate: async ({ event, subscription }) => {
    // Observe how 'subscription' logs the old/previous subscription data, not the updated data:
    console.log(subscription);
  }
}

// within betterAuth.plugins.stripe.subscription
{
  onSubscriptionUpdate: async ({ event, subscription }) => {
    // Observe how 'subscription' logs the old/previous subscription data, not the updated data:
    console.log(subscription);
  }
}

My opinion is that it would be helpful if the callback included both the old subscription and the newly updated one, but I believe it should at last pass the new one.

Stripe: `onSubscriptionUpdate` passes old subscription data

Similar Threads

Stripe: `onSubscriptionUpdate` passes old subscription data

Similar Threads

Similar Threads

Similar Threads