8 Replies
Nice looking good! Couple notes:
- there is a standard-ish filetree icon that would be better to use for expanding
- tons of space being taken up by the left hand side
- animations are nice but not needed (gh doesnt have them), depends on code complexity we may not need. Same with expandable/collaspable logic. It’s nice but not worth code complexity if its a lot unless we’re nailing the base experience
- style doesnt seem very shadcn, slightly low density. Will need to see with more content/directories. left side selected border had a bit of a strange border (rounding). Does shadcn have a reference? If not can we generate with v0 to see what shadcn file tree might look like?
- the icon button needs to be inside the code header, this implementation has a ton of dead/white space on the side. The sidebar should go to 0 width/not visible, the icon should bring it out, the min width should not be 50px or whatever
Example shadcn file tree
GitHub
GitHub - MrLightful/shadcn-tree-view: A Shadcn UI component for hie...
A Shadcn UI component for hierarchical lists of data with nested levels that can be expanded and collapsed. - MrLightful/shadcn-tree-view
:thisisfine:
Without the blue circle, this is the standardish icon
should i directly use that?
Sure
done