Hey, can somebody test or use pr
Hey, can somebody test or use pr deployment of this pr or review if anything is missing? Since it's a big refactor I don't want any breaking in prod? Thanks
- https://github.com/tscircuit/tscircuit.com/pull/1149
20 Replies
found some debug text
seems pretty good otherwise
Ugh, yeah some console logs and h1 tags are there, ignore em, would fix in final commit, also your one un-outdated review is there for format function, that is also noted for last commit, anything else feels off? So I won't waste time fixing reviews after each commit
Because not logged in
i can't save, but yea feels pretty good i'd say
oh ok
yea i wish we could test on preview
(with login)
it looks pretty good to me, the refactor is really good
🥶 we can create 2 deployments one with fake snippets and other with registry api, but that would be expensive ig
at some point i'll also show how to test hooks comprehensively, but it's a bit of a PITA
we could totally do that and wouldn't be expensive
it's just complicated to set up
🧐 I'll try it, currently would try todo contribution tracker, it's preety annoying
@DOPΣ
Can you give sidebar ss? Files
Why are we being able to create a file without any name? just .tsx extension
It's allowed in vscode also, as per I asked todo
Ok last thing, can you open index.tsx in codeeditor and run and send ss?
The delete dropdown not consistent, goes to the top!!
Ugh yes, that is known, can you do suggested in above message?
Thanks
Oh yup, it's working as expected, probably need to do something with empty naming of files
Thanks for reporting 😁
Small UI issue, the error should vanish after I reopen the sidebar again. The UI should be a bit more polished and these subtle things matter
Ugh you did the whole autopsy, nvm, I'll fix, thanks
We can't really test saving of PKG files with pr deployment, so oooooo