31 replies

`change manage_relationship(...type: :remove)` not working

I have a

many_to_many

many_to_many

relationship between

Organization

Organization

and

SubscriptionPlan

SubscriptionPlan

. The

Organization

Organization

has the following two actions:

    update :subscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :append)
    end

    update :unsubscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :remove)
    end

    update :subscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :append)
    end

    update :unsubscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :remove)
    end

The

:subscribe

:subscribe

action seems to work fine. But the

:unsubscribe

:unsubscribe

action fails with the following

:invalid

:invalid

error:

[%Ash.Error.Changes.InvalidRelationship{relationship: :subscription_plans, message: "changes would create a new related record", splode: Ash.Error, bread_crumbs: ["Error returned from: MyApp.Accounts.Organization.unsubscribe"]

[%Ash.Error.Changes.InvalidRelationship{relationship: :subscription_plans, message: "changes would create a new related record", splode: Ash.Error, bread_crumbs: ["Error returned from: MyApp.Accounts.Organization.unsubscribe"]

I'm a little baffled by this one. Also, if I change the

manage_relationship

manage_relationship

options from

type: :remove

type: :remove

to the following:

[
  on_no_match: :ignore,
  on_match: :unrelate,
  on_missing: :ignore
]

[
  on_no_match: :ignore,
  on_match: :unrelate,
  on_missing: :ignore
]

(this basically just changes
on_no_match
on_no_match
from
:error
:error
to
:ignore
:ignore
)

... my test also fails. It seems to remove the subscription from the

Organization

Organization

but not the

SubscriptionPlan

SubscriptionPlan

plan = plan |> Ash.load!([:subscribers], actor: user) |> dbg
assert plan.subscribers |> length == 0

plan = plan |> Ash.load!([:subscribers], actor: user) |> dbg
assert plan.subscribers |> length == 0

Not sure what I'm doing wrong here

Solution

So the mistake I was making was in my

accessing_through

accessing_through

policy:

    policy accessing_from(MyApp.Accounts.Organization, :subscribers) do
      authorize_if always()
    end

    policy accessing_from(MyApp.Accounts.Organization, :subscribers) do
      authorize_if always()
    end

I thought that second parameter was supposed to refer to the relationship defined on the resource that was defining the policy, but it's actually the relationship defined on the resource being referenced in the policy.

Jump to solution

`change manage_relationship(...type: :remove)` not working

I have a

many_to_many

many_to_many

relationship between

Organization

Organization

and

SubscriptionPlan

SubscriptionPlan

. The

Organization

Organization

has the following two actions:

    update :subscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :append)
    end

    update :unsubscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :remove)
    end

    update :subscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :append)
    end

    update :unsubscribe do
      argument :plan, :struct, constraints: [instance_of: SubscriptionPlan]
      accept []
      require_atomic? false
      change manage_relationship(:plan, :subscription_plans, type: :remove)
    end

The

:subscribe

:subscribe

action seems to work fine. But the

:unsubscribe

:unsubscribe

action fails with the following

:invalid

:invalid

error:

[%Ash.Error.Changes.InvalidRelationship{relationship: :subscription_plans, message: "changes would create a new related record", splode: Ash.Error, bread_crumbs: ["Error returned from: MyApp.Accounts.Organization.unsubscribe"]

[%Ash.Error.Changes.InvalidRelationship{relationship: :subscription_plans, message: "changes would create a new related record", splode: Ash.Error, bread_crumbs: ["Error returned from: MyApp.Accounts.Organization.unsubscribe"]

I'm a little baffled by this one. Also, if I change the

manage_relationship

manage_relationship

options from

type: :remove

type: :remove

to the following:

[
  on_no_match: :ignore,
  on_match: :unrelate,
  on_missing: :ignore
]

[
  on_no_match: :ignore,
  on_match: :unrelate,
  on_missing: :ignore
]

(this basically just changes
on_no_match
on_no_match
from
:error
:error
to
:ignore
:ignore
)

... my test also fails. It seems to remove the subscription from the

Organization

Organization

but not the

SubscriptionPlan

SubscriptionPlan

plan = plan |> Ash.load!([:subscribers], actor: user) |> dbg
assert plan.subscribers |> length == 0

plan = plan |> Ash.load!([:subscribers], actor: user) |> dbg
assert plan.subscribers |> length == 0

Not sure what I'm doing wrong here

Solution

So the mistake I was making was in my

accessing_through

accessing_through

policy:

    policy accessing_from(MyApp.Accounts.Organization, :subscribers) do
      authorize_if always()
    end

    policy accessing_from(MyApp.Accounts.Organization, :subscribers) do
      authorize_if always()
    end

Jump to solution

`change manage_relationship(...type: :remove)` not working

`change manage_relationship(...type: :remove)` not working

Similar Threads

Similar Threads

Similar Threads