Seeking Feedback on First Attempt with Effect Library

Hi everyone, just getting started with Effect today and tried converting some things into Effects and I've got some questions / maybe someone with experience give feedback on my first try.