Possible regression on actions with upserts on custom identity and embedded unions

Hi, I have a resource action that used to work until recently (on Ash 3.4.58), but now errors out (on Ash 3.5.21 and 3.5.23). Could this be a regression or did I miss something about it in patch notes? I'm not exactly sure how to proceed because it seems to be expecting an identity it really shouldn't be.
Solution:
@czen can you try main of ash?
Jump to solution
13 Replies
sevenseacat
sevenseacat•4mo ago
what's the error you receive? oh its futher down
chinponya
chinponyaOP•4mo ago
yeah, sorry, I couldn't fit it all within discord message limits, hence attachments
ZachDaniel
ZachDaniel•4mo ago
upsert_identity :product_id_platform
upsert_identity :product_id_platform
oh, hmm... Yeah thats weird...
chinponya
chinponyaOP•4mo ago
on second look this custom identity doesn't seem to matter, as even specifying :id has the same result upsert? true with no identity is fine, somehow
ZachDaniel
ZachDaniel•4mo ago
Yeah, somehow the context is making its way into the embedded changes It may be a bug in the new shared context code Yes, it is
Solution
ZachDaniel
ZachDaniel•4mo ago
@czen can you try main of ash?
chinponya
chinponyaOP•4mo ago
it's exactly the same with identical stacktrace
ZachDaniel
ZachDaniel•4mo ago
🤔 really? wild What sha is in your lockfile?
chinponya
chinponyaOP•4mo ago
"ash": {:git, "https://github.com/ash-project/ash.git", "a01fc7ad466d29c9ac6781968cfd75d132c8ff0a", [ref: "a01fc7ad466d29c9ac6781968cfd75d132c8ff0a"]}, locally it's the right one I purged the build dir just in case well the one difference in stack trace is the version changing from 3.5.21 to 3.5.23, so it definitely did update
ZachDaniel
ZachDaniel•4mo ago
Alrighty then ah, okay I found it missed a case
chinponya
chinponyaOP•4mo ago
I was wondering why I couldn't log inside these changed branches only to realize it's inside a macro
ZachDaniel
ZachDaniel•4mo ago
Okay try again
chinponya
chinponyaOP•4mo ago
now it seems to work thank you

Did you find this page helpful?