@Abse do you know what is this prop
@Abse do you know what is this prop
showSilkscreenPinLabels?24 Replies
Shouldnt it be hideSilkscreenPinLabels? As showing them is the default?
idk its already there in many common components ig
I checked its only available for pinheader component
yea probably should be
hideSilkscreenPinLabels@Seve
@Seve so the prop should be the same asa earlier?
And the pinlabels should be hidden by default?
yea i think so, that's how other software does it
@Seve i think a lot of boards will have to be updated after this gets merged
your PR is good but make sure to update the tests, a lot of them should have to appropriate prop so that the pin labels are visible
@Seve
showSilkscreenPinlabels prop is only available for pinheader. I just noticed that pinrow is being used in chip, jumper etc in core. So should i update the props to include it?yea that sounds right
@Mustafa7 i'm looking at this a bit more
if the user is specifying that the footprint has a particular silkscreen, we should show the silkscreen even if they don't specify this prop. This prop controls what happens if they don't specify a footprint
so it doesn't go on
chipOnly pinrow footprint shows pinlabels right?
if the user specifies a footprint, this prop doesn't effect anything
it's only when we generate a footprint from props that this comes into effect
only for this function
@Seve
@Mustafa7 no that's wrong
getImpliedFootprintString should just return _hidesilkscreenpinlabels on the pinrow. There may be a footprinter issue (does it not let you disable pin labels)@Seve
@Seve this as well was a 1 star?🥲
@Seve merge pls