Suggestion to Rename `Order.combineAll` for Clarity

Thoughts on renaming (or adding an alias) for

Order.combineAll

Order.combineAll

Order.combineAll

Order.combineAll? I've been introducing folks at my company to Effect, and this one small thing has mildly confused everyone.

I wrote it out like this in a slide deck. Everyone understands the concept, but trips up on the

combineAll

combineAll

combineAll

combineAll name

const ItemOrder = Order.combineAll([
    // first order by name A->Z
    orderByProp("name", Order.string),
    // break ties, sorting by cost high->low
    orderByProp("cost", Order.reverse(Order.number)),
    // ..etc
]);

const ItemOrder = Order.combineAll([
    // first order by name A->Z
    orderByProp("name", Order.string),
    // break ties, sorting by cost high->low
    orderByProp("cost", Order.reverse(Order.number)),
    // ..etc
]);

const ItemOrder = Order.combineAll([
    // first order by name A->Z
    orderByProp("name", Order.string),
    // break ties, sorting by cost high->low
    orderByProp("cost", Order.reverse(Order.number)),
    // ..etc
]);

const ItemOrder = Order.combineAll([
    // first order by name A->Z
    orderByProp("name", Order.string),
    // break ties, sorting by cost high->low
    orderByProp("cost", Order.reverse(Order.number)),
    // ..etc
]);

Sure, it's "combining" multiple orders into a single order, but maybe something like

Order.lexical()

Order.lexical()

Order.lexical()

Order.lexical() or

lexically()

lexically()

lexically()

lexically() or

Order.oneByOne

Order.oneByOne

Order.oneByOne

Order.oneByOne or something would make it more intuitive

No replies yetBe the first to reply to this messageJoin

Suggestion to Rename `Order.combineAll` for Clarity

Similar Threads

Similar Threads

Similar Threads