Effect CommunityEC
Effect Community•5mo ago
nkxxll

Question about setCookie function's default options in Effect Platform library's HttpServer API

sorry to jump this on you guys... i am implementing a server with the httpserver api from effect/platform I wanted to set a cookie in the response of my server. Is there are reason the setCookie function takes options but the options are all set to undefined and the default is not working out of the box with common browser implementations? some code for reference: (signature)
/**
 * @since 1.0.0
 * @category combinators
 */
export const setCookie: {
  /**
   * @since 1.0.0
   * @category combinators
   */
  (name: string, value: string, options?: Cookie["options"]): (
    self: HttpServerResponse
  ) => Effect.Effect<
    HttpServerResponse,
    CookiesError
  >
  /**
   * @since 1.0.0
   * @category combinators
   */
  (
    self: HttpServerResponse,
    name: string,
    value: string,
    options?: Cookie["options"]
  ): Effect.Effect<
    HttpServerResponse,
    CookiesError
  >

and this basically sets no options at all. If there is no particular reason for that i would like to make a pr with sane default values so that you can use the function without defining your own options out of the box with the most common browsers 😄
Was this page helpful?