C#•4mo ago

Is writing tests like this worth it

Im using the implementations and sqlite in memory to test that the services do what they are supposed to - i guess they fall into integrations test or unit tests but i want your lots opinion https://github.com/UmbrellaCrow612/PoliceCaseManagement/blob/master/tests/Identity.Application.Tests/AuthServiceTests.cs

GitHub

PoliceCaseManagement/tests/Identity.Application.Tests/AuthServiceTe...

Police case System Side project. Contribute to UmbrellaCrow612/PoliceCaseManagement development by creating an account on GitHub.

Trinitek•8/23/25, 10:46 AM

yes, these look comparable to integration tests I would write

Trinitek•8/23/25, 10:49 AM

so for a login flow like this, I would consider having a test suite like this that arranges and asserts everything up-front, and then I would also write a second test suite that covers the same interaction, except over WebApplicationFactory + HttpClient

Trinitek•8/23/25, 10:50 AM

doing it that way allows me to validate that all of the other stuff in my Startup.cs is being registered and configured correctly, including filters and anything else that possibly touches the response pipeline

Trinitek•8/23/25, 10:53 AM

one thing I would like to see here however is some use of MultipleAsserts. I don't think MSTest provides that, but I know NUnit does, and also possibly XUnit

Trinitek•8/23/25, 10:54 AM

using MultipleAsserts will allow you to do Assert on multiple things, and all the pass/fails are reported together, rather than failing on the first bad Assert

Trinitek•8/23/25, 10:55 AM

see https://docs.nunit.org/articles/nunit/writing-tests/assertions/multiple-asserts.html

Trinitek•8/23/25, 11:02 AM

also for LogoutAsync_ShouldRevokeAllValidTokensForUserLogoutAsync_ShouldRevokeAllValidTokensForUser I would like to see a case that asserts that the user is not able to interact with the account with a revoked token

Trinitek•8/23/25, 11:10 AM

https://github.com/UmbrellaCrow612/PoliceCaseManagement/blob/7588ac2308927bd4563bb8059b735052af2b7f66/tests/Identity.Application.Tests/AuthServiceTests.cs#L290 I'm kinda iffy on asserting directly against what's supposed to be in the database. I might consider having some _authService.HasAnyTokens(user.Id)_authService.HasAnyTokens(user.Id) and asserting against that instead.

TTrinitek also for `LogoutAsync_ShouldRevokeAllValidTokensForUser` I would like to see a c...

Trinitek•8/23/25, 11:12 AM

but the actually interesting side-effect of that is that the user shouldn't be able to log in with a revoked token, hence

TTrinitek but the actually interesting side-effect of that is that the user shouldn't be a...

mellondkingOP•8/23/25, 12:38 PM

Thanks for feedback

Is writing tests like this worth it

Similar Threads

Similar Threads

Similar Threads