T
tscircuit•2mo ago
shibo

how does calculate-elbow work?

how does calculate-elbow work?
No description
No description
15 Replies
shibo
shiboOP•2mo ago
@Seve does it pick one elbow for each case? as these elbows cross other components they are invalid, but calculate-elbow doesn't account for obstacles
Seve
Seve•2mo ago
Calculate elbow is used to generate a base path, variants are then generated that moved the segments to guidelines to avoid obstacles (recently broken)
shibo
shiboOP•2mo ago
are variants generated in calculate-elbow? I don't see logic related to obstacles in that repo
Seve
Seve•2mo ago
no the function is inside the schematic-trace-solver, i think it's called generateElbowVariants, it is definitely broken i have a video somewhere where i show that it histoically worked
Seve
Seve•2mo ago
shibo
shiboOP•4w ago
Seve
Seve•4w ago
Hmm thats not good Idk i weote that error because it was hard to repro If you have a repro submit it!
shibo
shiboOP•4w ago
submit it to core?
shibo
shiboOP•4w ago
so close
No description
Seve
Seve•4w ago
Yep yep Gl! Btw i think the core implementation is missing there lol flatten-js can be used for the calculation of the pour polygon, we will probably want to create a repo just to handle the pour calculation because its somewhat complex
shibo
shiboOP•4w ago
yeah XD
shibo
shiboOP•4w ago
GitHub
Add cadModel.gltfUrl support · Issue #758 · tscircuit/tscircuit
add in tscircuit/props add in tscircuit/circuit-json implement in tscircuit/core implement model loader in tscircuit/3d-viewer You must be assigned this task. /bounty $150
Seve
Seve•4w ago
Yea you can assign
shibo
shiboOP•4w ago
same board in core passed
Seve
Seve•4w ago
🤬 Yea super tough to repro that condition

Did you find this page helpful?