Seve - The width of the search changes every ti...
The width of the search changes every time you type
CC @AyushJ
30 Replies
Okay sure I will send a patch asap
@Seve i tried to kept the width changes minimal, changed only where needed. pls check
https://github.com/tscircuit/runframe/pull/1184
is this fine?
i think we need a bigger default width, there's still too much jitter
99% of the time there should not be jitter
also can we get rid of all this white space
just set a higher default width, don't allow width to change, and use overflow:ellipsis on the directory names
@Seve tried for 99.9% no jitter
ah ok nicely done
yes this is good
we should ship it
unrelated but is there a hotkey to open that menu? Could be a good idea, CC @DOPΣ
okay commited/pushed👍🏻
nice work
hopefully all these PRs get you some AI sponsorship 😁
idk trying my best hehe😁
could have got this if we created issue for it though 🙂
hehe
@Seve @shibo @Rishabh Can you please review this for https://github.com/tscircuit/schematic-viewer/issues/132
https://github.com/tscircuit/schematic-viewer/pull/138
@Seve
the hovering is jank
i'm super close to just closing this issue b/c everyone submits jank hovering
yea i'm gonna close it
Can we still try to fix the issue or it's completely closed @Seve
i don't think anyone is going to get it
so it's not worth it
requires understanding how to create overlays for mouse tracking
GitHub
Add hover bounding boxes and mouse tracker for schematic components...
Summary
add a MouseTracker context and useMouseEventsOverBoundingBox hook for registering bounding boxes
introduce a SchematicComponentMouseTarget overlay that highlights components and reports cl...
okay nice...also one small point might need cursor pointer?
yea it does
there's a lot of issues, the glow etc
but nobody was going to get the mouse tracker properly
so at least now the rest of it is easy
okay cool let me see if i could help with that chore 🙂
yea a couple things: cursor, the glow (no glow), and no border radius
but i didn't bother to fix those because it was bountiless, if there's not a claim incremental merges are possible
for hover pointer i added a new prop onHoverChange to SchematicComponentMouseTarget so that it detect hover state changes to the parent.
Idk if that makes sense, the hovering was already working, why did you need a new prop?
i think when I was adding the hover pointer, it was being registered on the entire page. I assumed it wasn’t detecting it on a component level, so I added it that way. Let me see if i can find a better way to do this.
Yea thats probably correct
Or on the entire element etc
Seve i tried pure CSS, but that only worked when hovering right on the SVG, not the empty space in the hover box. Then I tested making the hover outline clickable, but that messed up dragging. I also looked at using a global hover tracker, but it felt way too complicated... so i finally settled on a simple onHoverChange prop as it tell the parent keeps track of hovered components, updates a boolean, and plugs it into the existing cursor logic. It’s clean, React-style, no regressions imo, and works everywhere in the hover area.