shibo - playwright tests failing and I get this...
playwright tests failing and I get this error in the fake-server:
26 Replies
@Seve any idea what's going on?
*most playwright tests
Hmm ive never seen this cc @DOPΣ , not sure what this is about
yeah ,its logging in generated-index.js
know a fix?
stop logging in catch blocks, in generatedindex js
ig
that file sucks and should be broken up
it's literally the worst anti patterns ever
I guess it has nothing to do with my playwright tests failing, btw I just pulled main; no changes made
throws errors for control logic
its js lol
yea worth investigating if it breaks CI fwiw
@Seve why does everything appear to be failing but it says they all passed?

can you please run and check on your machine?
hmm maybe check what CI says?
is the issue just that the text is red?
ok above that it says 32 failed

I'll investigate further
yea that could be quite serious- the best thing to check is what CI says for the logs
i haven't thought about playwright tests in a while 😬
do playwright tests worth it?
it's usually good to have a "smoke test" to make sure that a major user flow isn't broken
looks like they aren't running on ci
e.g. signing up, going to the editor page and hitting run
prob been broken for a while
welp
yea i think there were some bad ones in there that are old and flaky
it was driving me mad lol
haha yea it sucks
I thought it was an issue on my machine, I guess it's a win since now I have more experience with what to debug first
comparing what works(supposedly) with what doesn't