night199uk - hey, folks. just brought a few old...
hey, folks. just brought a few older PRs I had opened up to date.
the end goal of these is to add support for Raymarine Autopilot "Route-Tracking" mode:
i.e. program a route in Freeboard SK (or import one from other route sources), and have the Raymarine follow the route waypoint by waypoint.
They were outstanding for a while until canboat added the relevant PGNs and did a release, but that was done a while ago.
Wondered if I could request a review on these please? 🙂
https://github.com/SignalK/signalk-to-nmea2000/pull/120
https://github.com/SignalK/signalk-to-nmea2000/pull/135
https://github.com/SignalK/signalk-to-nmea2000/pull/134
https://github.com/SignalK/signalk-to-nmea2000/pull/117
8 Replies
@Teppo Kurki @Scott Bender @AdrianP hey, sorry to tag. wondering how to get these reviewed, i would love to land them this time 🙂
@Scott Bender where are we with https://github.com/SignalK/signalk-to-nmea2000/pull/128 ? there's going to be a bit of extra work either way
It’s close, But I don’t feel comfortable releasing it yet.
I will back port any new changes to master.
i don't have much to say about the raymarine stuff
I’ll take a look…
@Teppo Kurki are you ok with https://github.com/SignalK/signalk-to-nmea2000/pull/120
GitHub
Allow timer conversions to specify keys by night199uk · Pull Reque...
This simplifies unit testing of timer conversions that require data keys by allowing the unit tests to pass them into the callback.
@night199uk can you resolve the conflicts in https://github.com/SignalK/signalk-to-nmea2000/pull/121 ?
GitHub
Implement PGN129285 - Route/WP Information by night199uk · Pull Re...
Requires #120 to land before merging. I'm working to test this here.
I thought I had! let me check.
@Scott Bender done!
thanks for merging all the others! PGN130918 & 130848 will get the "track" button to work on your raymarine autopilot if you have an active route in freeboard SK!
try it out and let me know.
https://github.com/SignalK/signalk-to-nmea2000/pull/121
@Scott Bender polite nudge on this one - is there anything else for me to do please?