1 reply

Suggestion to make `Overrideable` fields key optional for `VariantSchema.Overrideable` in `Model`

Not sure if this is the right channel but posting here since it's used for

Model

Model

: for

VariantSchema.Overrideable

VariantSchema.Overrideable

, would it not make more sense for the Overrideable field to become key optional instead of just value optional? Leaving out the fields already works fine at runtime, but gives a type error. Providing them is unnecessarily verbose (unless I'm missing a usecase) and also leads to annoying situations when testing repositories with a partial match using

const payload: typeof MyModel.Update.type: {}
const updated = yield* ...
// will fail if Overridable fields are explicitly undefined in payload, which is needed for type checking
expect(updated).toMatchObject(payload)

const payload: typeof MyModel.Update.type: {}
const updated = yield* ...
// will fail if Overridable fields are explicitly undefined in payload, which is needed for type checking
expect(updated).toMatchObject(payload)

Effect Community•5mo ago•

1 reply

janglad

Suggestion to make `Overrideable` fields key optional for `VariantSchema.Overrideable` in `Model`

Not sure if this is the right channel but posting here since it's used for

Model

Model

: for

VariantSchema.Overrideable

VariantSchema.Overrideable

const payload: typeof MyModel.Update.type: {}
const updated = yield* ...
// will fail if Overridable fields are explicitly undefined in payload, which is needed for type checking
expect(updated).toMatchObject(payload)

const payload: typeof MyModel.Update.type: {}
const updated = yield* ...
// will fail if Overridable fields are explicitly undefined in payload, which is needed for type checking
expect(updated).toMatchObject(payload)

Suggestion to make `Overrideable` fields key optional for `VariantSchema.Overrideable` in `Model`

Similar Threads

Suggestion to make `Overrideable` fields key optional for `VariantSchema.Overrideable` in `Model`

Similar Threads

Similar Threads

Similar Threads