Ray Kholodovsky - just updated tsci and plated ...
just updated tsci and plated holes are rendered differently, is this intentional? there is no pink center hole shown now.
26 Replies
In which repo this behaviour shown?
Update CLI to latest and look at anything with a plated hole please
There might be the same radius for the inner or outer hole or the inner hole's radius 0???
no, the same files yesterday had the pink circle in the middle showing the drill
let me try to identify the issue
it's not a circuit-to-svg issue, it would be related to the pcb-viewer, @shibo this might be related to that recent layering fix if the drill layer was moved
GitHub
Fix multi-layer visibility issues: inner5,6 not showing and top lay...
@tscircuit_pcb-viewer.Zen.Browser.2025-10-30.21-44-12.mp4
Issue Summary The 8-layer PCB viewer had two critical visibility problems: (1) inner layers 5 and 6 weren't displ...
Issue Summary The 8-layer PCB viewer had two critical visibility problems: (1) inner layers 5 and 6 weren't displ...
i'm 90% sure it's related to this PR
yes hole missing
revert queued, but maybe you could attemtpt to patch https://github.com/tscircuit/pcb-viewer/pull/442
I'll try to patch
issue fixed hopefully, @Seve how long till the new version of pcb-viewer reaches tsci?
not critical, I'll just update tonight or tmrw
also just noticed that PCB outline is not rendering, not sure if related to this or not
I'll see what's going on
thanks. can y'all also add tests for these simple cases please?
this is browser testing so the maintenance cost is currently too high
I see.
the bug doesn't propagate through to the generated image of the PCB ?
correct it's unrelated
I picked the perfect day to work on code that generates the board outline, apparently
the pcb-viewer is up to date in the latest version and i can confirm board outline renders in the preview environment
i'm a bit all over the place though so let me know if maybe i'm misunderstanding
there it is, I had just done bun run update
nice
but wasn't seeing the outline back
but jiggered some things and there it is now
yay