Best way to test something that depends on a ClientWebSocket

In one of our services, we use

ClientWebSocket

ClientWebSocket

to send over some data, however we now need to write integration tests for said services. The current setup basically creates the service from a factory method that reads some config from an environment variable and the scoped service instantiates a new client to connect to said websocket, do the job it's supposed to and dispose thereafter.

I am fairly new to this codebase and thankfully have the freedom to change it if necessary, primarily because the codebase is only a few months old as well

I've never worked with WebSockets like this either so any extra feedback on how to improve this code would be great

The initialization is as follows:

    private MyService(string serverUrl)
    {
        _serverUri = new Uri(serverUrl);
        _webSocket = new ClientWebSocket();
        _cts = new CancellationTokenSource();
    }

    private MyService(string serverUrl)
    {
        _serverUri = new Uri(serverUrl);
        _webSocket = new ClientWebSocket();
        _cts = new CancellationTokenSource();
    }

Then, we connect to the server by calling the following method

    public async Task ConnectAsync()
    {
        if (_webSocket.State == WebSocketState.Open) return;

        await _webSocket.ConnectAsync(_serverUri, CancellationToken.None).ConfigureAwait(false);
    }

    public async Task ConnectAsync()
    {
        if (_webSocket.State == WebSocketState.Open) return;

        await _webSocket.ConnectAsync(_serverUri, CancellationToken.None).ConfigureAwait(false);
    }

Obviously theres some more logic to it, however removed due to being unrelated to this specifically

I initially thought of writing a super simple interface with a thin wrapper around the client then inject it via DI, though i'm not sure if that's the best way

Best way to test something that depends on a ClientWebSocket

In one of our services, we use

ClientWebSocket

ClientWebSocket

    private MyService(string serverUrl)
    {
        _serverUri = new Uri(serverUrl);
        _webSocket = new ClientWebSocket();
        _cts = new CancellationTokenSource();
    }

    private MyService(string serverUrl)
    {
        _serverUri = new Uri(serverUrl);
        _webSocket = new ClientWebSocket();
        _cts = new CancellationTokenSource();
    }

Then, we connect to the server by calling the following method

    public async Task ConnectAsync()
    {
        if (_webSocket.State == WebSocketState.Open) return;

        await _webSocket.ConnectAsync(_serverUri, CancellationToken.None).ConfigureAwait(false);
    }

    public async Task ConnectAsync()
    {
        if (_webSocket.State == WebSocketState.Open) return;

        await _webSocket.ConnectAsync(_serverUri, CancellationToken.None).ConfigureAwait(false);
    }

Best way to test something that depends on a ClientWebSocket

Similar Threads

Best way to test something that depends on a ClientWebSocket

Similar Threads

Similar Threads

Similar Threads