CSS bug causes severe perf slowdown
Hey y'all! I know you are all busy but I though I'd bring this issue to your attention. I've been running performance tests on deployed apps, and solidstart should be doing great but... it is not. The issue is with CSS optimization.
https://github.com/solidjs/solid-start/issues/1324
The issue above lays out the problem.
GitHub
[Bug?]: CSS is not applied on build when Vite `build.cssCodeSplit: ...
Duplicates I have searched the existing issues Latest version I have tested the latest version Current behavior 😯 After building an app with cssCodeSplit: false, a bundled and hashed CSS file is co...
4 Replies
This limitation has a big effect on FCP and LCP
I'm doing a complete re-write of the "10 apps" article. I've deployed all the apps to vercel and am now using playwright to gather metrics. I'm including a lot of emphasis on CSS optimization bc that is a huge factor in LCP and FCP. Each framework has it's own optimization capabilities and I should have paid more attention to that in the original article
This is more a vite than a solid topic, because in classic solid, we do not handle CSS (unless you use <style> tags in your JSX). However, that's not the end of it. WIth SolidStart, we have our own meta framework and our wonderful @Katja (katywings) is currently optimizing CSS in as many situations as possible: https://github.com/solidjs/solid-start/pull/1965#discussion_r2514930351
GitHub
Devinxi - Unified CSS handling by katywings · Pull Request #1965 ...
PR Checklist
Please check if your PR fulfills the following requirements:
Addresses an existing open issue: fixes #000
Tests for the changes have been added (for bug fixes / features)
Design Go...
Hey @loren
As Alex mentioned we are doing a heavy rework of the CSS handling 😅 .
cssCodeSplit: false should not be needed after the rework. But just in case: I also just added a fix for the cssCodeSplit: false-bug mentioned in the 1324 issue.
https://github.com/solidjs/solid-start/commit/7eae789ebc884b8e878056992cc91cd46f03cd22Thank you for the update!