! Rushabh | Linux Shill - The docs says that Vi...
The docs says that Vias have a default dimension, but it is not implemented, i am adding it now, what should be the defaults. Same as the docs says ??
51 Replies
whatever the autorouter currently does
no the docs are super super wrong on those sizes
I believe it's like
0.15 for holeDiameter and 0.25 for outerDiameteri just wanted to clarify is
outerDiameter 0.6 https://github.com/tscircuit/tscircuit-autorouter/blob/df06b51adf6ba8132d239dffe530fb6aa3f36fb2/lib/solvers/ViaPossibilitiesSolver/ViaPossibilitiesSolver.ts#L118
I have no experience of autorouter repo
Hey @Techmannih please can you giude me a little 🥺huh i guess it is 0.6!
the whole diameter is probably 0.2 or 0.15
@! Rushabh | Linux Shill in which repos you have done this
You need to add them in the props, circuit-json, circuit-to-svg, then in core .
Have you done in them?
done is props,
will do in circuit-json, circuit-to-svg now
Thank you 🫡
Yes sure if you need any help please ping me
i found this in circuit-json
outer_diameter: distance.default("0.6mm"),
hole_diameter: distance.default("0.25mm"),
but autorouter uses 0.6 and 0.3
i just need to change 0.3 to 0.25 right
Yes, change them as you needed
Great, little bit changes. Look at the comment
@! Rushabh | Linux Shill look at this for hole diameter or you just need to confirm
i think i need to make some changes in props too, they should also have the default value of 0.6 and 0.3
right?
holeDiameter: distance.default(0.6).optional()Which reference are you using for 0.3
Yes
It should be 0.3
https://github.com/tscircuit/props/pull/512
.
Wait i think i made a mistake earlier by adding the optional check
You don't need to add a new default value in props.
You have mentioned the wrong hole diameter here, so I was saying to change them.
GPT said
outer_diameter: distance.default("0.6mm")
The field must exist.
If the user does not provide a value, it will be set to "0.6mm".
The result will always have a value.
outer_diameter: distance.default("0.6mm").optional()
The field is optional.
If the user omits it, the value will be undefined — not automatically set to "0.6mm".
Only if the user provides the field (even empty?) might the default apply when parsing.
If there was no default value. Don't be introduced new because we should default from the Circuit-josn
in circuit-json, should i add optional()
outer_diameter: distance.default("0.6mm"),
hole_diameter: distance.default("0.3mm"),`
Now you just need to make them optional. Other thing all good
Yes
Here you need to add default
Lgtm
so what changes do i need to do in core then
wait for merging this one then go for circuit-to-svg
🙌 Thank you for guiding
Yours welcome. Any time ping me
i think you already make them optional??
https://github.com/tscircuit/circuit-json/pull/362
@Techmannih can you review this https://github.com/tscircuit/footprinter/pull/429
yes, please once can you share the kicad viewer link of that footprint
ohh you are changing the width of the footprint
I think this doesn't matter, I checked you are calculating for one end to another end till silkscreen
Its only effects on the silkscreen
i was doing this to fix distance from center
https://jscad-electronics-o6rvp6e7e-tscircuit.vercel.app/?fixture=%7B%22path%22%3A%22examples%2FSOT-89.example.tsx%22%7D
Alright if you sure this should be fixed I merged this
i did it once
it works
https://github.com/tscircuit/footprinter/pull/420
i reduced from 4.8 to 4.2
but it was not enough
have you checked the body width for the cad model
the numbers are not adding up
something is off
i also make this for myslef to track my prs https://github.com/users/rushabhcodes/projects/4
can you check once locally by using
bun link
niceyes, rishab already approved it now for merge tag seve or dope/arnav
Hey i wanted to work on this, can you guide me a little https://github.com/tscircuit/tscircuit/issues/1156
@Techmannih @Seve
I am looking into it
can you point me to something easy to start with
yes, I see your work you are doing great work
Shibo showed me earlier but it is too difficult for me https://discord.com/channels/1233487248129921135/1438596884175257774
Any issues i can work on ??
try to build boards , building boards = using the product. If we don't use the product, how can we improve it? It is all coding- you code the boards, you code the fixes, you code the features, it's all code.
tscircuit is a coding library for coding boards
yes you can work on it. tag shibo in that thread, I m sure he will reply always
Are there any specific board required
https://www.sparkfun.com/sparkfun-samd21-mini-breakout.html
try to understand this one. if you need help please ping me
i need to add it in this repo right https://github.com/tscircuit/sparkfun-boards
@! Rushabh | Linux Shill yea adding to the sparkfun boards repo is a good idea, it's good for learning
Yeah, working on this rn https://www.sparkfun.com/sparkfun-tristimulus-color-sensor-opt4048dtsr-qwiic.html