Commandar Rick - hey so tried to find a fix for...
hey so tried to find a fix for https://github.com/tscircuit/core/issues/1671
7 Replies
The schematic view had a bug where net labels on vertical traces were incorrectly rotated to a vertical orientation, making them unreadable. This was caused by the layout solver assigning a vertical orientation to the label, which the rendering engine misinterpreted as a command to rotate the text itself, instead of just positioning it above or below the trace.
The fix separates the logic for label positioning from text rotation. The code now uses the original vertical orientation to correctly calculate the label's anchor point above or below the trace line. However, it then overrides this orientation with a horizontal one ("left" or "right") just before rendering, ensuring the text is always drawn horizontally while maintaining its proper position.
like this, is this fix alright?
@Seve
@shibo
I think so yeah
let's see a PR
that fix isn't correct because the net label is going over a trace
but glad you're looking into it