4 replies

Strange modded rendering issue

bugmod compatibilityquestion

Hi!

A user of my mod has found this strange rendering issue with one of my blocks when shaders are enabled. The block is rendering fine, but is rendering a duplicate of the grass block inside it floating in the air. My only thought is the BlockEntityRenderer I've made interacts weirdly with shaders, but I'm not familiar enough with shaders to fix it by myself.

public void render(StrangleFernBlockEntityRenderState state, MatrixStack matrices, OrderedRenderCommandQueue queue, CameraRenderState cameraState) {
  if (state.infestedBlock == null || state.infestedBlock.isOf(Blocks.AIR)) return;

  MinecraftClient client = MinecraftClient.getInstance();

  int tint = client.getBlockColors().getColor(state.infestedBlock, client.world, state.pos, 0);
  float r = (float)((tint >> 16) & 0xFF) / 255f;
  float g = (float)((tint >> 8) & 0xFF) / 255f;
  float b = (float)(tint & 0xFF) / 255f;

  BlockRenderManager blockRenderManager = client.getBlockRenderManager();
  BlockStateModel model = blockRenderManager.getModel(state.infestedBlock);

  BlockModelRenderer.render(
      matrices.peek(),
      client.getBufferBuilders().getEntityVertexConsumers().getBuffer(RenderLayers.cutout()),
      model,
      r, g, b,
      state.lightmapCoordinates,
      OverlayTexture.DEFAULT_UV
  );
}

public void render(StrangleFernBlockEntityRenderState state, MatrixStack matrices, OrderedRenderCommandQueue queue, CameraRenderState cameraState) {
  if (state.infestedBlock == null || state.infestedBlock.isOf(Blocks.AIR)) return;

  MinecraftClient client = MinecraftClient.getInstance();

  int tint = client.getBlockColors().getColor(state.infestedBlock, client.world, state.pos, 0);
  float r = (float)((tint >> 16) & 0xFF) / 255f;
  float g = (float)((tint >> 8) & 0xFF) / 255f;
  float b = (float)(tint & 0xFF) / 255f;

  BlockRenderManager blockRenderManager = client.getBlockRenderManager();
  BlockStateModel model = blockRenderManager.getModel(state.infestedBlock);

  BlockModelRenderer.render(
      matrices.peek(),
      client.getBufferBuilders().getEntityVertexConsumers().getBuffer(RenderLayers.cutout()),
      model,
      r, g, b,
      state.lightmapCoordinates,
      OverlayTexture.DEFAULT_UV
  );
}

state.infestedBlock is the grass block in question here (you can see it rendered as expected inside the StrangeFernBlock). The render is overly complex to account for biome tinting.
Any help as to how I can fix this to work with shaders would be greatly appreciated!

Strange modded rendering issue

bugmod compatibilityquestion

public void render(StrangleFernBlockEntityRenderState state, MatrixStack matrices, OrderedRenderCommandQueue queue, CameraRenderState cameraState) {
  if (state.infestedBlock == null || state.infestedBlock.isOf(Blocks.AIR)) return;

  MinecraftClient client = MinecraftClient.getInstance();

  int tint = client.getBlockColors().getColor(state.infestedBlock, client.world, state.pos, 0);
  float r = (float)((tint >> 16) & 0xFF) / 255f;
  float g = (float)((tint >> 8) & 0xFF) / 255f;
  float b = (float)(tint & 0xFF) / 255f;

  BlockRenderManager blockRenderManager = client.getBlockRenderManager();
  BlockStateModel model = blockRenderManager.getModel(state.infestedBlock);

  BlockModelRenderer.render(
      matrices.peek(),
      client.getBufferBuilders().getEntityVertexConsumers().getBuffer(RenderLayers.cutout()),
      model,
      r, g, b,
      state.lightmapCoordinates,
      OverlayTexture.DEFAULT_UV
  );
}

public void render(StrangleFernBlockEntityRenderState state, MatrixStack matrices, OrderedRenderCommandQueue queue, CameraRenderState cameraState) {
  if (state.infestedBlock == null || state.infestedBlock.isOf(Blocks.AIR)) return;

  MinecraftClient client = MinecraftClient.getInstance();

  int tint = client.getBlockColors().getColor(state.infestedBlock, client.world, state.pos, 0);
  float r = (float)((tint >> 16) & 0xFF) / 255f;
  float g = (float)((tint >> 8) & 0xFF) / 255f;
  float b = (float)(tint & 0xFF) / 255f;

  BlockRenderManager blockRenderManager = client.getBlockRenderManager();
  BlockStateModel model = blockRenderManager.getModel(state.infestedBlock);

  BlockModelRenderer.render(
      matrices.peek(),
      client.getBufferBuilders().getEntityVertexConsumers().getBuffer(RenderLayers.cutout()),
      model,
      r, g, b,
      state.lightmapCoordinates,
      OverlayTexture.DEFAULT_UV
  );
}

Strange modded rendering issue

Similar Threads

Strange modded rendering issue

Similar Threads

Similar Threads

Similar Threads