Rolling Hooks

Rolling Hooks!
I am working on a couple of additions to one of the upcoming version of 5e to add hooks to all of the system's rolling functions with the intention of allowing modules to fully customize these systems without having to wrap any methods. I welcome an eye on this from any module developers who work on modules that modify or respond to rolling behavior in 5e. Here are the three PRs with the changes:
https://github.com/foundryvtt/dnd5e/pull/1670
https://github.com/foundryvtt/dnd5e/pull/1662
https://github.com/foundryvtt/dnd5e/pull/1671

Giving things a look as I can, probably can't actually test these but I can at least point things out in the PRs

What specifically were you thinking?

Well, the first one was easy enough

😮

Is there an issue for adding an origin flag to templates? If not, why not throw one up so I have something to point to 😇

Whelp, it seems like MeasuredTemplateDocument doesn't like getting passed flags

But you can set them after it is created, odd

Hmm, it doesn't accept a flattened key for some reason

We are calling new MeasuredTemplateDocument(tempateData), so I'm not sure what the issue might be

Looks like the constructor doesn't take flattened objects, but the create method does

Such a complex change, hours of work: https://github.com/foundryvtt/dnd5e/pull/1662/commits/c48d6874873c4c85f2c3702e8f4810ea996e7663

The hit die ones are in another PR: https://github.com/foundryvtt/dnd5e/pull/1670

No pre rest hook at the moment, but it could be added

Sure, that will remind me

this has some minor problems same as chatMessages which outlive their consumable items.

scroll of fireball for instance

speaking of wishlists, idk if you've already done this or not but including the spellLevel as a flag on the created chatcard is a very useful thing, so consumers (including the system itself) don't have to parse the DOM to get the spell level of an upcast spell (when rolling damage)

that's probably a different task though

A bit late to the party, but THANK GOD for the preRollHitDie additions, this will make my life so much easier in Rest Recovery ❤️

Hooks have been merged! Hopefully there will be a new alpha branch soon so everyone can start testing them 🙂