Kord•4y ago

[Solved with PR] Custom RequestBuilder

Is there any way to patch this (https://github.com/kordlib/kord/issues/674) while the issue is dormant? I'm in need of doing such streaming, but since

RequestBuilder

RequestBuilder

is final, I cannot make a different

build

build

implementation that returns a different multipart request that doesn't eagerly consume all stream bytes.
Any suggestions?

GitHub

Add a streamed multipart request · Issue #674 · kordlib/kord

At the moment, Kord loads the entirety of an InputStream onto memory by this readBytes call. Since the Request class is sealed, one cannot make a custom request that converts just takes a ByteReadC...

tmpodOP•8/31/22, 3:42 PM

it's alright

tmpodOP•8/31/22, 3:43 PM

was just wondering if there was a way to patch it myself on my codebase, while I wait for it to get fixed (and then for kordex to use it ig)

DDeleted User shall consider patching it and releasing a snapshot

tmpodOP•8/31/22, 4:21 PM

if you want I could make the patch and submit a PR

tmpodOP•9/1/22, 10:12 AM

https://github.com/kordlib/kord/blob/0.8.x/rest/src/test/kotlin/request/MessageRequests.kt#L18
this test no longer makes sense, because channels are only read when the request is performed. Do I just nuke it or do you want to have some other test?

GitHub

kord/MessageRequests.kt at 0.8.x · kordlib/kord

Idiomatic Kotlin Wrapper for The Discord API. Contribute to kordlib/kord development by creating an account on GitHub.