multiroll damage roll messages

Messing with multiroll chat message in v10
C
Calego585d ago
demoing the 'edge cases' this supports
C
Calego585d ago
"Maximize Dice" + "Situational Bonus" + "Extra Critical Damage" + Deselecting one of the damage parts for this damage roll
C
Calego585d ago
slap a total on the bottom and you've got everything you used to have, and more.
No description
Z
Zhell585d ago
What does this do under the hood? Render the rolls individually, then combine into one message, or is it a custom template?
K
kaelad585d ago
Looks like a good addition to Roll Groups. It already has separate damage lines so it could be easy to add this in Easy isn't the right word here... From the demo with the checkboxes of the damage lines, that's something that Roll Groups has already. Seems like this just fits with RG
Z
Zhell585d ago
Ideally (and maybe subjectively), rolls with multiple damage.parts should be split like this automatically in the system. Do agree it would fit with RG otherwise And additionally ideally it would use the system's dropdown for applying damage/healing/temp, which would need that github issue solved...
C
Calego584d ago
Under the hood it creates one DamageRoll instance per part provided to a new dice class: DamageGroupRoll. That internally looks very similar to DamageRoll, but basically just curates and manages this group of individual rolls. In this POC I was using the roll.render method on each individual roll, then stitching them into one message I did this with a branch in the system code, it could probably be its own module in the interim though, might not interfere with roll groups Which issue is this? Yeah ideally it'd allow each individual roll to be right clicked, as well as the total For how I actually implemented this, the entry point is a method that has the exact same call signature as damageRoll. Or at least one that's really close. Need to review the diff again to be sure Instead of combining the provided parts, I keep them separate for longer in the process, and allow the configure roll dialog to filter those parts further, if the user wants. Long story short, roll groups would "just work" because all it does is curate which parts make it into the appropriate method (iirc)
Want results from more Discord servers?
Add your server
More Posts
❓About Commissions**Do not post commissions in this thread.** This thread is for discussing the commissions process, gIssue Submission ToolI'm looking for suggestions for free ticket submission without signing into GitHub that go beyond BuMM+, manifest+, attributions, and moreWe can make a thread to keep the MM+ discussion seperate if you'd likeGlitterSuppose someone wanted to make a module which created a stylistic ~~defect~~ enhancement that never Here s an example No template data inHere's an example. No template data in the actor object, but the object is associated with a templatRolling Hooks**Rolling Hooks!** I am working on a couple of additions to one of the upcoming version of 5e to addWeight MRSure.2.0.0 explorationFrom Atropos in the mothership (in v10 Feedback) > Hello folks, for those of you testing V10 using tElectron ViteIt loads at least.early v10 compat testing@dnd5e - No action required Work is being done on fixing the core system compatibility with v10 in module.json helpYou have no manifest or download fields.TyphonJS Runtime Library - RC 0.0.12The TyphonJS Runtime Library / TRL release candidate version 0.0.12 is now available. This is a massCypress FunYeah, unfortunately it ain't that simple 😅 Cypress, like you say, automatically retries things, andpreUpdateHook questionHey all, question for anyone who has a sec. I'm trying to use `preCreateActor` to add rolled values spitballing about jest mocksok. ok. ok. pure spitballing theory here. All the client side source exists in esmodule form (hopef1.6.1 testing@dnd5e Testing Action Requested but not required. version 1.6.1 is a bugfix version, it's pretty clconversion macro@max.pat did you have a macro or script which could change the old classFeatures data into advancemeAC calc changesI do not believe the data for AC actually changed, only the way it is calculated. evidence: no chang1.6.0 Custom Sheet ChangesLooking at the changes made which are breaking for custom sheets. Gonna make a thread for this.1.6.0 testingCommunity Testing Requests: For those of you interested in helping to QA this branch, I'll put toge