Operators.ConcatenateObject()

B

Brady Kelly•10/31/22, 12:06 PM

Why do you want to concatenate objects? That makes little sense

B

Brady Kelly•10/31/22, 12:19 PM

Then they want to concat strings, you're right. For objects it would only make sense in a language like JavaScript where doing so would concat 2 associative arrays

C

canton7•10/31/22, 12:19 PM

Yuck, that does a whole lot of magic: https://source.dot.net/#Microsoft.VisualBasic.Core/Microsoft/VisualBasic/CompilerServices/Operators.vb,106937ece6ff6502

B

Brady Kelly•10/31/22, 12:20 PM

Oh man, framework source is damn ugly in VB

M

MJarlOP•10/31/22, 12:43 PM

Hi,
Got an old project in my lap at work that my boss wants me to rebuild with newer technology. He means write it in csharp and not in vb haha.

M

MJarlOP•10/31/22, 12:44 PM

I want to Check lastActivity folder and file name

M

MJarlOP•10/31/22, 12:44 PM

 sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")
  
    'Search certificate source folder for pdf files and archive files
    Set oFolder = oFso.GetFolder(sReportSourceRootFolder)
    Set oFiles = oFolder.Files
    For Each oFile In oFiles 'Take all pdf-files first
        sLastActivity = "report " & oFile.Name
        'Pdf-files: copy pdf and archive
        If oFile.DateLastModified < (Now() - 0.05) And LCase(oFso.GetExtensionName(oFile.Path)) = "pdf" And Not Left$(oFile.Name, 1) = "~" Then
            sLog = sLog & vbCrLf & oFile.Name & " Rep"
            If CopyToMioArchive(oFile.Path) Then Archive oFile.Path, sReportDestRootFolder
        End If
    Next

 sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")
  
    'Search certificate source folder for pdf files and archive files
    Set oFolder = oFso.GetFolder(sReportSourceRootFolder)
    Set oFiles = oFolder.Files
    For Each oFile In oFiles 'Take all pdf-files first
        sLastActivity = "report " & oFile.Name
        'Pdf-files: copy pdf and archive
        If oFile.DateLastModified < (Now() - 0.05) And LCase(oFso.GetExtensionName(oFile.Path)) = "pdf" And Not Left$(oFile.Name, 1) = "~" Then
            sLog = sLog & vbCrLf & oFile.Name & " Rep"
            If CopyToMioArchive(oFile.Path) Then Archive oFile.Path, sReportDestRootFolder
        End If
    Next

 sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")
  
    'Search certificate source folder for pdf files and archive files
    Set oFolder = oFso.GetFolder(sReportSourceRootFolder)
    Set oFiles = oFolder.Files
    For Each oFile In oFiles 'Take all pdf-files first
        sLastActivity = "report " & oFile.Name
        'Pdf-files: copy pdf and archive
        If oFile.DateLastModified < (Now() - 0.05) And LCase(oFso.GetExtensionName(oFile.Path)) = "pdf" And Not Left$(oFile.Name, 1) = "~" Then
            sLog = sLog & vbCrLf & oFile.Name & " Rep"
            If CopyToMioArchive(oFile.Path) Then Archive oFile.Path, sReportDestRootFolder
        End If
    Next

 sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")
  
    'Search certificate source folder for pdf files and archive files
    Set oFolder = oFso.GetFolder(sReportSourceRootFolder)
    Set oFiles = oFolder.Files
    For Each oFile In oFiles 'Take all pdf-files first
        sLastActivity = "report " & oFile.Name
        'Pdf-files: copy pdf and archive
        If oFile.DateLastModified < (Now() - 0.05) And LCase(oFso.GetExtensionName(oFile.Path)) = "pdf" And Not Left$(oFile.Name, 1) = "~" Then
            sLog = sLog & vbCrLf & oFile.Name & " Rep"
            If CopyToMioArchive(oFile.Path) Then Archive oFile.Path, sReportDestRootFolder
        End If
    Next

M

MJarlOP•10/31/22, 12:45 PM

trying to convert this to c#

M

MJarlOP•10/31/22, 12:46 PM

Set oFiles = oFolder.Files =

LastActivity = Operators.ConcatenateObject("file", File);

But then I need to install And I do not what to do that

M

MJarlOP•10/31/22, 12:47 PM

Can I write it like this?

LastActivity = String.Concat("report", File);

LastActivity = String.Concat("report", File);

D

dancepanda42•10/31/22, 12:50 PM

how should last activity look like?
"report" and the file name or the complete file path?

M

MJarlOP•10/31/22, 12:54 PM

Just the report and the filename.
I have the filepath

M

MJarlOP•10/31/22, 12:57 PM

It is a automating file archive system.
It looks for three folders and looks for files that are 1 hour and moves the files to a other folder like a Archive.

D

dancepanda42•10/31/22, 1:33 PM

var folders = new string[]
{
    "Path\\to\\first\\folder",
    "Path\\to\\second\\folder",
    "Path\\to\\third\\folder",
};

foreach(var file in folders.SelectMany(x => Directory.GetFiles(x)))
{
    var fileInfo = new FileInfo(file);
    if (fileInfo.Extension == ".pdf" &&
        fileInfo.LastWriteTime < DateTime.Now - TimeSpan.FromMilliseconds(500) && 
        !file.StartsWith("~"))
    {

        // Do your stuff here...
        LastActivity = $"report{fileInfo.Name}";
    }
}

var folders = new string[]
{
    "Path\\to\\first\\folder",
    "Path\\to\\second\\folder",
    "Path\\to\\third\\folder",
};

foreach(var file in folders.SelectMany(x => Directory.GetFiles(x)))
{
    var fileInfo = new FileInfo(file);
    if (fileInfo.Extension == ".pdf" &&
        fileInfo.LastWriteTime < DateTime.Now - TimeSpan.FromMilliseconds(500) && 
        !file.StartsWith("~"))
    {

        // Do your stuff here...
        LastActivity = $"report{fileInfo.Name}";
    }
}

var folders = new string[]
{
    "Path\\to\\first\\folder",
    "Path\\to\\second\\folder",
    "Path\\to\\third\\folder",
};

foreach(var file in folders.SelectMany(x => Directory.GetFiles(x)))
{
    var fileInfo = new FileInfo(file);
    if (fileInfo.Extension == ".pdf" &&
        fileInfo.LastWriteTime < DateTime.Now - TimeSpan.FromMilliseconds(500) && 
        !file.StartsWith("~"))
    {

        // Do your stuff here...
        LastActivity = $"report{fileInfo.Name}";
    }
}

var folders = new string[]
{
    "Path\\to\\first\\folder",
    "Path\\to\\second\\folder",
    "Path\\to\\third\\folder",
};

foreach(var file in folders.SelectMany(x => Directory.GetFiles(x)))
{
    var fileInfo = new FileInfo(file);
    if (fileInfo.Extension == ".pdf" &&
        fileInfo.LastWriteTime < DateTime.Now - TimeSpan.FromMilliseconds(500) && 
        !file.StartsWith("~"))
    {

        // Do your stuff here...
        LastActivity = $"report{fileInfo.Name}";
    }
}

D

dancepanda42•10/31/22, 1:34 PM

here a little code snipped how it could work... (not tested)

M

MJarlOP•10/31/22, 1:36 PM

Nice, Looks like the one I am write right now but yours was so much better

M

MJarlOP•10/31/22, 1:36 PM

Thank you for you help.

D

dancepanda42•10/31/22, 1:39 PM

no problem
in C# there is also a lot of code sugar

D

dancepanda42•10/31/22, 1:43 PM

this line

LastActivity = $"report{fileInfo.Name}";

LastActivity = $"report{fileInfo.Name}";

just call

LastActivity = string.Concat("report", fileInfo.Name);

LastActivity = string.Concat("report", fileInfo.Name);

https://sharplab.io/#v2:CYLg1APgAgTAjAWAFBQMwAJboMLoN7LpGYZQAs6AsgBQCU+hxTAbgIYBO6AZgJYA2AUwCSAOy4B7dAF50IgQHdMcAHRCA8soBi/YWPHUARAdoBuRkyJtOAGVYBnAC4BBAMYOezHg4Ce09ABIDdgEAB3F2BzxeQVEJZQA5VgBbAQBfAzMkJlTkVKA

SharpLab

C#/VB/F# compiler playground.

Ddancepanda42 here a little code snipped how it could work... (not tested)

B

Brady Kelly•10/31/22, 2:02 PM

Shouldn't you be using

Path.Combind

Path.Combind

instead of interpolation? Or is "report" part of the filename?

BBrady Kelly Shouldn't you be using `Path.Combind` instead of interpolation? Or is "report" p...

D

dancepanda42•10/31/22, 2:06 PM

As I see it the variable LastActivity is only used to display the current process and is not used for file processing.
Otherwise you are right, Path.Join or Path.Combine would be the right choice.

B

Brady Kelly•10/31/22, 2:06 PM

OK

M

MJarlOP•10/31/22, 2:07 PM

This is my result

  string[] AttachmentFiles = Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);
        LastActivity = String.Concat("report", AttachmentFiles);
        foreach (string AttachmentFile in AttachmentFiles)
        {
            var fileInfo = new FileInfo(AttachmentFile);
            if (File.GetLastWriteTime(AttachmentFile) < DateTime.Now - TimeSpan.FromMilliseconds(500) && fileInfo.Extension == ".pdf" && !AttachmentFile.StartsWith("~"))
               {
                 Archive(AttachmentFile, AttachmentDestRootFolder);
               }
        }

  string[] AttachmentFiles = Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);
        LastActivity = String.Concat("report", AttachmentFiles);
        foreach (string AttachmentFile in AttachmentFiles)
        {
            var fileInfo = new FileInfo(AttachmentFile);
            if (File.GetLastWriteTime(AttachmentFile) < DateTime.Now - TimeSpan.FromMilliseconds(500) && fileInfo.Extension == ".pdf" && !AttachmentFile.StartsWith("~"))
               {
                 Archive(AttachmentFile, AttachmentDestRootFolder);
               }
        }

  string[] AttachmentFiles = Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);
        LastActivity = String.Concat("report", AttachmentFiles);
        foreach (string AttachmentFile in AttachmentFiles)
        {
            var fileInfo = new FileInfo(AttachmentFile);
            if (File.GetLastWriteTime(AttachmentFile) < DateTime.Now - TimeSpan.FromMilliseconds(500) && fileInfo.Extension == ".pdf" && !AttachmentFile.StartsWith("~"))
               {
                 Archive(AttachmentFile, AttachmentDestRootFolder);
               }
        }

  string[] AttachmentFiles = Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);
        LastActivity = String.Concat("report", AttachmentFiles);
        foreach (string AttachmentFile in AttachmentFiles)
        {
            var fileInfo = new FileInfo(AttachmentFile);
            if (File.GetLastWriteTime(AttachmentFile) < DateTime.Now - TimeSpan.FromMilliseconds(500) && fileInfo.Extension == ".pdf" && !AttachmentFile.StartsWith("~"))
               {
                 Archive(AttachmentFile, AttachmentDestRootFolder);
               }
        }

M

MJarlOP•10/31/22, 2:08 PM

How come my code snippes do not look like yours @dancepanda42 ?

D

dancepanda42•10/31/22, 2:14 PM

There are many ways that lead to the target.
You can omit the query

fileInfo.Extension == ".pdf"

fileInfo.Extension == ".pdf"

because of the filter in

Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);

Directory.GetFiles(ReportSourceRootFolder, "*.pdf", SearchOption.AllDirectories);

.
What is the variable

LastActivity

LastActivity

needed for anyway?

D

dancepanda42•10/31/22, 2:18 PM

behind the three "`" comes a csharp

M

MJarlOP•10/31/22, 2:19 PM

Its for the writing in the logging file later in the code.

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

D

dancepanda42•10/31/22, 2:20 PM

M

MJarlOP•10/31/22, 2:21 PM

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

 LastActivity = "Writing log file";
        Log = Log + Environment.NewLine + "RoboArchiveManager finished at " + DateTime.Now.ToString() + Environment.NewLine + Environment.NewLine;
        File.WriteAllText(FileLog, Log);

D

dancepanda42•10/31/22, 2:22 PM

it needs a new line after csharp

M

MJarlOP•10/31/22, 2:22 PM

Nice

M

MJarlOP•10/31/22, 2:23 PM

So do you code for a living or for hobbies?

D

dancepanda42•10/31/22, 2:24 PM

living

D

dancepanda42•10/31/22, 2:24 PM

but starts with hobby

D

dancepanda42•10/31/22, 2:25 PM

for the

Log

Log

variable I would recommend a StringBuilder. This is not as computationally intensive as an extension of a string.

M

MJarlOP•10/31/22, 2:27 PM

Same.

Okej Thanks for the tips.
Started working about 1 year ago.

But man o man a lot more to learn haha

D

dancepanda42•10/31/22, 2:27 PM

or just use the File.AppendAllText method instead of the Log variable

M

MJarlOP•10/31/22, 2:29 PM

Okej will try that

Thank you for taking your time helping me

M

MJarlOP•10/31/22, 2:35 PM

  'Create objects
    sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")

  'Create objects
    sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")

  'Create objects
    sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")

  'Create objects
    sLastActivity = "Create object oFso"
    Set oFso = CreateObject("Scripting.FileSystemObject")

M

MJarlOP•10/31/22, 2:37 PM

This bit is little wired.

What will happen if I write

LastActivity = "Create object Fso";

        object? Fso = Activator.CreateInstance(Type.GetTypeFromProgID("Scripting.FileSystemObject"));

LastActivity = "Create object Fso";

        object? Fso = Activator.CreateInstance(Type.GetTypeFromProgID("Scripting.FileSystemObject"));

LastActivity = "Create object Fso";

        object? Fso = Activator.CreateInstance(Type.GetTypeFromProgID("Scripting.FileSystemObject"));

LastActivity = "Create object Fso";

        object? Fso = Activator.CreateInstance(Type.GetTypeFromProgID("Scripting.FileSystemObject"));

M

MJarlOP•10/31/22, 2:37 PM

I do not know that its for

B

Brady Kelly•10/31/22, 2:52 PM

You shouldn't need a

FileSystemObject

FileSystemObject

. It looks like you only use it to get a directory, which can be done in a better way

B

Brady Kelly•10/31/22, 2:55 PM

You already use

Directory.GetFiles

Directory.GetFiles

to get the files in a directory, what else am I missing the oFso does?

Ddancepanda42 There are many ways that lead to the target. You can omit the query ```fileInfo....

M

MJarlOP•10/31/22, 2:56 PM

Yes I do not need LastActivity,

What I was trying to do is Finding folder then files in folder but do not need LastActivity

BBrady Kelly You shouldn't need a `FileSystemObject`. It looks like you only use it to get a ...

M

MJarlOP•10/31/22, 2:59 PM

Yes thats true. In the old code oFso is use to GetExtenstionName(FilePath)

M

MJarlOP•10/31/22, 3:00 PM

But I am getting that from Directory

B

Brady Kelly•10/31/22, 3:01 PM

You won't and shouldn't normally need to use reflection, i.e. CreateInstance

M

MJarlOP•10/31/22, 3:03 PM

Funny thing is that when I got the assignment I found Telerik code converter so I thought that this will be a easy task haha

B

Brady Kelly•10/31/22, 3:11 PM

Code converters are always dodgy

M

MJarlOP•10/31/22, 3:16 PM

Yes they are. Had some help but you two had helped me a lot to day. I appreciate that

Operators.ConcatenateObject()

Similar Threads

Similar Threads

Similar Threads