Novu•4y ago

An issue in the translation of a component

Say we wish to have the notification in French, but when the notifications are empty, there is an image still in English
How to fix it , without customizing the component?

DavidSouthmountain•11/15/22, 3:13 PM

Good catch, maybe we should remove the text from the image and make it translatable... @galiainouz @paweltymczuk any thoughts here?

DDavidSouthmountain Good catch, maybe we should remove the text from the image and make it translata...

Gali Baum•11/15/22, 3:16 PM

Whatever we do here we should remember to do to the no settings image as well

DavidSouthmountain•11/15/22, 3:18 PM

@medimess_ latest version of Novu should support this with the emptyState prop

Mmedimess_thank you very much, i saw this was available in NotificationCenter, but not in ...

DavidSouthmountain•11/15/22, 3:19 PM

Yes just discovered this

DavidSouthmountain•11/15/22, 3:20 PM

please feel free to create an issue to fix this

DavidSouthmountain•11/15/22, 3:24 PM

@medimess_ I have made a fix for this already

DavidSouthmountain•11/15/22, 3:26 PM

creating the PR now

Novu_Bot•11/15/22, 3:27 PM

@medimess_, you just advanced to level 1!

DavidSouthmountain•11/15/22, 3:27 PM

https://github.com/novuhq/novu/pull/2028

GitHub

fix: so empty state can be provided to popover notification center ...

What change does this PR introduce?
Make empty state prop a prop on popover as well.
Why was this change needed?
To be able to override the empty state in the popover notification center as well...

An issue in the translation of a component

Similar Threads

Similar Threads

Similar Threads