An issue in the translation of a component
Say we wish to have the notification in French, but when the notifications are empty, there is an image still in English
How to fix it , without customizing the component?
13 Replies
Good catch, maybe we should remove the text from the image and make it translatable... @galiainouz @paweltymczuk any thoughts here?
Whatever we do here we should remember to do to the no settings image as well
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
@medimess_ latest version of Novu should support this with the emptyState prop
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
Yes just discovered this 🤦♂️
please feel free to create an issue to fix this 🙂
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
@medimess_ I have made a fix for this already 😛
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
creating the PR now
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
@medimess_, you just advanced to level 1!
GitHub
fix: so empty state can be provided to popover notification center ...
What change does this PR introduce?
Make empty state prop a prop on popover as well.
Why was this change needed?
To be able to override the empty state in the popover notification center as well...