Top 10 words in array

Original message was deleted

hiyosilver•12/7/22, 5:49 PM

A simple way would be with Linq.

hiyosilver•12/7/22, 5:52 PM

words.Where(x => x.Length == 3).GroupBy(x => x).OrderByDescending(x => x.Count()).Take(10).ToArray()words.Where(x => x.Length == 3).GroupBy(x => x).OrderByDescending(x => x.Count()).Take(10).ToArray()

Rype•12/7/22, 5:53 PM

Thank you! that is one-liner but i generally don't like linq, can i do it someway else?

hiyosilver•12/7/22, 5:54 PM

Generally, anything you can do with Linq you can do without it aswell. But why don't you want to use Linq for this?

Rype•12/7/22, 5:54 PM

i assume it is not allowed since we weren't taught it yet

Rype•12/7/22, 5:55 PM

and i don't like it in general, it feels old

hiyosilver•12/7/22, 5:55 PM

Well, if you want to do it manually, the first step would be to replace the array with a List for example, since you don't know the maximum number of valid words to begin with.

hiyosilver•12/7/22, 5:55 PM

It's really not that old though

hiyosilver•12/7/22, 5:56 PM

It's perfectly valid modern C#, but I understand that it might look odd if you aren't doing Linq yet.

Rype•12/7/22, 5:57 PM

isn't linq a part of .net framework which is old and worse than dot net core

hiyosilver•12/7/22, 5:59 PM

Linq can be slower sometimes, but I think performance increased quite a bit with one of the more recent language versions so it's not as slow as it might be.

hiyosilver•12/7/22, 5:59 PM

And unless you have specific performance concerns, it probably won't matter for your usecase.

hiyosilver•12/7/22, 5:59 PM

But if you are learning it's probably a decent idea to just do the task manually

hiyosilver•12/7/22, 6:01 PM

What is patternpattern btw?

Rype•12/7/22, 6:01 PM

---g-am to find program diagram etc.

hiyosilver•12/7/22, 6:01 PM

Ah, I see

Rype•12/7/22, 6:01 PM

it is a simple AI where you ask questions and get the answer from corpus.txt which has the words

Rype•12/7/22, 6:04 PM

i think it'd be okay to use string array with max possible size to store all possible words, performance doesn't matter for now.-list isn't allowed either. But i can't think of a way to sort the words manually

hiyosilver•12/7/22, 6:04 PM

Damn, that's rough

hiyosilver•12/7/22, 6:05 PM

I mean you could use Array.Resize()Array.Resize() when you have reached capacity, that's basically what List does internally anyway.

hiyosilver•12/7/22, 6:05 PM

Maybe not with that function, but it just doubles its internal size when needed.

hiyosilver•12/7/22, 6:05 PM

How are you keeping track of the count of each individual word?

Rype•12/7/22, 6:06 PM

i am not now

Rype•12/7/22, 6:06 PM

just getting the word, and if it's repeated not getting it again

Rype•12/7/22, 6:06 PM

i can get the count in else if statement there but how do i know the index

hiyosilver•12/7/22, 6:06 PM

Currently you are just getting the first 10 words that match the pattern.

Rype•12/7/22, 6:07 PM

oh right

hiyosilver•12/7/22, 6:07 PM

You are just using count to check if every character matched atm?

Rype•12/7/22, 6:08 PM

yes

hiyosilver•12/7/22, 6:09 PM

Maybe a first step to make it a bit more readable would be to make a MatchPatternMatchPattern function?

hiyosilver•12/7/22, 6:09 PM

Takes the string and the pattern, then you can return falsereturn false early if any char doesnt match, so you dont have to do this count business.

hiyosilver•12/7/22, 6:10 PM

I would normally have suggested to maybe use a Dictionary<string,int>Dictionary<string,int> to keep track of word counts but if thats off the table...

Rype•12/7/22, 6:10 PM

i actually normally use functions a lot but not sure if a functions that will be used only once is good for performance

Rype•12/7/22, 6:10 PM

all those indents look bad too like this

hiyosilver•12/7/22, 6:10 PM

Don't fall into the trap of premature optimization.

hiyosilver•12/7/22, 6:11 PM

The compiler is pretty good at taking care of that sort of thing. I would be very surprised if it made any measurable difference to your program.

hiyosilver•12/7/22, 6:14 PM

I find all these teaching methods very confusing. I don't quite get what the point is of telling you not to use the thing that was made specifically for your usecase just because. But maybe I'm just not educated enough to understand

hiyosilver•12/7/22, 6:14 PM

Just use a second array to keep track of counts?

hiyosilver•12/7/22, 6:15 PM

Or make it an array of tuples (string, int)[]

Hhiyosilver I find all these teaching methods very confusing. I don't quite get what the poi...

Rype•12/7/22, 6:15 PM

i agree

Rype•12/7/22, 6:15 PM

i tried that but can't get the index right for counts - not the tuple, int array

hiyosilver•12/7/22, 6:15 PM

You would have to search the word array every single time for the index of the word you are trying to increase the count on

ero•12/7/22, 6:17 PM

whew wow linq is NOT old, it's probably the objectively best (in terms of completeness, features, performance) collection of extension methods that exists