DIA
discord.js - Imagine an app•2y ago
Batimius

Attaching already existing attachments to message

Hello there. So, as the title suggests, I want to attach already-existing message attachments on a new message. I am making a messageDelete event handler and I want to attach any files that have been deleted to the log message. Here is the code that I have so far: 
Cog.add = new Event("messageDelete", async (message) => {
    if (!logChannel) {logChannel = await message.client.channels.fetch(logChannelId)}
    if (message.author.bot) {return}

    const embed = new EmbedBuilder()
        .setAuthor({name: message.author.tag, iconURL: await message.author.displayAvatarURL()})
        .setTitle("Message Deleted")
        .setDescription(`**Message sent by ${message.author} deleted in ${message.channel}**${(message.content) ? ":\n" + message.content : "."}`)
        .setColor("#ca1919")
        .setTimestamp()

    await logChannel.send({embeds: [embed, ...message.embeds], files: [...message.attachments], stickers: [...message.stickers]})
})
Cog.add = new Event("messageDelete", async (message) => {
    if (!logChannel) {logChannel = await message.client.channels.fetch(logChannelId)}
    if (message.author.bot) {return}

    const embed = new EmbedBuilder()
        .setAuthor({name: message.author.tag, iconURL: await message.author.displayAvatarURL()})
        .setTitle("Message Deleted")
        .setDescription(`**Message sent by ${message.author} deleted in ${message.channel}**${(message.content) ? ":\n" + message.content : "."}`)
        .setColor("#ca1919")
        .setTimestamp()

    await logChannel.send({embeds: [embed, ...message.embeds], files: [...message.attachments], stickers: [...message.stickers]})
})
Now, when I delete a message with an image attached, I get the following error: 
TypeError: Cannot read properties of undefined (reading 'path')
    at findName (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:244:17)
    at MessagePayload.resolveFile (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:258:31)
    at C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:225:85
    at Array.map (<anonymous>)
    at MessagePayload.resolveFiles (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:225:56)
    at TextChannel.send (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\interfaces\TextBasedChannel.js:175:50)
    at Client.<anonymous> (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\Cogs\Misc\generalLogs.js:32:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'path')
    at findName (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:244:17)
    at MessagePayload.resolveFile (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:258:31)
    at C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:225:85
    at Array.map (<anonymous>)
    at MessagePayload.resolveFiles (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\MessagePayload.js:225:56)
    at TextChannel.send (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\node_modules\discord.js\src\structures\interfaces\TextBasedChannel.js:175:50)
    at Client.<anonymous> (C:\Users\Batman212369\Desktop\Discord Bots\RHS-Bot V2\Cogs\Misc\generalLogs.js:32:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
I really don't understand why this is a problem. I did think that it might be because I am not using an AttachmentBuilder, but the wiki clearly states that Array <Attachment> is also a viable option for the files argument. If someone could help me, that would be awesome. Thank you for your time and help, it is truly appreciated.
6 Replies
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
Batimius
Batimius•2y ago
Alright, so right after posting, I figured out that the problem is that message.attachments is a Collection. Using Object.map(message.attachments) seems to suppress the error, but it won't attach the image.
d.js docs
d.js docs•2y ago
MessageEmbed#attachFiles has been removed. Files should be attached via the message option object instead: 
  const attachment = new MessageAttachment('./image.png', 'image1.png');
  const embed = new MessageEmbed()
-   .attachFiles([attachment])
    .setTitle('Attachments')
    .setImage(`attachment://${attachment.name}`);

- channel.send(embed)
+ channel.send({
+   embeds: [embed],
+   files: [attachment]
+ });
  const attachment = new MessageAttachment('./image.png', 'image1.png');
  const embed = new MessageEmbed()
-   .attachFiles([attachment])
    .setTitle('Attachments')
    .setImage(`attachment://${attachment.name}`);

- channel.send(embed)
+ channel.send({
+   embeds: [embed],
+   files: [attachment]
+ });
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
Batimius
Batimius•2y ago
My intelligence strikes once more. Object.values() does not work on Collections. I used message.attachments.values() and it worked perfectly. Worked, I just had to use message.attachments.values(). Here's how the final line looks (for anyone who might have the same issue in the future): 
await logChannel.send({embeds: [embed, ...message.embeds], files: [...message.attachments.values()], stickers: [...message.stickers]})
await logChannel.send({embeds: [embed, ...message.embeds], files: [...message.attachments.values()], stickers: [...message.stickers]})
Regardless, thank you for your help, it is truly appreciated.
d.js docs
d.js docs•17mo ago
MessageEmbed#attachFiles has been removed. Files should be attached via the message option object instead: 
  const attachment = new MessageAttachment('./image.png', 'image1.png');
  const embed = new MessageEmbed()
-   .attachFiles([attachment])
    .setTitle('Attachments')
    .setImage(`attachment://${attachment.name}`);

- channel.send(embed)
+ channel.send({
+   embeds: [embed],
+   files: [attachment]
+ });
  const attachment = new MessageAttachment('./image.png', 'image1.png');
  const embed = new MessageEmbed()
-   .attachFiles([attachment])
    .setTitle('Attachments')
    .setImage(`attachment://${attachment.name}`);

- channel.send(embed)
+ channel.send({
+   embeds: [embed],
+   files: [attachment]
+ });
Want results from more Discord servers?
Add your server
More Posts
How to wait for all shards to startup using traditional sharding?So, originally, I thought I would just be able to do this with the ready event, but then I figured oPassing metadata from bot OAuth2 Invite link?I'm wanting to pass a variable from an oauth2 invite link and then read it when the bot is added to Best way to find and delete user messagesHello there. So, as the title implies, I want to know what the best way to fetch ALL user messages awhat does djs v14 support that does not support djs v13for the sake of interestHTTP interaction library or frameworkAre there any plans to make a library framework which can be used to create http interaction bots liCommand not working ( no errors on console , only your app hasnt respond )https://sourceb.in/w53N1QdpaWIntentsBitField is not a constructorI'm following this part of the guide: https://discordjs.guide/popular-topics/intents.html#enabling-iIssue with command info cmd```js if(command.perms === "Owner" && message.author.id !== config.client.owner) return message.chanIs there a possible way to see who unboosted the server?I know that I can check for `member.premiumSince` on a `memberUpdate` event, but the problem is if tis there a way i can get all the messages in a channel and get the message content of each message?title