C#•3y ago

❔ Using mvvm toolkit- Why my view has no access to my command?

I got the following Code in the view model:

      [RelayCommand]
        public void CalculateAndSave()

      [RelayCommand]
        public void CalculateAndSave()

And the view:

And in the View:
<Window x:Class="Calculator.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:VM="clr-namespace:Calculator.ViewModels"
        xmlns:local="clr-namespace:Calculator"
        mc:Ignorable="d"
        Title="MainWindow" Height="525" Width="350">
    <Window.DataContext>
        <VM:CalculatorVM/>
    </Window.DataContext>

And in the View:
<Window x:Class="Calculator.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:VM="clr-namespace:Calculator.ViewModels"
        xmlns:local="clr-namespace:Calculator"
        mc:Ignorable="d"
        Title="MainWindow" Height="525" Width="350">
    <Window.DataContext>
        <VM:CalculatorVM/>
    </Window.DataContext>

And in the View:
<Window x:Class="Calculator.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:VM="clr-namespace:Calculator.ViewModels"
        xmlns:local="clr-namespace:Calculator"
        mc:Ignorable="d"
        Title="MainWindow" Height="525" Width="350">
    <Window.DataContext>
        <VM:CalculatorVM/>
    </Window.DataContext>

And in the View:
<Window x:Class="Calculator.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:VM="clr-namespace:Calculator.ViewModels"
        xmlns:local="clr-namespace:Calculator"
        mc:Ignorable="d"
        Title="MainWindow" Height="525" Width="350">
    <Window.DataContext>
        <VM:CalculatorVM/>
    </Window.DataContext>

I got a few button on the view, when it try to give the button a command to CalculateAndSave, method isn't available, is my binding wrong?

ACiDCA7•3/6/23, 8:44 PM

is just the designer saying its not available or did you try it during running app to check if the method is called?

if its just the designer.. well it isnt so smart..

ACiDCA7•3/6/23, 8:44 PM

you would have to tell it more explicitly of what type the datacontext is

antimatter8189OP•3/6/23, 8:45 PM

Meaning what?

antimatter8189OP•3/6/23, 8:45 PM

i tried just now running it

antimatter8189OP•3/6/23, 8:45 PM

didnt hit the breakpoint of the command so it aint working for sure

ACiDCA7•3/6/23, 8:45 PM

ACiDCA7•3/6/23, 8:46 PM

well since you didnt copy the part of the button i cant help further

antimatter8189OP•3/6/23, 8:46 PM

        <Button x:Name="oneButton"
                Command="{Binding CalculateAndSave}"
                Click="NumberButton_Click"
                Style="{StaticResource numberButtonsStyle}"
                Content="1"
                Grid.Row="4"/>

        <Button x:Name="oneButton"
                Command="{Binding CalculateAndSave}"
                Click="NumberButton_Click"
                Style="{StaticResource numberButtonsStyle}"
                Content="1"
                Grid.Row="4"/>

@ACiDCA7

antimatter8189OP•3/6/23, 8:46 PM

nothing to see much

antimatter8189OP•3/6/23, 8:46 PM

just want to bind a command to it

ACiDCA7•3/6/23, 8:47 PM

click and command maybe clashing?

antimatter8189OP•3/6/23, 8:47 PM

hmm

antimatter8189OP•3/6/23, 8:47 PM

Nop. now when i click nothing happens

antimatter8189OP•3/6/23, 8:47 PM

command isnt binded

antimatter8189OP•3/6/23, 8:48 PM

Probably the entire view model isnt binded properly

antimatter8189OP•3/6/23, 8:49 PM

no autocompletion on the method name

ACiDCA7•3/6/23, 8:50 PM

try setting datacontext in codebehind/where oyu are creating the window

antimatter8189OP•3/6/23, 8:50 PM

I did

antimatter8189OP•3/6/23, 8:51 PM

    public partial class MainWindow : Window
    {
        double lastNumber, result;
        SelectedOperator selectedOperator;
        public MainWindow()
        {
            InitializeComponent();
            DataContext = new CalculatorVM();

            acButton.Click += AcButton_Click;
            negativeButton.Click += NegativeButton_Click;
            percentageButton.Click += PercentageButton_Click;
            equalButton.Click += EqualButton_Click;
        }

    public partial class MainWindow : Window
    {
        double lastNumber, result;
        SelectedOperator selectedOperator;
        public MainWindow()
        {
            InitializeComponent();
            DataContext = new CalculatorVM();

            acButton.Click += AcButton_Click;
            negativeButton.Click += NegativeButton_Click;
            percentageButton.Click += PercentageButton_Click;
            equalButton.Click += EqualButton_Click;
        }

antimatter8189OP•3/6/23, 8:51 PM

didnt help either

antimatter8189OP•3/6/23, 8:51 PM

smth is quite odd here

ACiDCA7•3/6/23, 8:52 PM

<Button x:Name="oneButton"
                Command="{Binding CalculateAndSaveCommand}"
                Style="{StaticResource numberButtonsStyle}"
                Content="1"
                Grid.Row="4"/>

<Button x:Name="oneButton"
                Command="{Binding CalculateAndSaveCommand}"
                Style="{StaticResource numberButtonsStyle}"
                Content="1"
                Grid.Row="4"/>

try this

Aantimatter8189 ``` <Button x:Name="oneButton" Command="{Binding Calculat...

hengi•3/6/23, 8:52 PM

Should be called

CalculateAndSaveCommand

CalculateAndSaveCommand

AACiDCA7 ```xml <Button x:Name="oneButton" Command="{Binding CalculateAnd...

antimatter8189OP•3/6/23, 8:53 PM

I have this code in place, it does nothing

ACiDCA7•3/6/23, 8:53 PM

like hengi said
Command
is missing in the binding name

ACiDCA7•3/6/23, 8:54 PM

dont change the methodname tho

ACiDCA7•3/6/23, 8:54 PM

just where you are binding

antimatter8189OP•3/6/23, 8:55 PM

@ACiDCA7 , @hengi :
https://github.com/KostaKing/Calculator

GitHub

GitHub - KostaKing/Calculator

Contribute to KostaKing/Calculator development by creating an account on GitHub.

antimatter8189OP•3/6/23, 8:55 PM

look at line 100 at the xaml

antimatter8189OP•3/6/23, 8:55 PM

i got it

antimatter8189OP•3/6/23, 8:56 PM

It doesnt work

antimatter8189OP•3/6/23, 8:56 PM

the breakpoint isn't being activated in the command

hengi•3/6/23, 8:58 PM

The CalculatorVM needs to be partial so it can generate the code

hengi•3/6/23, 8:58 PM

And add it to the class

Hhengi And add it to the class

antimatter8189OP•3/6/23, 8:58 PM

meaning?

antimatter8189OP•3/6/23, 8:59 PM

    public partial class CalculatorVM: ObservableObject

    public partial class CalculatorVM: ObservableObject

antimatter8189OP•3/6/23, 8:59 PM

whats next

antimatter8189OP•3/6/23, 8:59 PM

still doesnt work

hengi•3/6/23, 9:00 PM

Try to run it and see if there are binding errors
Unless you set the design time type of the data context (don't remember exactly what it's called) it will not autocomplete and might give you a warning

Hhengi Try to run it and see if there are binding errors Unless you set the design time...

antimatter8189OP•3/6/23, 9:02 PM

Nothing shows up, btw you do have the full repo

antimatter8189OP•3/6/23, 9:02 PM

the codebase is rly simple , just trying to convert it to using mvvm

antimatter8189OP•3/6/23, 9:03 PM

u can run it on your own machine, press 1 and see nothing happens

antimatter8189OP•3/6/23, 9:03 PM

it just doesnt go in the method

hengi•3/6/23, 9:03 PM

1 sec

ACiDCA7•3/6/23, 9:06 PM

grr i couldnt get it to work with the attribute aswell but if you go the "oldshool" way it works

antimatter8189OP•3/6/23, 9:07 PM

but i dont wanna go oldschool lol

antimatter8189OP•3/6/23, 9:07 PM

thats the point

antimatter8189OP•3/6/23, 9:07 PM

why doesnt the attribute works?

antimatter8189OP•3/6/23, 9:07 PM

like tf

❔ Using mvvm toolkit- Why my view has no access to my command?

Similar Threads

Similar Threads

Similar Threads