C#•3y ago

❔ Why is the order of execution wrong?

I have this code inside an async clipboard changes listener

    public static Dictionary<string, object> ClipboardData = new();

    private async void TrackClipboardChanges_EventHandler(object sender, object e)
    {
        var dataPackageView = Clipboard.GetContent();
        if (dataPackageView.Contains(StandardDataFormats.Text))
        {
            string text;
            try
            {
                text = await dataPackageView.GetTextAsync();
                if (text.Length > 67108864)
                {
                    GC.Collect();
                    GC.WaitForPendingFinalizers();
                    return;
                }

                Debug.WriteLine("----------------------------- (1)");
                foreach (var dictionaryValue in ClipboardData.Values)
                {
                    Debug.WriteLine(dictionaryValue + " " + text);
                    if (dictionaryValue.ToString() == text) return;
                }
                Debug.WriteLine("----------------------------- (2)");

                AddEntryToClipboardData(ClipboardItemType.Text, text);
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(ex);
                return;
            }
        }

        [More code but it doesn't matter in this case]

    public static Dictionary<string, object> ClipboardData = new();

    private async void TrackClipboardChanges_EventHandler(object sender, object e)
    {
        var dataPackageView = Clipboard.GetContent();
        if (dataPackageView.Contains(StandardDataFormats.Text))
        {
            string text;
            try
            {
                text = await dataPackageView.GetTextAsync();
                if (text.Length > 67108864)
                {
                    GC.Collect();
                    GC.WaitForPendingFinalizers();
                    return;
                }

                Debug.WriteLine("----------------------------- (1)");
                foreach (var dictionaryValue in ClipboardData.Values)
                {
                    Debug.WriteLine(dictionaryValue + " " + text);
                    if (dictionaryValue.ToString() == text) return;
                }
                Debug.WriteLine("----------------------------- (2)");

                AddEntryToClipboardData(ClipboardItemType.Text, text);
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(ex);
                return;
            }
        }

        [More code but it doesn't matter in this case]

    public static Dictionary<string, object> ClipboardData = new();

    private async void TrackClipboardChanges_EventHandler(object sender, object e)
    {
        var dataPackageView = Clipboard.GetContent();
        if (dataPackageView.Contains(StandardDataFormats.Text))
        {
            string text;
            try
            {
                text = await dataPackageView.GetTextAsync();
                if (text.Length > 67108864)
                {
                    GC.Collect();
                    GC.WaitForPendingFinalizers();
                    return;
                }

                Debug.WriteLine("----------------------------- (1)");
                foreach (var dictionaryValue in ClipboardData.Values)
                {
                    Debug.WriteLine(dictionaryValue + " " + text);
                    if (dictionaryValue.ToString() == text) return;
                }
                Debug.WriteLine("----------------------------- (2)");

                AddEntryToClipboardData(ClipboardItemType.Text, text);
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(ex);
                return;
            }
        }

        [More code but it doesn't matter in this case]

    public static Dictionary<string, object> ClipboardData = new();

    private async void TrackClipboardChanges_EventHandler(object sender, object e)
    {
        var dataPackageView = Clipboard.GetContent();
        if (dataPackageView.Contains(StandardDataFormats.Text))
        {
            string text;
            try
            {
                text = await dataPackageView.GetTextAsync();
                if (text.Length > 67108864)
                {
                    GC.Collect();
                    GC.WaitForPendingFinalizers();
                    return;
                }

                Debug.WriteLine("----------------------------- (1)");
                foreach (var dictionaryValue in ClipboardData.Values)
                {
                    Debug.WriteLine(dictionaryValue + " " + text);
                    if (dictionaryValue.ToString() == text) return;
                }
                Debug.WriteLine("----------------------------- (2)");

                AddEntryToClipboardData(ClipboardItemType.Text, text);
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(ex);
                return;
            }
        }

        [More code but it doesn't matter in this case]

But the output in the debug console is the following

----------------------------- (1)
----------------------------- (2)
c8c876ee-5961-4822-a9a5-ee086633c724_Text
----------------------------- (1)
salut salut

----------------------------- (1)
----------------------------- (2)
c8c876ee-5961-4822-a9a5-ee086633c724_Text
----------------------------- (1)
salut salut

----------------------------- (1)
----------------------------- (2)
c8c876ee-5961-4822-a9a5-ee086633c724_Text
----------------------------- (1)
salut salut

----------------------------- (1)
----------------------------- (2)
c8c876ee-5961-4822-a9a5-ee086633c724_Text
----------------------------- (1)
salut salut

Note that

----------------------------- (2)

----------------------------- (2)

doesn't come out at the end if there's something in ClipboardData for some reason

What am I doing wrong?

Anton•3/25/23, 7:16 AM

what's 67108864?

TheRanger•3/25/23, 7:17 AM

did u try debugging with the debugger?

TheRanger•3/25/23, 7:17 AM

$debug

TTheRanger $debug

MODiX•3/25/23, 7:17 AM

https://docs.microsoft.com/en-us/visualstudio/get-started/csharp/tutorial-debugger?view=vs-2022

Tutorial: Debug C# code - Visual Studio (Windows)

Learn features of the Visual Studio debugger and how to start the debugger, step through code, and inspect data in a C# application.

TheRanger•3/25/23, 7:17 AM

i assume u called this method twice

AAnton what's 67108864?

gush3lOP•3/25/23, 7:26 AM

around 64mb in text irc

TTheRanger did u try debugging with the debugger?

gush3lOP•3/25/23, 7:26 AM

no, will try using it, thanks for the suggestion

Ggush3l around 64mb in text irc

Anton•3/25/23, 7:31 AM

so what?

MODiX•3/25/23, 7:34 AM

TheRanger#3357

REPL Result: Success

(67108864 / 1024) / 1024

(67108864 / 1024) / 1024

Result: int

Compile: 310.866ms | Execution: 59.733ms | React with ❌ to remove this embed.

AAnton so what?

gush3lOP•3/25/23, 7:39 AM

i am ignoring texts that are bigger than 64mb atm

gush3lOP•3/25/23, 7:40 AM

i know that it could be like 256mb with the same lenght but

Ggush3l i am ignoring texts that are bigger than 64mb atm

Anton•3/25/23, 7:42 AM

Well then make that a constant that says

ignoredTextLengthThreshold

ignoredTextLengthThreshold

Anton•3/25/23, 7:42 AM

Also, why are you calling the GC there?

gush3lOP•3/25/23, 7:43 AM

because for big texts even if i don't use them, the ram gets used up for no reason

Ggush3l i am ignoring texts that are bigger than 64mb atm

Anton•3/25/23, 7:43 AM

also, it's 2x that, strings are UTF-16

Anton•3/25/23, 7:44 AM

chars are two bytes long

Ggush3l because for big texts even if i don't use them, the ram gets used up for no reas...

Anton•3/25/23, 7:45 AM

Just so you know, running the gc does not remove your strings from the dictionary, and it's not even guaranteed to remove the text variable from memory

Anton•3/25/23, 7:45 AM

And even if it would, don't call the gc manually

Anton•3/25/23, 7:46 AM

It will run on its own when your program needs memory

Anton•3/25/23, 7:46 AM

Idk, maybe you have a good reason to do what you did

Anton•3/25/23, 7:46 AM

But if you did it just because, then don't do it

gush3lOP•3/25/23, 7:47 AM

ik they don't get removed from the dictionary and ik that gc is something that I shouldn't mess with, I will make a video of the ram usage so y understand why i did that

gush3lOP•3/25/23, 7:47 AM

probably and 100% there is a better way for the useless ram usage issue, but i will look into that more after i resolve my execution order thingy

Anton•3/25/23, 7:48 AM

Running the GC is a very costly operation

Accord•3/26/23, 7:55 AM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.

❔ Why is the order of execution wrong?

Similar Threads

Similar Threads

Similar Threads