https://github.com/aarhus/twoworkersonequeue

J

Jeff•4/9/23, 4:27 PM

Thanks!!! will give it a try

V

vas•4/13/23, 8:26 AM

Hi, I have a main worker which has service bindings to two other workers. I would like to create jest integration test for the main worker. I have the directory structure similar to the one in https://miniflare.dev/core/mount and the main worker wrangler.toml has [miniflare.mounts] [build.upload]. I am creating a miniflare instance in the jest test file with a script path

describe('bluegreen routing', () => { const mf = new Miniflare({ envPath: true, packagePath: true, wranglerConfigPath: true, scriptPath: 'dist/index.mjs', modules: true }) it('should route to the green worker', async () => { const response = await mf.dispatchFetch('http://127.0.0.1/parent', { method: 'GET' }) if (response) { const parsedResp = await response.text() expect(parsedResp).toEqual('Green Hello World!') } }) })
describe('bluegreen routing', () => { const mf = new Miniflare({ envPath: true, packagePath: true, wranglerConfigPath: true, scriptPath: 'dist/index.mjs', modules: true }) it('should route to the green worker', async () => { const response = await mf.dispatchFetch('http://127.0.0.1/parent', { method: 'GET' }) if (response) { const parsedResp = await response.text() expect(parsedResp).toEqual('Green Hello World!') } }) })
describe('bluegreen routing', () => { const mf = new Miniflare({ envPath: true, packagePath: true, wranglerConfigPath: true, scriptPath: 'dist/index.mjs', modules: true }) it('should route to the green worker', async () => { const response = await mf.dispatchFetch('http://127.0.0.1/parent', { method: 'GET' }) if (response) { const parsedResp = await response.text() expect(parsedResp).toEqual('Green Hello World!') } }) })
describe('bluegreen routing', () => { const mf = new Miniflare({ envPath: true, packagePath: true, wranglerConfigPath: true, scriptPath: 'dist/index.mjs', modules: true }) it('should route to the green worker', async () => { const response = await mf.dispatchFetch('http://127.0.0.1/parent', { method: 'GET' }) if (response) { const parsedResp = await response.text() expect(parsedResp).toEqual('Green Hello World!') } }) })

This test exceeds the timeout. I get this error

ReferenceError: clearImmediate is not defined

ReferenceError: clearImmediate is not defined

ReferenceError: clearImmediate is not defined

ReferenceError: clearImmediate is not defined
Is this the right way to do jest tests with Miniflare?

🔌 Multiple Workers · Miniflare

Fun, full-featured, fully-local simulator for Cloudflare Workers

Ttorgomatic How does one simulate failures with miniflare? For example, I've got a worker th...

D

DaniFoldi•4/22/23, 7:35 AM

Hmm, I don't think miniflare supports intentionally failing reads or writes, but with the new database system this could be something worth implementing, like

binding<R2>.failAllWrites({ prefix: '/test' })
binding<R2>.failAllReads({ prefix: '/test2' })

binding<R2>.failAllWrites({ prefix: '/test' })
binding<R2>.failAllReads({ prefix: '/test2' })

binding<R2>.failAllWrites({ prefix: '/test' })
binding<R2>.failAllReads({ prefix: '/test2' })

binding<R2>.failAllWrites({ prefix: '/test' })
binding<R2>.failAllReads({ prefix: '/test2' })

(@mrbbot)

DDaniFoldi Hmm, I don't think miniflare supports intentionally failing reads or writes, but...

M

MrBBot•4/25/23, 11:30 AM

Yep, Miniflare doesn't support this at the moment. If you're using something like the Miniflare Jest environment (https://miniflare.dev/testing/jest), you could try spy on the

put

put

put

put method of your

bucket

bucket

bucket

bucket binding before passing it to your worker, and then mocking that implementation to throw?

Ssilentdevnull Using miniflare can I have my the DO part of it and have it read and write data?...

M

MrBBot•4/27/23, 9:44 PM

Definitely! Should work out-of-the-box with

wrangler dev --local

wrangler dev --local

wrangler dev --local

wrangler dev --local, or check out https://miniflare.dev/storage/durable-objects if you're using Miniflare directly.

T

TravisFrank•4/29/23, 9:07 AM

@mrbbot Do queue consumers receive messages in the

vitest

vitest

vitest

vitest environment? I have a worker that's both the producer & consumer of a queue, and in a test I'm calling

worker.fetch

worker.fetch

worker.fetch

worker.fetch directly via an import of

main

main

.

worker.fetch

worker.fetch

worker.fetch

worker.fetch sends a message to the queue. As far as I can tell,

worker.queue

worker.queue

worker.queue

worker.queue is never called as a result of this send. Is that expected? Is there an idiomatic way to E2E test a queue like this in the

vitest

vitest

vitest

vitest environment?

V

Vlady•4/29/23, 7:38 PM

Hi y'all, is it possible to interactively debug a durable object? When I add breakpoints in my tests, the VSCode debugger goes into the stub instead of the actual object.

This is how I'm writing tests

describe('Cart durable object', () => {
  let context: GraphqlContext
  let config: AppConfig
  let cart: Durable.Object

  beforeAll(async () => {
    context = createTestContext()
    config = context.config

    const id = context.bindings.Cart.newUniqueId()
    cart = context.bindings.Cart.get(id)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add', config })

    const resp = await cart.fetch(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
      }),
    })

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let config: AppConfig
  let cart: Durable.Object

  beforeAll(async () => {
    context = createTestContext()
    config = context.config

    const id = context.bindings.Cart.newUniqueId()
    cart = context.bindings.Cart.get(id)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add', config })

    const resp = await cart.fetch(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
      }),
    })

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let config: AppConfig
  let cart: Durable.Object

  beforeAll(async () => {
    context = createTestContext()
    config = context.config

    const id = context.bindings.Cart.newUniqueId()
    cart = context.bindings.Cart.get(id)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add', config })

    const resp = await cart.fetch(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
      }),
    })

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let config: AppConfig
  let cart: Durable.Object

  beforeAll(async () => {
    context = createTestContext()
    config = context.config

    const id = context.bindings.Cart.newUniqueId()
    cart = context.bindings.Cart.get(id)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add', config })

    const resp = await cart.fetch(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
      }),
    })

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

V

Vlady•4/29/23, 8:36 PM

So, it turns out to properly test the object, I had to manually instantiate it like this. Otherwise it would swallow errors and logs and that's difficult to debug.

describe('Cart durable object', () => {
  let context: GraphqlContext
  let cart: Cart

  beforeAll(async () => {
    context = createTestContext()
    const id = context.bindings.Cart.newUniqueId()
    const state = await getMiniflareDurableObjectState(id as any)
    cart = new Cart(state, context.bindings)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add' })

    const req = new Request(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
        quantity: 1,
      }),
    })

    const resp = await cart.fetch(req)

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let cart: Cart

  beforeAll(async () => {
    context = createTestContext()
    const id = context.bindings.Cart.newUniqueId()
    const state = await getMiniflareDurableObjectState(id as any)
    cart = new Cart(state, context.bindings)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add' })

    const req = new Request(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
        quantity: 1,
      }),
    })

    const resp = await cart.fetch(req)

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let cart: Cart

  beforeAll(async () => {
    context = createTestContext()
    const id = context.bindings.Cart.newUniqueId()
    const state = await getMiniflareDurableObjectState(id as any)
    cart = new Cart(state, context.bindings)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add' })

    const req = new Request(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
        quantity: 1,
      }),
    })

    const resp = await cart.fetch(req)

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

describe('Cart durable object', () => {
  let context: GraphqlContext
  let cart: Cart

  beforeAll(async () => {
    context = createTestContext()
    const id = context.bindings.Cart.newUniqueId()
    const state = await getMiniflareDurableObjectState(id as any)
    cart = new Cart(state, context.bindings)
  })

  test('add item', async () => {
    const url = createCartDurableObjectUrl({ path: 'add' })

    const req = new Request(url, {
      method: 'POST',
      body: JSON.stringify({
        itemId: 'World of Warcraft: The Burning Crusade',
        quantity: 1,
      }),
    })

    const resp = await cart.fetch(req)

    const items: CartItem[] = await resp.json()
    expect(items).toEqual([
      {
        id: 'World of Warcraft: The Burning Crusade',
        name: 'World of Warcraft: The Burning Crusade',
        price: {
          amount: 1,
          currency: Currency.Gbp,
        },
        quantity: 1,
      },
    ])
  })
})

TTravisFrank @mrbbot Do queue consumers receive messages in the `vitest` environment? I have...

M

MrBBot•5/2/23, 9:07 PM

Hey!

Apologies for the delayed response. It looks like there is a bug here. Miniflare doesn't realise it needs to register event listeners for your Worker when running tests with Queue consumers set up. As a temporary workaround, you can define an empty Durable Object in your Worker, and add it to your

vitest.config.ts

vitest.config.ts

vitest.config.ts

vitest.config.ts's

environmentOptions

environmentOptions

environmentOptions

environmentOptions. See https://gist.github.com/mrbbot/a1d5ddc5d7fd2878d58cf5f8215e9a3a for an example.

Gist

Vitest Queue Consumers Fix

Vitest Queue Consumers Fix. GitHub Gist: instantly share code, notes, and snippets.

V

vvo•5/4/23, 9:36 AM

I am curious about a code example I saw in the miniflare blog post: https://blog.cloudflare.com/miniflare/
It contains:

export async function increment(namespace, key) {
  // method
}

export default {
  async fetch(request, env, ctx) {
    // handler which uses increment
  },
};

export async function increment(namespace, key) {
  // method
}

export default {
  async fetch(request, env, ctx) {
    // handler which uses increment
  },
};

export async function increment(namespace, key) {
  // method
}

export default {
  async fetch(request, env, ctx) {
    // handler which uses increment
  },
};

export async function increment(namespace, key) {
  // method
}

export default {
  async fetch(request, env, ctx) {
    // handler which uses increment
  },
};

Is it common to expose internal methods like increment and test them separately in Jest? I thought it would be always "better" to only test the handler.
The official doc doesn't contain such examples, mostly curious here

Vvvo 👋 I am curious about a code example I saw in the miniflare blog post: https://b...

D

DaniFoldi•5/4/23, 9:42 AM

Yep, unit tests usually cover single components, and mock everything else to isolate issues to individual parts. The examples don't contain such tests as they (should) work normally with or without the miniflare environment. If you find something that breaks because of the miniflare environment, drop a message here or feel free to open an issue on GitHub

DDaniFoldi Yep, unit tests usually cover single components, and mock everything else to iso...

V

vvo•5/4/23, 9:45 AM

I was gonna use miniflare-jest to test my worker by making fetch requests to it, as seen in https://miniflare.dev/testing/jest#writing-and-running-tests. I guess we could call theses "integration tests". Can you confirm this is the right way (I guess so, given the doc).

C

CalBoy•5/4/23, 2:04 PM

Has anyone had any trouble with miniflare + module workers + the JS API?

I'm trying to migrate a servier-worker to a module worker for various reasons and I can't get miniflare to let me debug the module worker. Whenever I run the NodeJS debugger and put debug statements in it's almost like miniflare isn't even loading my worker.

I start miniflare via

    let mf = new miniflare.Miniflare({
        wranglerConfigPath: true,
        upstream: testingDetails.url,
        modules: true,
        cache: false,
        kvNamespaces: ["CONFIG"]
    });

    let mf = new miniflare.Miniflare({
        wranglerConfigPath: true,
        upstream: testingDetails.url,
        modules: true,
        cache: false,
        kvNamespaces: ["CONFIG"]
    });

    let mf = new miniflare.Miniflare({
        wranglerConfigPath: true,
        upstream: testingDetails.url,
        modules: true,
        cache: false,
        kvNamespaces: ["CONFIG"]
    });

    let mf = new miniflare.Miniflare({
        wranglerConfigPath: true,
        upstream: testingDetails.url,
        modules: true,
        cache: false,
        kvNamespaces: ["CONFIG"]
    });

C

CalBoy•5/4/23, 2:32 PM

Ah ha! Setting

scriptPath

scriptPath

scriptPath

scriptPath manually appears to have fixed it which is weird. I've then had to correctly setup

--experimental-vm-modules

--experimental-vm-modules

now we're getting closer.

I'm not hitting issues with

Some functionality, such as asynchronous I/O (fetch, Cache API, KV).....

Some functionality, such as asynchronous I/O (fetch, Cache API, KV).....

Some functionality, such as asynchronous I/O (fetch, Cache API, KV).....

Some functionality, such as asynchronous I/O (fetch, Cache API, KV)..... but its erroring during the request context.

CCalBoy Ah ha! Setting `scriptPath` manually appears to have fixed it which is weird. I'...

M

MrBBot•5/4/23, 3:38 PM

Hey!

Not ideal, but as a temporary workaround you can disable that restriction locally with https://miniflare.dev/core/standards#global-functionality-limits. What's the full stack trace of that error?

MMrBBot Hey! 👋 Not ideal, but as a temporary workaround you can disable that restrictio...

C

CalBoy•5/4/23, 3:41 PM

Thats what I ended up doing, well for a bit. It was getting stuck in KV lookups. I then ended up hitting issues with an

input instanceof Request

input instanceof Request

input instanceof Request

input instanceof Request check during the dispatchFetch handling. Which led me to - https://github.com/cloudflare/miniflare/issues/454

I ended up pinning a bunch of my deps. Removing package-lock and doing a fresh

npm i

npm i

and it fixed a whole heap of things.

GitHub

Failed to parse URL from [object Object] · Issue #454 · cloudflare/...

I tried to upgrade from 2.10.0 to 2.11.0 and failed with the issue: [mf:err] POST /api/endpoint/1: TypeError: Failed to parse URL from [object Object] at new Request (/Users/Maxim/project/node_modu...

C

CalBoy•5/4/23, 3:41 PM

And after doing that it all appears stable.

C

CalBoy•5/4/23, 3:42 PM

Well apart from having to set the scriptPath. Not entirely sure why that isn't coming from package.json anymore

CCalBoy Well apart from having to set the scriptPath. Not entirely sure why that isn't c...

M

MrBBot•5/4/23, 5:14 PM

Have you got the

packagePath: true

packagePath: true

packagePath: true

packagePath: true option set?

MMrBBot Have you got the `packagePath: true` option set?

C

CalBoy•5/5/23, 8:29 AM

Yup and had a

module

module

module

module set in package.json doing what was required for that above issue fixed it tho

I

ItHurtsWhenIPvp•5/13/23, 6:40 AM

Has anyone tried wrapping miniflare in their own package? Im looking to build a custom miniflare to interact with workers and our internal tooling. We're mostly wanting the local reproduction without giving the ability to publish themselves within the enterprise.

I

ItHurtsWhenIPvp•5/18/23, 8:25 AM

I may just be really tired today, but wasn't miniflare able to run typescript locally without a build step? May have been dreaming too.

S

sathoro•5/18/23, 7:16 PM

I ran into another thing that miniflare does not fail on but real workers do fail:

const myBlob = await response.blob();

await env.BUCKET.put(blobId, myBlob); // must use myBlob.stream()

const myBlob = await response.blob();

await env.BUCKET.put(blobId, myBlob); // must use myBlob.stream()

const myBlob = await response.blob();

await env.BUCKET.put(blobId, myBlob); // must use myBlob.stream()

const myBlob = await response.blob();

await env.BUCKET.put(blobId, myBlob); // must use myBlob.stream()

Ssathoro I ran into another thing that miniflare does not fail on but real workers do fai...

A

Adam•5/18/23, 7:22 PM

Can you file this in the Miniflare repo? https://github.com/cloudflare/miniflare/issues/new

AAdam Can you file this in the Miniflare repo? https://github.com/cloudflare/miniflare...

S

sathoro•5/18/23, 7:25 PM

https://github.com/cloudflare/miniflare/issues/584 done

RRph Is it possible to somehow enable support for `eval` in miniflare?

M

MrBBot•5/24/23, 8:42 AM

Hey!

This isn't possible right now unfortunately. What's your use case?

RRph I wanted to build myself something akin to a hybrid between jupyter and codepen ...

M

MrBBot•5/24/23, 8:45 AM

Interesting... you might want to look into the Chrome DevTools protocol. Miniflare supports starting an inspector server, which you can then send WebSocket messages to for evaluating code in the Miniflare context.

B

Ben-xD•5/27/23, 6:59 AM

Is wrangler3/miniflare3 planning to add support for breakpoints/debugging?

U

Unsmart•5/27/23, 7:38 PM

Seems to be there

https://github.com/cloudflare/miniflare/blob/6bace6b464e1458ac3621d14d639750455299853/packages/miniflare/src/api.ts#L111

GitHub

miniflare/api.ts at 6bace6b464e1458ac3621d14d639750455299853 · clou...

Fully-local simulator for Cloudflare Workers. Contribute to cloudflare/miniflare development by creating an account on GitHub.

miniflare/api.ts at 6bace6b464e1458ac3621d14d639750455299853 · clou...

W

Walshy•5/27/23, 7:45 PM

in miniflare 3 it may have been removed/renamed

W

Walshy•5/27/23, 7:45 PM

but I'd recommend just using Wrangler, Miniflare hasn't been the recommended way to do local development/testing for a few years now

Nndls i might just be daft, but doing local dev with cloudflare is not easy, and the d...

A

Adam•5/28/23, 9:21 PM

PM for Workers here

Thanks for the feedback. Updating and enhancing local documentation is in the works. Hopefully consolidating everything with Wrangler will reduce the need to figure out questions like - is this Miniflare or Wrangler. Sorry for the problems so far though. If I can help at all feel free to ping me directly.

Also, we are aware of the sveltekit issue and are talking through solutions there.

https://github.com/aarhus/twoworkersonequeue

Similar Threads

Similar Threads

Similar Threads