11 replies

how tight should types be?

I have a tasker field in my task type. The most "accurate" type would look like -

type tasker = 
  {
    _id: ObjectId;
    name: string;
    email: string;
  }
| {
    email: string;
  }
| {
    persona: string;
  };

type tasker = 
  {
    _id: ObjectId;
    name: string;
    email: string;
  }
| {
    email: string;
  }
| {
    persona: string;
  };

However, I get errors like

Property '_id' does not exist on type '{ email: string; }'.

Property '_id' does not exist on type '{ email: string; }'.

even after I am checking as follows

if (tasker._id) {}

if (tasker._id) {}

. This is quite annoying and tbh I am not even sure how to get around it.

On the other hand I could type tasker in the following way -

type tasker = 
  {
    _id?: ObjectId;
    name?: string;
    email?: string;
    persona?: string
  }

type tasker = 
  {
    _id?: ObjectId;
    name?: string;
    email?: string;
    persona?: string
  }

but this doesn't feel right.

What should I be doing?