TTC
Theo's Typesafe Cult•11mo ago
Roncan

Made a small CSS styled component

I know it's not the biggest thing but I got some feedback about my naming in a question before and I wanted to see if my css structure is better this time. CSS Code: https://github.com/juandevac/grupo_06_e-commerce/blob/main/public/css/home/footer.css Any feedback is appreciated! 😸
GitHub
grupo_06_e-commerce/public/css/home/footer.css at main · juandevac/...
Proyecto de e-commerce para Digital House. Curso Full Stack con Node JS. - juandevac/grupo_06_e-commerce
Solution:
its tough to judge css without being able to see the page
Jump to solution
3 Replies
Solution
Tom
Tom•11mo ago
its tough to judge css without being able to see the page
Tom
Tom•11mo ago
the only thing ill say is in general its not usually great to use viewport width and height im also not sure why you have your footer with margin-bottom: 2vh since youre in this discord ill tell you right now youre gunna get a lot of people who would tell you to use tailwind (and tbh im one of them. tailwind's pretty great)
Roncan
Roncan•11mo ago
Thanks for the feedback! Well, what unit would you recommend me to use when setting heights and widths instead of viewport? The reason I used that margin was because I needed to give my footer some height without changing the flow of my footer. And I do plan to get into tailwind in the future 😄 !
Want results from more Discord servers?
Add your server
More Posts
Vercel Deployment giving prerender errorI am getting this error when I deploy on vercel but its running locally.@acme/nextjs:build: Error ocFeedback for my infrastructure needed!I'm trying to understand best practices for creating one infrastructure for my startup. Would like sUtility type to "undiscriminate" a discriminated unionSo this might be kind of a hacky thing, but I've got a use case that could greatly benefit from it. Generated types from Prisma client are not getting assigned automatically.I'm currently following the create-T3-app tutorial with some small twists on my end (I use NextAuth For whom and when does it make sense to learn a Framework like React.I am relatively new to webdev and currently just use Flask for my backend to render my HTML files anClerk | Next 13: 401, unauthorized when trying to hit Next backend.I have set up the following middleware: ```ts import { authMiddleware } from "@clerk/nextjs"; exportCreating (guest)checkout sessions with TRPC/Stripe/Zustand.Hi! Just asking to see if this is a correct approach I am managing carts using Zustand since it is Best sources for UI inspiration?I know there are some websites where devs can show off their UI and you can gather inspiration, but Cheapest Hosting ServiceHey folks, it's my first time doing freelancing, so i'm building a web app for the client and after Fetching Data on the ServerI was checking out the create-t3-app docs and saw that getServerSide props was discouraged. Then wha