Referencing value assigned to variable in statement builder within another statement

Whit · 2023-08-01T00:27:34.057Z

Given a statement that does something like: ```cs var expr = new ExpressionBuilder(); expr.AppendVerbatim("var propertyValue = ("); expr.AppendType(field.Type); expr.AppendVerbatim(")valueType?.GetValue("); //And so on ``` I would like to use the value assigned to `propertyValue` elsewhere, but of course, I cannot use AppendExpression with it since the context isn't aware it's been assigned. How might I go about referencing this variable value as an expression? Thanks!

P

Petr Onderka•8/1/23, 8:36 AM

I think that

ExpressionFactory.Parse("propertyValue")

ExpressionFactory.Parse("propertyValue")

ExpressionFactory.Parse("propertyValue")

ExpressionFactory.Parse("propertyValue") should work for you. (It's effectively the same as using

ExpressionBuilder

ExpressionBuilder

ExpressionBuilder

ExpressionBuilder and then calling

ToExpression()

ToExpression()

ToExpression()

ToExpression() on it.)

G

Gael Fraiteur•8/1/23, 8:51 AM

May you're looking for IFieldOrPropertyBuilder.InitializerExpression. https://doc.metalama.net/api/metalama_framework_code_ifieldorproperty_initializerexpression#Metalama_Framework_Code_IFieldOrProperty_InitializerExpression

W

WhitOP•8/2/23, 11:45 PM

Well, let me put it another way. Say I use the statement builder with the following:

var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim("var abc = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse("abc").Value;

var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim("var abc = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse("abc").Value;

var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim("var abc = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse("abc").Value;

var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim("var abc = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse("abc").Value;

When I insert the statement via

meta.InsertStatement

meta.InsertStatement

meta.InsertStatement

meta.InsertStatement, this doesn't give me a variable I can reference in other parts of the template. The use of

ExpressionFactory.Parse

ExpressionFactory.Parse

ExpressionFactory.Parse

ExpressionFactory.Parse on the next line does give me

abc

abc

abc

abc to use in the template, but this suddenly can't be used in a compile-time loop as it outputs the following:

var abc = 123;
var abc = abc;

var abc = 123;
var abc_1 = abc;

var abc = 123;
var abc_2 = abc;

var abc = 123;
var abc = abc;

var abc = 123;
var abc_1 = abc;

var abc = 123;
var abc_2 = abc;

var abc = 123;
var abc = abc;

var abc = 123;
var abc_1 = abc;

var abc = 123;
var abc_2 = abc;

var abc = 123;
var abc = abc;

var abc = 123;
var abc_1 = abc;

var abc = 123;
var abc_2 = abc;

I suppose I could do something like:

//Out of the loop
var ii = meta.CompileTime(0);

//In the loop
var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim($"var abc{ii} = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse($"abc{ii}").Value;

//Out of the loop
var ii = meta.CompileTime(0);

//In the loop
var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim($"var abc{ii} = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse($"abc{ii}").Value;

//Out of the loop
var ii = meta.CompileTime(0);

//In the loop
var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim($"var abc{ii} = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse($"abc{ii}").Value;

//Out of the loop
var ii = meta.CompileTime(0);

//In the loop
var sampleBuilder = new StatementBuilder();
                            sampleBuilder.AppendVerbatim($"var abc{ii} = ");
                            sampleBuilder.AppendLiteral(123);
                            sampleBuilder.AppendVerbatim(";");
                            meta.InsertStatement(sampleBuilder.ToStatement());
                            var abc = ExpressionFactory.Parse($"abc{ii}").Value;

And then this yields (outside of the apparently bug reported at https://github.com/postsharp/Metalama/issues/202):

var abc0 = 123;
var abc = abc0;

var abc1 = 123;
var abc_1 = abc1;

var abc2 = 123;
var abc_2 = abc2;

var abc0 = 123;
var abc = abc0;

var abc1 = 123;
var abc_1 = abc1;

var abc2 = 123;
var abc_2 = abc2;

var abc0 = 123;
var abc = abc0;

var abc1 = 123;
var abc_1 = abc1;

var abc2 = 123;
var abc_2 = abc2;

var abc0 = 123;
var abc = abc0;

var abc1 = 123;
var abc_1 = abc1;

var abc2 = 123;
var abc_2 = abc2;

Again, since the first variable is more than sufficient for my purposes but is simply inaccessible since it's created by string, might you consider updating the StatementBuilder to include an out variable or the like that I can use to reference the variable on the class instead of this hacky approach resulting in two lines in the output for each assignment (especially since the

ExpressionFactory.Parse().Value

ExpressionFactory.Parse().Value

ExpressionFactory.Parse().Value

ExpressionFactory.Parse().Value approach itself yields a unique variable name each time?

Thanks!

GitHub

Issues · postsharp/Metalama

Metalama is a Roslyn-based meta-programming framework. Use this repo to report bugs or ask questions. - Issues · postsharp/Metalama

G

Gael Fraiteur•8/3/23, 8:51 AM

OK I got it. Didn't read your first request properly it seems

G

Gael Fraiteur•8/3/23, 8:51 AM

However generally we want to keep StatementBuilder and ExpressionBuilder as minimalistic as possible.

G

Gael Fraiteur•8/3/23, 8:55 AM

So you want an API that defines a local variable and takes care of the unique naming?

P

Petr Onderka•8/3/23, 8:59 AM

If you want to reference the variable you declared, you can do it by declaring

var abc = ExpressionFactory.Parse("abc");

var abc = ExpressionFactory.Parse("abc");

var abc = ExpressionFactory.Parse("abc");

var abc = ExpressionFactory.Parse("abc"); and then using

abc.Value

abc.Value

abc.Value

abc.Value where you used just

abc

abc

abc

abc previously.
Alternatively, I wonder if using

Builder

Builder

Builder

Builder just for the expression and letting Metalama manage the variable would work better. Let me check.

P

Petr Onderka•8/3/23, 9:07 AM

Yeah, I think that would work better for you.
For example, this code:

foreach (var i in meta.CompileTime(Enumerable.Range(0, 3)))
{
    var sampleBuilder = new ExpressionBuilder();
    sampleBuilder.AppendLiteral(123);
    var abc = sampleBuilder.ToValue();
    Console.WriteLine(abc);
}

foreach (var i in meta.CompileTime(Enumerable.Range(0, 3)))
{
    var sampleBuilder = new ExpressionBuilder();
    sampleBuilder.AppendLiteral(123);
    var abc = sampleBuilder.ToValue();
    Console.WriteLine(abc);
}

foreach (var i in meta.CompileTime(Enumerable.Range(0, 3)))
{
    var sampleBuilder = new ExpressionBuilder();
    sampleBuilder.AppendLiteral(123);
    var abc = sampleBuilder.ToValue();
    Console.WriteLine(abc);
}

foreach (var i in meta.CompileTime(Enumerable.Range(0, 3)))
{
    var sampleBuilder = new ExpressionBuilder();
    sampleBuilder.AppendLiteral(123);
    var abc = sampleBuilder.ToValue();
    Console.WriteLine(abc);
}

generates:

var abc = 123;
Console.WriteLine(abc);
var abc_1 = 123;
Console.WriteLine(abc_1);
var abc_2 = 123;
Console.WriteLine(abc_2);

var abc = 123;
Console.WriteLine(abc);
var abc_1 = 123;
Console.WriteLine(abc_1);
var abc_2 = 123;
Console.WriteLine(abc_2);

var abc = 123;
Console.WriteLine(abc);
var abc_1 = 123;
Console.WriteLine(abc_1);
var abc_2 = 123;
Console.WriteLine(abc_2);

var abc = 123;
Console.WriteLine(abc);
var abc_1 = 123;
Console.WriteLine(abc_1);
var abc_2 = 123;
Console.WriteLine(abc_2);

W

WhitOP•8/3/23, 9:45 AM

I'll see if I can't use that - I suspect I'm going to run into issues along the lines of https://github.com/postsharp/Metalama/issues/202 since this is within several

if

if

and

foreach

foreach

foreach

foreach loops both run-time and compile-time

GitHub

Bug: Metalama not incrementing in compile-time loop as expected · I...

I'm trying to solve a variable reference issue. Put simply, I have a loop inside a template that enumerates several compile-time values to write several run-time statements. As these are writte...

P

Petr Onderka•8/3/23, 9:52 AM

I think you shouldn't, since you wouldn't be modifying any compile-time variables.

W

WhitOP•8/3/23, 10:05 AM

Yeah, unfortunately I think my toy sample there doesn't quite work with what I actually have in place - can't see how to fit that in there.

W

WhitOP•8/3/23, 10:07 AM

I've got a foreach going through a compile-time dictionary, a foreach inside that going through the values of that kv pair, then a null check on each of those values (compile-time), then a run-time null check (per issue #202 up there) and then inside all that I've got one more equality check and the statement builder. Right now I'm incrementing the meta.CompileTime after the run-time null check but at the bottom of the inner foreach.

W

WhitOP•8/3/23, 10:08 AM

If not for all my loops already there, I think that'd be a clever fix

W

WhitOP•8/3/23, 10:09 AM

To your question @the.metalama.guy Yes, that'd be great - an API that lets me simply provide the right side of a statement after the "=" and places its own unique variable name in there so I might trivially reference it anywhere else.

W

WhitOP•8/3/23, 10:17 AM

Like what I get with expression builder - don't much care what the auto-generated variable name is, so long as it's unique and I can trivially reference it in the rest of the template

G

Gael Fraiteur•8/3/23, 10:17 AM

I think it's rather going to be a method like:

IExpression DefineLocalVariable( string nameHint, IType type, IExpression? assignedValue );

G

Gael Fraiteur•8/3/23, 10:19 AM

Please file a feature request on GitHub because we don't track tickets here -- just for ephemeral discussions

W

WhitOP•8/3/23, 10:28 AM

Absolutely - I've been thinking about what I'd like it to do, but I'll file a ticket about it in a few

W

WhitOP•8/3/23, 11:10 AM

Filed under #205