current 2.18 blocker: https://github.com/webgpu-native/webgpu-headers/issues/84

GitHub

Issues with C / C++ bool type. · Issue #84 · webgpu-native/webgpu-h...

This is an issue that someone (graphite?) raised on Discord but didn't file here. The bool types in C/C++ are kinda weird and can not match, especially when put back to back. webgpu.h shouldn&#...

Lyris the KitoriOP•8/5/23, 1:56 AM

we currently generate invalid bindings when using stdbool beacuse stdbool is bad

Lyris the KitoriOP•8/5/23, 1:58 AM

_Bool_Bool in C iirc has an undefined size

PPerksey Ok I was drifting off to sleep when I thought of an issue: implicit casts. The d...

Kai•8/5/23, 4:40 AM

I don't really understand the edge case here

LLyris the Kitori we currently generate invalid bindings when using stdbool beacuse stdbool is *ba...

Kai•8/5/23, 4:41 AM

Looks like there's already a PR to change it to be uint instead. Not sure it's worth fixing on our side

KKai Looks like there's already a PR to change it to be uint instead. Not sure it's w...

Lyris the KitoriOP•8/5/23, 4:42 AM

PR is not finished

Lyris the KitoriOP•8/5/23, 4:43 AM

its not worth fixing on our side, as i had stated on github https://github.com/dotnet/Silk.NET/issues/1593#issuecomment-1664580272

Kai•8/5/23, 4:43 AM

Yeah saw that

LLyris the Kitori we currently generate invalid bindings when using stdbool beacuse stdbool is *ba...

Maxine•8/5/23, 4:44 AM

isn't a register always at least 4 bytes

Maxine•8/5/23, 4:44 AM

meaning using an int is fine

Lyris the KitoriOP•8/5/23, 4:44 AM

doesnt work that way for structs

Maxine•8/5/23, 4:45 AM

structs are usually padded to the word

Lyris the KitoriOP•8/5/23, 4:45 AM

their fields arent

Lyris the KitoriOP•8/5/23, 4:46 AM

either way how big _Bool_Bool is is likely different from MSVC -> GCC so i dont trust it

Maxine•8/5/23, 4:46 AM

what size is the bool in the chromium impl

Lyris the KitoriOP•8/5/23, 4:46 AM

its stdbool _Bool_Bool, so undefined by the C99 spec

Maxine•8/5/23, 4:46 AM

what compiler does chromium use

Maxine•8/5/23, 4:46 AM

clang i think right?

Lyris the KitoriOP•8/5/23, 4:46 AM

it can use multiple

Lyris the KitoriOP•8/5/23, 4:46 AM

also this is unrelated to chromium

Lyris the KitoriOP•8/5/23, 4:46 AM

Dawn is whats important

Lyris the KitoriOP•8/5/23, 4:47 AM

and thats a separate component linked in

Lyris the KitoriOP•8/5/23, 4:47 AM

wgpu is also important

Lyris the KitoriOP•8/5/23, 4:47 AM

and thats Rust

Lyris the KitoriOP•8/5/23, 4:47 AM

and the official windows libs are MSVC ABI

Lyris the KitoriOP•8/5/23, 4:47 AM

while the official linux ones are GNU ABI

Maxine•8/5/23, 4:47 AM

if there's an inconsistency in the headers then how has this not crashed and burned already

Lyris the KitoriOP•8/5/23, 4:47 AM

it is crashing and burning already

Lyris the KitoriOP•8/5/23, 4:47 AM

see https://github.com/dotnet/Silk.NET/issues/1593

Lyris the KitoriOP•8/5/23, 4:48 AM

all the webgpu headers are using _Bool_Bool, and we dont handle that properly

Lyris the KitoriOP•8/5/23, 4:48 AM

no one else in their right mind uses stdbool, so its only now emerging in WebGPU

Maxine•8/5/23, 4:48 AM

from the looks of it, all of the wgpu structs have bools in a place where it can't cause a problem in actuality

Lyris the KitoriOP•8/5/23, 4:48 AM

did you read the issue i linked

Lyris the KitoriOP•8/5/23, 4:49 AM

its already causing problems

Maxine•8/5/23, 4:49 AM

Lyris the KitoriOP•8/5/23, 4:49 AM

Maxine•8/5/23, 4:49 AM

yeah im dumb disregard that

Lyris the KitoriOP•8/5/23, 4:50 AM

in the end, this is a bug on our side thats not worth the time and effort to fix due to the undefined ABI size of _Bool_Bool, its better to try to fix upstream if possible

Maxine•8/5/23, 4:51 AM

fair

Lyris the KitoriOP•8/5/23, 5:51 AM

fair warning i have a sore throat and have been losing my voice all day, its very possible i may not be able to do C&C tomorrow if it dont improve

Kai•8/5/23, 6:17 AM

I guess it's evening now for you?

Lyris the KitoriOP•8/5/23, 6:17 AM

its 23:17

Lyris the KitoriOP•8/5/23, 6:17 AM

aka almost midnight

Lyris the KitoriOP•8/5/23, 6:17 AM

im just doing my japanese study before bed

Lyris the KitoriOP•8/5/23, 7:06 AM

i have a very light fever, if it doesnt improve in the morning unfortanately i wont be able to join

Lyris the KitoriOP•8/5/23, 1:41 PM

i have not improved

Kai•8/5/23, 1:49 PM

Get better soon :)

Kai•8/5/23, 2:02 PM

@Perksey I think it'd be ok to just still have a bit of a chat (although we'd be missing out on the main 2x maintainer...)
Do you want to? Thoughts?

Lyris the KitoriOP•8/5/23, 2:04 PM

inflation hitting hard
not even a 10x dev, im only a 2x dev

Kai•8/5/23, 2:13 PM

lmao

jvyden•8/5/23, 3:34 PM

not even a rockstar dev, just a rock dev

current 2.18 blocker: https://github.com/webgpu-native/webgpu-headers/issues/84

Similar Threads