13 replies

Questioning the input type of `ReadonlyArray.groupWith`

Hi all,
Why is the input type of

ReadonlyArray.groupWith

ReadonlyArray.groupWith

NonEmptyReadonlyArray?
The type signature is currently:

  <A>(self: NonEmptyReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): NonEmptyArray<NonEmptyArray<A>>

  <A>(self: NonEmptyReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): NonEmptyArray<NonEmptyArray<A>>

I would have thought the following would be more appropriate:

  <A>(self: ReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): ReadonlyArray<NonEmptyArray<A>>

  <A>(self: ReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): ReadonlyArray<NonEmptyArray<A>>

13 replies

Hi all,
Why is the input type of

ReadonlyArray.groupWith

ReadonlyArray.groupWith

NonEmptyReadonlyArray?
The type signature is currently:

  <A>(self: NonEmptyReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): NonEmptyArray<NonEmptyArray<A>>

  <A>(self: NonEmptyReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): NonEmptyArray<NonEmptyArray<A>>

I would have thought the following would be more appropriate:

  <A>(self: ReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): ReadonlyArray<NonEmptyArray<A>>

  <A>(self: ReadonlyArray<A>, isEquivalent: (self: A, that: A) => boolean): ReadonlyArray<NonEmptyArray<A>>