Weird header response randomly
Not sure what causes it but randomnly when trying to convert an image to a stream to upload to youtube, uploadthing returns a weird header value and it breaks the parser. This link specifically: https://uploadthing.com/f/b17adb06-212c-4002-9685-c3b0653d14ad-albtc1.png
15 Replies
also insomnia says this:
Error: Stream error in the HTTP/2 framing layer
wonder if it loads here?
https://uploadthing.com/f/b17adb06-212c-4002-9685-c3b0653d14ad-albtc1.png
didn't loadbut this one will:
https://uploadthing.com/f/a343d9ba-dbf6-48cf-8dd6-e007092224e8-uqe41n.jpg
node 18.17.1
Ok so it's something to do with the filename:
YouTube β GA4 Downloads v2.png
i think the dash is breaking it
Someone else is getting the same issue on github i'll track there: https://github.com/pingdotgg/uploadthing/issues/402
GitHub
[bug]: When uploaded file name is Chinese, node fetch download will...
Provide environment information System: OS: macOS 13.3.1 CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz Memory: 1.97 GB / 16.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 18.17.1 - ~/.nvm/...
Oh shit, very good catch. Ty for sharing here, cc @julius @markr
Thatβs an interesting one.
I believe I have found a solution for this, just manually applied the change on the file that wasn't working before, mind testing that one again on your end to see if it works?
Iβm out and about today, but Iβll ping when I get home later π
Looks like it's working now π
Nice, I'm going to merge those changes then, so future uploads will hopefully "just work"
Changes are up, looks to be working on my end π
Umm well, would it now being stopped the other way?
@markr
oh no
maxresdefault.jpg
is the file name
correct?yes it's being uploaded from a URL from youtube
this is happening on the server i'm guessing because it does this on 5.6.1 and 5.7.0
hmmm works fine with the component, let me try on server
It shouldn't make a difference, this was an infra-side change
Oh wait. I think I see what might be wrong here
Will merge the fix shortly, just waiting on CI
Fix should be up now
Looks to work for me
Working here too thank you π