C#•3y ago

❔ Code Not Writing To Text File

So I'm very new to c# (Just Started A couple hours ago) I code other languages though so I'm not a complete beginner but basically all I need help with is diagnosing and fixing why my method wont write to a text file

public static void Writer(string paintingType, int saleVal)
        {
            if (File.Exists("paintingHistory.txt"))
            {

            }
            else
            {
                File.Create("paintingHistory.txt");
            }
            int cost = paint_Types[paintingType];
            string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";

            using (StreamWriter sw = File.AppendText("paintingHistory.txt"))
            {
                sw.WriteLine(data);
            }
            return;
            

        }

public static void Writer(string paintingType, int saleVal)
        {
            if (File.Exists("paintingHistory.txt"))
            {

            }
            else
            {
                File.Create("paintingHistory.txt");
            }
            int cost = paint_Types[paintingType];
            string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";

            using (StreamWriter sw = File.AppendText("paintingHistory.txt"))
            {
                sw.WriteLine(data);
            }
            return;
            

        }

public static void Writer(string paintingType, int saleVal)
        {
            if (File.Exists("paintingHistory.txt"))
            {

            }
            else
            {
                File.Create("paintingHistory.txt");
            }
            int cost = paint_Types[paintingType];
            string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";

            using (StreamWriter sw = File.AppendText("paintingHistory.txt"))
            {
                sw.WriteLine(data);
            }
            return;
            

        }

public static void Writer(string paintingType, int saleVal)
        {
            if (File.Exists("paintingHistory.txt"))
            {

            }
            else
            {
                File.Create("paintingHistory.txt");
            }
            int cost = paint_Types[paintingType];
            string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";

            using (StreamWriter sw = File.AppendText("paintingHistory.txt"))
            {
                sw.WriteLine(data);
            }
            return;
            

        }

Hazel 🌊💃•10/8/23, 1:35 AM

Since you're just starting with C# and simply writing text to a file, I recommend using the simpler File.WriteAllTextFile.WriteAllText method.

Hazel 🌊💃•10/8/23, 1:35 AM

https://learn.microsoft.com/en-us/dotnet/api/system.io.file.writealltext?view=net-7.0

File.WriteAllText Method (System.IO)

Creates a new file, write the contents to the file, and then closes the file. If the target file already exists, it is overwritten.

HHazel 🌊💃Since you're just starting with C# and simply writing text to a file, I recommen...

SolarOP•10/8/23, 1:35 AM

Its multiple inputs over an infinite span of time

Mango•10/8/23, 1:36 AM

Look up StreamWriter or any of the File.WriteAll…. Methods

SolarOP•10/8/23, 1:36 AM

its a data tracker so as data is inputted it needs to append it to a new line

SSolar Its multiple inputs over an infinite span of time

Dropps•10/8/23, 1:36 AM

whats the true problem you trying to achieve then?

SolarOP•10/8/23, 1:36 AM

I did it in python

SolarOP•10/8/23, 1:36 AM

ill send that code so maybe u can kinda understand'

SSolar its a data tracker so as data is inputted it needs to append it to a new line

Dropps•10/8/23, 1:37 AM

whenever you get nrw input just take out all text string append and put back imo

Mango•10/8/23, 1:37 AM

https://learn.microsoft.com/en-us/dotnet/api/system.io.file.appendtext?view=net-7.0

File.AppendText(String) Method (System.IO)

Creates a StreamWriter that appends UTF-8 encoded text to an existing file, or to a new file if the specified file does not exist.

SolarOP•10/8/23, 1:37 AM

def writer(type,price,sold):
    print(type,price,sold)
    text = "{}:{}:{}:\n".format(type,price,sold)
    print(text)
    with open("paintingHistory.txt","a") as f:
        f.write(text)
        f.close()

def writer(type,price,sold):
    print(type,price,sold)
    text = "{}:{}:{}:\n".format(type,price,sold)
    print(text)
    with open("paintingHistory.txt","a") as f:
        f.write(text)
        f.close()

DDropps whenever you get nrw input just take out all text string append and put back imo

Mango•10/8/23, 1:37 AM

God no

SolarOP•10/8/23, 1:37 AM

yea no

SolarOP•10/8/23, 1:37 AM

that seems inefficent as all hell

Mango•10/8/23, 1:37 AM

See my link above

SSolar its a data tracker so as data is inputted it needs to append it to a new line

Hazel 🌊💃•10/8/23, 1:38 AM

string existingData = File.ReadAllText("C:\\paintingHistory.txt");
int cost = paint_Types[paintingType];
string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";
string newData = existingData + data;
File.WriteAllText("C:\\paintingHistory.txt", newData);

string existingData = File.ReadAllText("C:\\paintingHistory.txt");
int cost = paint_Types[paintingType];
string data = paintingType+":" +":"+ Convert.ToString(cost)+":" + Convert.ToString(saleVal)+":\n";
string newData = existingData + data;
File.WriteAllText("C:\\paintingHistory.txt", newData);

Hazel 🌊💃•10/8/23, 1:38 AM

Why can't you do something like that?

SSolar that seems inefficent as all hell

Hazel 🌊💃•10/8/23, 1:38 AM

Solve performance problems when they arise, not ahead of time

SolarOP•10/8/23, 1:38 AM

think about how many lines could come and how inefficent that would end up being

Mango•10/8/23, 1:38 AM

He doesn’t need to do that though

Hazel 🌊💃•10/8/23, 1:38 AM

Is this for practice or a production level application?

Dropps•10/8/23, 1:39 AM

idk if you truly need a txt file for it

a db sounds more appropriate here

Hazel 🌊💃•10/8/23, 1:39 AM

My understanding was that this was for learning

SolarOP•10/8/23, 1:39 AM

practice but I like to get dropped into the deep end

Dropps•10/8/23, 1:39 AM

you have table data

DDropps idk if you truly need a txt file for it a db sounds more appropriate here

Hazel 🌊💃•10/8/23, 1:39 AM

This TBH

SolarOP•10/8/23, 1:39 AM

how do you make a db

Dropps•10/8/23, 1:39 AM

ef core or dapper most commonly ef core

Mango•10/8/23, 1:39 AM

It’s more steps

Hazel 🌊💃•10/8/23, 1:39 AM

Well that's how to interact with it

Mango•10/8/23, 1:40 AM

But do you want to make a text file just as a basic log?

Hazel 🌊💃•10/8/23, 1:40 AM

Depends on which provider you want to go with

SolarOP•10/8/23, 1:40 AM

no no db is good I would like to learn that too

SolarOP•10/8/23, 1:40 AM

any resources for that?

Hazel 🌊💃•10/8/23, 1:40 AM

SQL server is pretty common in the .NET world

SSolar any resources for that?

Dropps•10/8/23, 1:40 AM

just search "ef core"

Mango•10/8/23, 1:40 AM

Then use Microsoft.Data.SqlClient

Dropps•10/8/23, 1:40 AM

and you get a whole load of resources

HHazel 🌊💃SQL server is pretty common in the .NET world

Dropps•10/8/23, 1:40 AM

sqlite for anything smaller

Hazel 🌊💃•10/8/23, 1:41 AM

MongoDB

Mango•10/8/23, 1:41 AM

Learners should not skip the foundations as to why we got to EF Core

Dropps•10/8/23, 1:41 AM

eww

HHazel 🌊💃MongoDB <:kekw:710973294886649956>

Mango•10/8/23, 1:41 AM

Vomit

MMango Learners should not skip the foundations as to why we got to EF Core

Dropps•10/8/23, 1:41 AM

i never wrote a single line of sql myself

DDropps i never wrote a single line of sql myself

Hazel 🌊💃•10/8/23, 1:41 AM

You should

Hazel 🌊💃•10/8/23, 1:41 AM

DDropps i never wrote a single line of sql myself

Mango•10/8/23, 1:42 AM

Congrats. You would be expected to as a full-stack where I am.

Hazel 🌊💃•10/8/23, 1:42 AM

Not saying every day

Hazel 🌊💃•10/8/23, 1:42 AM

But good knowledge to have at least

MMango Congrats. You would be expected to as a full-stack where I am.

Dropps•10/8/23, 1:42 AM

iam a full stack as well

❔ Code Not Writing To Text File

Similar Threads

Similar Threads

Similar Threads