We opted to keep it simple and just pass `context` which we add a validated `env` onto in `server.ts

We opted to keep it simple and just pass

context

context

context

context which we add a validated

env

env

onto in

server.ts

server.ts

server.ts

server.ts.

Alternatively, I know some people are using

AsyncLocalStorage

AsyncLocalStorage

AsyncLocalStorage

AsyncLocalStorage which means you don't have to pass it as an argument

https://developers.cloudflare.com/workers/runtime-apis/nodejs/asynclocalstorage/
https://blog.cloudflare.com/workers-node-js-asynclocalstorage/
pages-discussions

RRandomNick it's a 1 webpage docusaurus site. It feels surprising that the build process fai...

JohnDotAwesome•10/29/23, 3:48 PM

Hrmm that is surprising. I'll bring this up in our team chat, but it may be best to create a ticket with support or at the very least a community forum post. That will help us prioritize

RichOP•10/29/23, 5:38 PM

Is it possible to use

AsyncLocalStorage

AsyncLocalStorage

without bundling?

We're passing the --no-bundle--no-bundle flag to wrangler pages deploywrangler pages deploy so that our Remix sourcemaps work correctly, but would like to try

AsyncLocalStorage

AsyncLocalStorage

(or AsyncContextAsyncContext), however it appears node_compatnode_compat flag is needed which requires bundling.

I wonder if we can bundle in the CF

AsyncLocalStorage

AsyncLocalStorage

impl. ourselves?

James•10/29/23, 5:46 PM

you should be able to use it with the nodejs_compatnodejs_compat flag (not node_compatnode_compat), but without bundling

James•10/29/23, 5:47 PM

https://developers.cloudflare.com/workers/runtime-apis/nodejs/asynclocalstorage/

RichOP•10/29/23, 6:04 PM

I don't think the nodejs_compatnodejs_compat flag works unless you're bundling with wrangler

James•10/29/23, 6:05 PM

nodejs_compatnodejs_compat is for runtime, not when bundling

JJames `nodejs_compat` is for runtime, not when bundling

RichOP•10/29/23, 6:08 PM

I'm trying to dig up where I read node_compat required bundling -- could be mistaken, but bundling definitely has some references to node compat https://github.com/cloudflare/workers-sdk/blob/2526794f214e730f7f88a8146ef24f50c2caf8f6/packages/wrangler/src/deployment-bundle/bundle.ts#L330

GitHub

workers-sdk/packages/wrangler/src/deployment-bundle/bundle.ts at 25...

Home to Wrangler, the CLI for Cloudflare Workers® - cloudflare/workers-sdk

RichOP•10/29/23, 6:08 PM

and my

AsyncLocalStorage

AsyncLocalStorage

doesn't work in my non-bundled remote deploy

James•10/29/23, 6:10 PM

node_compat is a set of polyfills when bundling, nodejs_compat is a set of runtime apis available in workerd

RichOP•10/29/23, 6:10 PM

RichOP•10/29/23, 6:11 PM

oh, ok totally wasn't aware node_compatnode_compat and nodejs_compatnodejs_compat are different things

RichOP•10/29/23, 6:12 PM

maybe it'd actually work at runtime if that block-worker-importsblock-worker-imports check didn't catch it

Original message was deleted

RichOP•10/29/23, 6:38 PM

Cool, I just removed the entire checkRawWorkercheckRawWorker with patch-package and can confirm it worked at runtime

-- will raise an issue in the morning, thanks

JJohnDotAwesome Hrmm that *is* surprising. I'll bring this up in our team chat, but it may be be...

RandomNick•10/29/23, 7:25 PM

Done : https://community.cloudflare.com/t/cf-pages-very-slow-to-build-and-crashes-with-segfault/574362

Cloudflare Community

CF Pages very slow to build, and crashes with segfault

I am posting here, after asking on the discord channel. I have a simple 1 page docusaurus web site with 8 languages. The build process ran properly 2 weeks ago , and I can rebuild previous versions of the page. But today,when building the current version, build is much slower ~1 minute per language, slowing down at each language. It eventuall...

TheAifam5•10/29/23, 8:09 PM

Hey, is there a better way to control environments?

I use Github and Github Flow with Direct Upload. I have a main branch and I would like to deploy everything from feature branches and main branch to "Preview", but only when tag is created, deploy to "Production".

Erisa•10/29/23, 8:11 PM

You can set your production branch for the project to some arbitrary value that won't ever be a branch, then write a GitHub Action whch triggers on tag creation and deploys with the branch name overriden to that value

TheAifam5•10/29/23, 8:14 PM

In Pages created by Direct Upload there is no such option to set it.

I can recreate it to use Git directly but then I get the annoying double deployments on "Preview" environment and a warning that the automatic deployments are disabled.

Is there an option to disable that warning?

Erisa•10/29/23, 8:14 PM

The production branch is set when you create the project and in the case of direct uploads can be changed over the API but not the UI

TheAifam5•10/29/23, 8:15 PM

Is there a CLI option for that through Wrangler?

Erisa•10/29/23, 8:16 PM

No, but if you make an API token you can use curl:

curl -X PATCH "https://api.cloudflare.com/client/v4/accounts/<account id>/pages/projects/<project name>" \
     -H "Authorization: Bearer <api token>\
     -H "Content-Type: application/json" \
     --data '{"production_branch": "main"}'

curl -X PATCH "https://api.cloudflare.com/client/v4/accounts/<account id>/pages/projects/<project name>" \
     -H "Authorization: Bearer <api token>\
     -H "Content-Type: application/json" \
     --data '{"production_branch": "main"}'

(and obviously change

main

main

to something else, along with ID, token and project name)

Erisa•10/29/23, 8:16 PM

If you were happy with recreating the project you can just create it as direct upload also and set the branch name when creating the project

Erisa•10/29/23, 8:16 PM

but for changing it, the above curl should do the trick

TheAifam5•10/29/23, 8:19 PM

Thank you, I see that this production_branchproduction_branch property is not documented at https://developers.cloudflare.com/api/operations/pages-project-update-project, that's expected?

Cloudflare API Documentation

Interact with Cloudflare's products and services via the Cloudflare API

Erisa•10/29/23, 8:20 PM

It should be documented :) not sure why it isn't, good spot

TheAifam5•10/29/23, 8:20 PM

i was just wondering what else I can set

TheAifam5•10/29/23, 8:21 PM

do you know if production_branchproduction_branch allows Regex like v*v* ?

Erisa•10/29/23, 8:22 PM

It does not, it can only be a single branch name

Erisa•10/29/23, 8:22 PM

When youre using direct upload the concept of a branch name is pretty flexible though since you can override which one youre pushing to at will on each deployment regardless of the actual underlying branch

TheAifam5•10/29/23, 8:24 PM

yup, that will do. I can set it before deployment for a specific tag so that in Cloudflare dashboard will be visible as "v0.0.1".

Erisa•10/29/23, 9:04 PM

Sure that works I suppose

TTheAifam5 Thank you, I see that this `production_branch` property is not documented at htt...

Cyb3r-Jak3•10/29/23, 10:50 PM

The create project docs have the actual definitions
https://developers.cloudflare.com/api/operations/pages-project-create-project

Brend4n•10/30/23, 1:39 AM

are you able to set cache-control for assets on cloudflare pages? I noticed that it's always set to cache-control: public, max-age=0, must-revalidatecache-control: public, max-age=0, must-revalidate even if I try to override it with cache rules or page rules

Unsmart•10/30/23, 1:51 AM

You shouldnt be setting cache on pages assets... you used to be able to but maybe they made it where you cant somehow to stop all the people complaining about issues it caused

Unsmart•10/30/23, 1:52 AM

Pages with cache data itself automatically without needing to turn on cache through the cdn

UUnsmart Pages with cache data itself automatically without needing to turn on cache thro...

Brend4n•10/30/23, 2:49 AM

hmm, well i have an SVG for example

Brend4n•10/30/23, 2:49 AM

and it's returning it with the above cache-control headers

Brend4n•10/30/23, 2:50 AM

does it automatically cache any data on client?

Brend4n•10/30/23, 2:50 AM

or what data formats should be cached on client?

Unsmart•10/30/23, 3:11 AM

It caches on the server. You can technically cache any data format on the client but it would only ever be recommended to cache things that are immutable. Personally I just wouldnt cache anything on the client and only use the default cache that pages does on server side

UUnsmart It caches on the server. You can technically cache any data format on the client...

Brend4n•10/30/23, 3:22 AM

yea i mean we have static assets that are immutable that we'd at least want cached for IE 6 hours for example

Brend4n•10/30/23, 3:22 AM

such that they dont have to be re-loaded every time it's visible on the page

fredddde•10/30/23, 8:07 AM

Hey guys, I have some heavier GIFs that I'm trying to upload to the images feature in Cloudflare. It gets denied most likely because it's too big but how do I actually measure my GIFs properties? Like I can see its file size but the limits also mention other parameters like amount of frames-ish?

fredddde•10/30/23, 8:08 AM

This one specifically Animated GIFs, including all frames, are limited to 50 megapixels (MP).Animated GIFs, including all frames, are limited to 50 megapixels (MP).

fredddde•10/30/23, 8:11 AM

It's 7MB, roughly 6-7 seconds long and has the measurement of 1920x1442. Would a solution be to scale down the resolution I assume?

fredddde•10/30/23, 8:40 AM

(Ignore this question, I scaled down the resolution on my GIFs and it works!)

kian•10/30/23, 8:43 AM

Since 1920x1442 is 2.76m pixels, and 50 megapixels is 50 million pixels, I imagine it means that you (with that resolution) would only be able to have ~18 frames

kian•10/30/23, 8:44 AM

As for the amount of frames, uploading it into something like Photopea or ezGif usually shows you them all

fredddde•10/30/23, 8:55 AM

True true, I was guessing that it's probably the amount of frames x resolution. I used gifsicle to lower the resolution and optimize the amount of colors.

Original message was deleted

RichOP•10/30/23, 9:47 AM

I sent a PR here https://github.com/cloudflare/workers-sdk/pull/4303

GitHub

Avoid blocking built-in node modules when using --no-bundle flag by...

What this PR solves / how to test:
We want to import and use the AsyncLocalStorage polyfil in our Remix app, deployed to CF Pages.
However, to ensure Remix sourcemaps actually align with the execut...

agathorpt•10/30/23, 12:59 PM

sorry to ping again, can I have some eyes on : https://github.com/cloudflare/workers-sdk/pull/4225

GitHub

fix: functionPath being full path redirected always to base path by...

Fixes #4192
What this PR solves / how to test:
The redirection for static assets was incorrect. The functionPath sent to the plugin handler was the full path and it was always replaced, leading the...

We opted to keep it simple and just pass `context` which we add a validated `env` onto in `server.ts

Similar Threads

Similar Threads

Similar Threads