Probably for the best so `new URL(req.url)` doesn't break in Service Bindings/Durable Objects

B

Bram•11/17/23, 12:44 PM

anyway thanks for clarifying guys : )

B

Bram•11/17/23, 12:46 PM

one last thing to double check, let's say worker A has a service binding to worker B, and worker B shoud not be accesible from the outside world, I can simply remove all routes of worker B and only communicate with this worker through the service binding of worker A, right?

E

Erisa•11/17/23, 12:49 PM

Correct

B

Bram•11/17/23, 12:49 PM

Great, thanks again everyone

A

Ashley•11/17/23, 12:50 PM

You can set workers_dev = false in wrangler.toml too, just so there’s no URLs generated for it even in dev

B

Bram•11/17/23, 12:52 PM

Good tip, thanks

J

Jeff•11/17/23, 5:18 PM

Does cloudflare have a table displaying what features do and dont work within: Zone, workers.dev, miniflare/local?

Z

zegevlier•11/17/23, 5:22 PM

Not that I know of

Z

zegevlier•11/17/23, 5:23 PM

Any specific features you're curious about?

T

Torzak•11/17/23, 10:07 PM

Hello everyone,

I'm doing a quick test in a worker via the quick editor. I declare a simple global variable that increment by 1 on each request. In preview mode in all goes well 1 +1 +1+ 1 ... BUT when I deploy the worker code in production, the updates go from 3, 5 ,7, 9... each time +2. Is this normal behavior? I may have missed something about how worker works....

Capture_decran_2023-11-17_a_23.03.43.png

T

Torzak•11/17/23, 10:08 PM

this code run here ---> https://worker-fancy-salad-9347.cloudflare-c12.workers.dev/

T

Torzak•11/17/23, 10:13 PM

But of course.... It's obvious now you say it. I use Pages more often and I didn't think that the Worker would handle the favicon request as well!! Thank you so much Leo!!!!

T

Torzak•11/17/23, 10:14 PM

I'm going back to hide in shame :p

I

iCrashed•11/18/23, 12:38 AM

I want to receive in-app feedback from mobile users. Server side, I need to verify a key with a Google Play API. Would waiting for Google's response count against my worker's CPU time? Am I approaching this right?

IiCrashed I want to receive in-app feedback from mobile users. Server side, I need to veri...

C

Cyb3r-Jak3•11/18/23, 1:04 AM

Not unless you use unbound workers. Standard and Bundled plans only count for IO time

W

warflash•11/18/23, 1:07 PM

Do we need to redeploy workers after changing to standard billing in order for it to switch?

S

Stefatorus•11/18/23, 1:16 PM

Is it normal for HTMLRewriter to output garbled characters?

Link element, tag: fn&Ī*k�<�ʣ

Link element, tag: fn&Ī*k�<�ʣ

Link element, tag: fn&Ī*k�<�ʣ

Link element, tag: fn&Ī*k�<�ʣ

\

S

Stefatorus•11/18/23, 1:16 PM

  let rewriter = new HTMLRewriter().onDocument(new DocumentHandler(context))
    .on("*", new LinkHandler(context))
    .on("*", new AttributeTranslationHandler(context));

  // Add element text translation handler for all elements that are allowed to be translated
  for (let element of config.translation["translate-behaviour"]["allowed-tags"]) {
    rewriter = rewriter.on(`[${element}]`, new AttributeTranslationHandler(context));
  }

  return rewriter.transform(fetchResult);

  let rewriter = new HTMLRewriter().onDocument(new DocumentHandler(context))
    .on("*", new LinkHandler(context))
    .on("*", new AttributeTranslationHandler(context));

  // Add element text translation handler for all elements that are allowed to be translated
  for (let element of config.translation["translate-behaviour"]["allowed-tags"]) {
    rewriter = rewriter.on(`[${element}]`, new AttributeTranslationHandler(context));
  }

  return rewriter.transform(fetchResult);

  let rewriter = new HTMLRewriter().onDocument(new DocumentHandler(context))
    .on("*", new LinkHandler(context))
    .on("*", new AttributeTranslationHandler(context));

  // Add element text translation handler for all elements that are allowed to be translated
  for (let element of config.translation["translate-behaviour"]["allowed-tags"]) {
    rewriter = rewriter.on(`[${element}]`, new AttributeTranslationHandler(context));
  }

  return rewriter.transform(fetchResult);

  let rewriter = new HTMLRewriter().onDocument(new DocumentHandler(context))
    .on("*", new LinkHandler(context))
    .on("*", new AttributeTranslationHandler(context));

  // Add element text translation handler for all elements that are allowed to be translated
  for (let element of config.translation["translate-behaviour"]["allowed-tags"]) {
    rewriter = rewriter.on(`[${element}]`, new AttributeTranslationHandler(context));
  }

  return rewriter.transform(fetchResult);

S

Stefatorus•11/18/23, 1:17 PM

class LinkHandler implements HTMLRewriterElementContentHandlers {

  // Current URL
  context: EventContext<any, any, any>;
  currentURL: string;

  constructor(context: EventContext<any, any, any>) {
    this.context = context;
    this.currentURL = context.request.url;
  }

  // Go through all attributes in the config (src, href, etc) and rewrite them to the correct URI
  element(element: Element) {
    // Show the element type and id
    console.log(`Link element, tag: ${element.tagName}`);
    // // Check if the element has any rewriteable attributes
    for (let attribute of config["reverse-proxy"]["proxied-attributes"]) {
      // Check if the element has the attribute
      if (!element.getAttribute(attribute)) {
        // Rewrite the attribute
        continue;
      }

      // Check the current locale, and prepend it to the URL in the attribute
      let currentLocale = getCurrentLocale(new URL(this.currentURL));

      // If no current locale, then continue
      if (!currentLocale) {
        continue;
      }

      // Replace the "target-url" with "target-url"/currentLocale/
      let new_attribute = element.getAttribute(attribute).replace(config["reverse-proxy"]["target-url"], `${config["reverse-proxy"]["target-url"]}/${currentLocale}`);

      // If it's different, then log it and change it
      if (new_attribute == element.getAttribute(attribute)) {
        continue;
      }

      console.log("Changed attribute from " + element.getAttribute(attribute) + " to " + new_attribute + " for attribute " + attribute + " on element " + element.tagName);
      element.setAttribute(attribute, new_attribute);
    }

    // Kma
  }
}

class LinkHandler implements HTMLRewriterElementContentHandlers {

  // Current URL
  context: EventContext<any, any, any>;
  currentURL: string;

  constructor(context: EventContext<any, any, any>) {
    this.context = context;
    this.currentURL = context.request.url;
  }

  // Go through all attributes in the config (src, href, etc) and rewrite them to the correct URI
  element(element: Element) {
    // Show the element type and id
    console.log(`Link element, tag: ${element.tagName}`);
    // // Check if the element has any rewriteable attributes
    for (let attribute of config["reverse-proxy"]["proxied-attributes"]) {
      // Check if the element has the attribute
      if (!element.getAttribute(attribute)) {
        // Rewrite the attribute
        continue;
      }

      // Check the current locale, and prepend it to the URL in the attribute
      let currentLocale = getCurrentLocale(new URL(this.currentURL));

      // If no current locale, then continue
      if (!currentLocale) {
        continue;
      }

      // Replace the "target-url" with "target-url"/currentLocale/
      let new_attribute = element.getAttribute(attribute).replace(config["reverse-proxy"]["target-url"], `${config["reverse-proxy"]["target-url"]}/${currentLocale}`);

      // If it's different, then log it and change it
      if (new_attribute == element.getAttribute(attribute)) {
        continue;
      }

      console.log("Changed attribute from " + element.getAttribute(attribute) + " to " + new_attribute + " for attribute " + attribute + " on element " + element.tagName);
      element.setAttribute(attribute, new_attribute);
    }

    // Kma
  }
}

class LinkHandler implements HTMLRewriterElementContentHandlers {

  // Current URL
  context: EventContext<any, any, any>;
  currentURL: string;

  constructor(context: EventContext<any, any, any>) {
    this.context = context;
    this.currentURL = context.request.url;
  }

  // Go through all attributes in the config (src, href, etc) and rewrite them to the correct URI
  element(element: Element) {
    // Show the element type and id
    console.log(`Link element, tag: ${element.tagName}`);
    // // Check if the element has any rewriteable attributes
    for (let attribute of config["reverse-proxy"]["proxied-attributes"]) {
      // Check if the element has the attribute
      if (!element.getAttribute(attribute)) {
        // Rewrite the attribute
        continue;
      }

      // Check the current locale, and prepend it to the URL in the attribute
      let currentLocale = getCurrentLocale(new URL(this.currentURL));

      // If no current locale, then continue
      if (!currentLocale) {
        continue;
      }

      // Replace the "target-url" with "target-url"/currentLocale/
      let new_attribute = element.getAttribute(attribute).replace(config["reverse-proxy"]["target-url"], `${config["reverse-proxy"]["target-url"]}/${currentLocale}`);

      // If it's different, then log it and change it
      if (new_attribute == element.getAttribute(attribute)) {
        continue;
      }

      console.log("Changed attribute from " + element.getAttribute(attribute) + " to " + new_attribute + " for attribute " + attribute + " on element " + element.tagName);
      element.setAttribute(attribute, new_attribute);
    }

    // Kma
  }
}

class LinkHandler implements HTMLRewriterElementContentHandlers {

  // Current URL
  context: EventContext<any, any, any>;
  currentURL: string;

  constructor(context: EventContext<any, any, any>) {
    this.context = context;
    this.currentURL = context.request.url;
  }

  // Go through all attributes in the config (src, href, etc) and rewrite them to the correct URI
  element(element: Element) {
    // Show the element type and id
    console.log(`Link element, tag: ${element.tagName}`);
    // // Check if the element has any rewriteable attributes
    for (let attribute of config["reverse-proxy"]["proxied-attributes"]) {
      // Check if the element has the attribute
      if (!element.getAttribute(attribute)) {
        // Rewrite the attribute
        continue;
      }

      // Check the current locale, and prepend it to the URL in the attribute
      let currentLocale = getCurrentLocale(new URL(this.currentURL));

      // If no current locale, then continue
      if (!currentLocale) {
        continue;
      }

      // Replace the "target-url" with "target-url"/currentLocale/
      let new_attribute = element.getAttribute(attribute).replace(config["reverse-proxy"]["target-url"], `${config["reverse-proxy"]["target-url"]}/${currentLocale}`);

      // If it's different, then log it and change it
      if (new_attribute == element.getAttribute(attribute)) {
        continue;
      }

      console.log("Changed attribute from " + element.getAttribute(attribute) + " to " + new_attribute + " for attribute " + attribute + " on element " + element.tagName);
      element.setAttribute(attribute, new_attribute);
    }

    // Kma
  }
}

\

S

Stefatorus•11/18/23, 1:26 PM

Attribute translator -  tag: z�                                                                                                                                                                                                     
Link element, tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                                       
Attribute translator -  tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                             
Link element, tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��                                                                                                                                                        
Attribute translator -  tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��

Attribute translator -  tag: z�                                                                                                                                                                                                     
Link element, tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                                       
Attribute translator -  tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                             
Link element, tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��                                                                                                                                                        
Attribute translator -  tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��

Attribute translator -  tag: z�                                                                                                                                                                                                     
Link element, tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                                       
Attribute translator -  tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                             
Link element, tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��                                                                                                                                                        
Attribute translator -  tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��

Attribute translator -  tag: z�                                                                                                                                                                                                     
Link element, tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                                       
Attribute translator -  tag: l$¶x��t��Śfo�k[����ң☺�e؜��                                                                                                                                                                             
Link element, tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��                                                                                                                                                        
Attribute translator -  tag: p�޳�0�#|�♠���$�ӌ�◄§�-f}tda�"~w��+�?ͩ�f+k���m�y@�p��7��▲��

S

Stefatorus•11/18/23, 1:26 PM

Not sure why it behaves like this

S

Stefatorus•11/18/23, 1:31 PM

Seems to be wrangler-related

S

Stefatorus•11/18/23, 1:34 PM

Note: Fixed by downgrading to wrangler 2.x

Wwarflash Do we need to redeploy workers after changing to standard billing in order for i...

C

Cyb3r-Jak3•11/18/23, 1:45 PM

Workers should auto redeploy when you change the plan

CCyb3r-Jak3 Workers should auto redeploy when you change the plan

W

warflash•11/18/23, 1:48 PM

Thanks. Based on the docs and info I found I assumed the same when I changed it a few weeks ago. Though our unbound request count is now at 10 million and standard at 150. So I suspect something might have gone wrong. Guess I'll try a manual redeploy

Wwarflash Thanks. Based on the docs and info I found I assumed the same when I changed it ...

C

Cyb3r-Jak3•11/18/23, 2:14 PM

If you have unbound in your wrangler file then you’ll need to change it there as well

CCyb3r-Jak3 If you have unbound in your wrangler file then you’ll need to change it there as...

W

warflash•11/18/23, 3:03 PM

Ah yes, that was it. Thanks! Surprisingly it does seem like the standard model is going to be like 50% more expensive than unbound even though the calculator sound it'll be 70% cheaper. Odd

A

anziez•11/18/23, 7:07 PM

why can't I install wrangler D:

Aanziez why can't I install wrangler D:

H

Hello, I’m Allie!•11/18/23, 8:01 PM

Are you installing it globally?

K

kianOP•11/18/23, 8:26 PM

K

kianOP•11/18/23, 8:26 PM

Where's the issue? meowthinking

K

kianOP•11/18/23, 9:13 PM

That'll be if you put in lon, lat

K

kianOP•11/18/23, 9:13 PM

It should be lat, lon

I

Isaac McFadyen•11/18/23, 10:14 PM

Keep in mind it's using MaxMind's GeoIP database, so it's entirely possible for it to be inaccurate yes.

U

Unsmart•11/18/23, 10:15 PM

Well I would assume if they give a city the long/lat will always actually be in the city but the actual location it says might not be accurate yeah fastnod

UUnsmart Well I would assume if they give a city the long/lat will always actually be in ...

I

Isaac McFadyen•11/18/23, 11:11 PM

Yeah.

I

Isaac McFadyen•11/18/23, 11:11 PM

Like, for example, I use Starlink which is CGNAT. So the IP is Toronto (not where I am, about 2 hours away)

I

Isaac McFadyen•11/18/23, 11:11 PM

The lon/lat is inside Toronto but I'm not in Toronto lul

G

GuillaumeLakano•11/19/23, 1:13 PM

Hi! Is anyone already tried to compare script code in Javascript in a Workers with the same code in WASM to known if there is interest to code it for example in AssemblyScript ( a variant of TypeScript that generate a WebAssembly code ) ?

GGuillaumeLakano Hi! Is anyone already tried to compare script code in Javascript in a Workers wi...

H

Hello, I’m Allie!•11/19/23, 1:29 PM

If you are already writing in (Types)Script, then I wouldn't bother rewriting it in AssemblyScript(unless you are doing it as a learning exercise).

HHello, I’m Allie!If you are already writing in (Types)Script, then I wouldn't bother rewriting it...

G

GuillaumeLakano•11/19/23, 1:44 PM

I'm not used to do TypeScript, but as I've just discover this AssemblyScript that directly return the .wasm file, may be this could be a good change for my workers

GGuillaumeLakano I'm not used to do TypeScript, but as I've just discover this AssemblyScript tha...

H

Hello, I’m Allie!•11/19/23, 1:46 PM

Yeah, as a way to learn about how WASM works, it can be a great excercise. I just mean that where possible, raw JS may be preferred over WASM, due to performance reasons. With something like

workers-rs

workers-rs

workers-rs

workers-rs, you get the benefits of Rust's borrow-checker(and all the other goodies), but if you are using something like AssemblyScript, then I wouldn't see much benefit there(performance-wise, anyway).

HHello, I’m Allie!Yeah, as a way to learn about how WASM works, it can be a great excercise. I jus...

G

GuillaumeLakano•11/19/23, 1:49 PM

Thank you for the precision

B

Bulbasaur•11/19/23, 9:31 PM

Are there plans for smart placement to support multiple "smart locations"? For example if you have a standard replicated database with 6 locations around the world, workers could hypothetically determine that it should use smart placement in those 6 locations, and not restrict itself to one of them

B

Bulbasaur•11/19/23, 9:32 PM

Today, smart placement unfortunately feels like a not great compromise between "always completely global" and just back to being "single region"

B

Bulbasaur•11/19/23, 9:51 PM

Even if it wasn't necessarily completely automated for every possible ingress or whatever, something like "evaluate smart placement per-country" would be a massive improvement

M

mooon•11/19/23, 10:41 PM

hey there, if i were to create a worker that responds with a pretty large image

, would it be automatically streamed? are there any automatic optimisations cloudflare does?

Probably for the best so `new URL(req.url)` doesn't break in Service Bindings/Durable Objects

Similar Threads

Similar Threads

Similar Threads