✅ else statement executing regardless of whether I want it to or not, windows form app

Hhugheselite

11/21/2023

I've created a simple windows form app to create shapes on a bitmap, I have a function that gives an error if the user inputs an invalid input. it's currently executing even if the input is valid.. I'm pretty sure it's a simple fix would just appreciate an extra pair of eyes on this one lol https://paste.mod.gg/xpjzxfmjjeik/0 else function is right at the bottom I feel i'm being real stupid here

TThinker

11/21/2023

There are a lot of else cases here, which one do you mean? Also this would be an ideal situation to use a switch statement

Hhugheselite

11/21/2023

the one at the very bottom { ErrorHandlingWindow.Text = InvalidCommandMessage; return; }

TThinker

11/21/2023

Only situation in which that could execute is if none of the above cases succeeded

Hhugheselite

11/21/2023

I realised this when I'd implemented nearly everything haha 😦

TThinker

11/21/2023

Have you tried debugging the code? The most obvious answer would be that CommandSplit[0] is not what you're expecting it to be

Hhugheselite

11/21/2023

it's still executing even if a condition is working for example

Hhugheselite

11/21/2023

Hhugheselite

11/21/2023

even though the circle was drawn on th bitmap fine, still outputs the error message

ZZacharyPatten

11/21/2023

if you share the full code (preferably with a github repo link) then we could help you. but without the full code it is hard for us to help other than encouraging you to put breakpoints and debug

Hhugheselite

11/21/2023

i've posted the full code in the thread 🙂

ZZacharyPatten

11/21/2023

that isn't the full code

Hhugheselite

11/21/2023

this one

ZZacharyPatten

11/21/2023

we cannot run that

TThinker

11/21/2023

that's one file

Hhugheselite

11/21/2023

ohh got you okay sure yes my bad one moment https://bitbucket.org/110794-main-workspace/ase-component-1/src/master/ Could you please let me know if this is downloadable? thank you

ZZacharyPatten

11/21/2023

it is. I tested "circle 25" and it seemed to work. what input are you testing that is still hitting the else that you don't want it to? o wait I was testing the button when you press Enter is when it is running the code twice One moment SingleCommandLine.KeyDown += singleCommandLine_KeyDown_1; SingleCommandLine.KeyDown += singleCommandLine_KeyDown_1; you are binding your event handler twice so every time you press enter it is currently runnign the code twice in your Form1.Designer.cs class is where that is happening one on line 165 and one on line 52 you clear the text box during the code, so if you run the code twice, the first run will clear the text box so that the second time it runs it will be blank and therefore cause the error you are seeing so in short... you should remove one of the double event bindings you should only have one binding for that event handler

ZZacharyPatten

11/21/2023

ZZacharyPatten

11/21/2023

sorry I know that is low quality of a screenshot, but hopefully you see can see where the two bindings are

Hhugheselite

11/21/2023

There is currently an IT guy installing a new router in my office In about 20 mins I'm going to go an edit my code Your logic sounds 100% correct here to me so thank you vm for your time You are completely correct and fixed the issue If you don't mind sharing how you went about figuring out the problem? that'd be wonderful

ZZacharyPatten

11/21/2023

I saw this and I pretty much immediately knew the issue: